diff options
author | Tom Zanussi <tzanussi@gmail.com> | 2010-01-27 03:27:52 -0500 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2010-02-23 14:34:42 -0500 |
commit | f526d68b6ce9ba7a2bd94e663e240a022524c58a (patch) | |
tree | 26b1477259ac0563ba90106a451e40aaa7904321 /tools | |
parent | faa5c5c36ec50bf43e39c7798ce9701e6b002db3 (diff) |
perf/scripts: Fix supported language listing option
'perf trace -s list' prints a list of the supported scripting
languages. One problem with it is that it falls through and prints
the trace as well. The use of 'list' for this also makes it easy to
confuse with 'perf trace -l', used for listing available scripts. So
change 'perf trace -s list' to 'perf trace -s lang' and fixes the
fall-through problem.
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Keiichi KII <k-keiichi@bx.jp.nec.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <1264580883-15324-2-git-send-email-tzanussi@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/Documentation/perf-trace.txt | 4 | ||||
-rw-r--r-- | tools/perf/builtin-trace.c | 4 |
2 files changed, 5 insertions, 3 deletions
diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt index 60e5900da483..c00a76fcb8d6 100644 --- a/tools/perf/Documentation/perf-trace.txt +++ b/tools/perf/Documentation/perf-trace.txt | |||
@@ -45,9 +45,11 @@ OPTIONS | |||
45 | --list=:: | 45 | --list=:: |
46 | Display a list of available trace scripts. | 46 | Display a list of available trace scripts. |
47 | 47 | ||
48 | -s:: | 48 | -s ['lang']:: |
49 | --script=:: | 49 | --script=:: |
50 | Process trace data with the given script ([lang]:script[.ext]). | 50 | Process trace data with the given script ([lang]:script[.ext]). |
51 | If the string 'lang' is specified in place of a script name, a | ||
52 | list of supported languages will be displayed instead. | ||
51 | 53 | ||
52 | -g:: | 54 | -g:: |
53 | --gen-script=:: | 55 | --gen-script=:: |
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 0b65779e3c10..d5d20c34e221 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c | |||
@@ -219,9 +219,9 @@ static int parse_scriptname(const struct option *opt __used, | |||
219 | const char *script, *ext; | 219 | const char *script, *ext; |
220 | int len; | 220 | int len; |
221 | 221 | ||
222 | if (strcmp(str, "list") == 0) { | 222 | if (strcmp(str, "lang") == 0) { |
223 | list_available_languages(); | 223 | list_available_languages(); |
224 | return 0; | 224 | exit(0); |
225 | } | 225 | } |
226 | 226 | ||
227 | script = strchr(str, ':'); | 227 | script = strchr(str, ':'); |