diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-03-21 03:18:52 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-03-21 12:37:37 -0400 |
commit | ebf3c675d7e4ba97568dd6daaa43b1af10046b29 (patch) | |
tree | de6437e78fabe644636cd18a12fba77ca4ece5df /tools | |
parent | 452958fdd05b43b6c91cfd1341f4fac2f3ce661f (diff) |
perf tools: Cleanup calc_data_size logic
It's for calculating whole trace data size during reading. However
relation functions are called only in this file, no need to
conditionalize it with tricky +1 offset and rename the variable to
more meaningful name like trace_data_size.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1363850332-25297-10-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/util/trace-event-read.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c index 644ad3b4edec..af215c0d2379 100644 --- a/tools/perf/util/trace-event-read.c +++ b/tools/perf/util/trace-event-read.c | |||
@@ -43,7 +43,7 @@ int file_bigendian; | |||
43 | int host_bigendian; | 43 | int host_bigendian; |
44 | static int long_size; | 44 | static int long_size; |
45 | 45 | ||
46 | static ssize_t calc_data_size; | 46 | static ssize_t trace_data_size; |
47 | static bool repipe; | 47 | static bool repipe; |
48 | 48 | ||
49 | static int __do_read(int fd, void *buf, int size) | 49 | static int __do_read(int fd, void *buf, int size) |
@@ -83,8 +83,7 @@ static int do_read(void *data, int size) | |||
83 | return -1; | 83 | return -1; |
84 | } | 84 | } |
85 | 85 | ||
86 | if (calc_data_size) | 86 | trace_data_size += r; |
87 | calc_data_size += r; | ||
88 | 87 | ||
89 | return r; | 88 | return r; |
90 | } | 89 | } |
@@ -155,8 +154,7 @@ static char *read_string(void) | |||
155 | break; | 154 | break; |
156 | } | 155 | } |
157 | 156 | ||
158 | if (calc_data_size) | 157 | trace_data_size += size; |
159 | calc_data_size += size; | ||
160 | 158 | ||
161 | str = malloc(size); | 159 | str = malloc(size); |
162 | if (str) | 160 | if (str) |
@@ -356,9 +354,7 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe) | |||
356 | 354 | ||
357 | *ppevent = NULL; | 355 | *ppevent = NULL; |
358 | 356 | ||
359 | calc_data_size = 1; | ||
360 | repipe = __repipe; | 357 | repipe = __repipe; |
361 | |||
362 | input_fd = fd; | 358 | input_fd = fd; |
363 | 359 | ||
364 | if (do_read(buf, 3) < 0) | 360 | if (do_read(buf, 3) < 0) |
@@ -417,8 +413,7 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe) | |||
417 | if (err) | 413 | if (err) |
418 | goto out; | 414 | goto out; |
419 | 415 | ||
420 | size = calc_data_size - 1; | 416 | size = trace_data_size; |
421 | calc_data_size = 0; | ||
422 | repipe = false; | 417 | repipe = false; |
423 | 418 | ||
424 | if (show_funcs) { | 419 | if (show_funcs) { |