diff options
author | Chris J Arges <chris.j.arges@canonical.com> | 2014-08-27 14:26:53 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2014-09-19 20:12:52 -0400 |
commit | fee9d3e61d04422628a3d22ed5eb8370dcef259b (patch) | |
tree | 195f34d75a12e29c936b793e8af8f4e66460a296 /tools/testing | |
parent | 23a0e1611b880bd8d94bbebcb3577c9f78029435 (diff) |
ktest: add ability to skip during BISECT_MANUAL
When doing a manual bisect, a build can fail or a test can be inconclusive.
In these cases it would be helpful to be able to skip the test entirely.
Link: http://lkml.kernel.org/r/1409164021-2136-1-git-send-email-chris.j.arges@canonical.com
Reviewed-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'tools/testing')
-rwxr-xr-x | tools/testing/ktest/ktest.pl | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 3b7a180d9c0d..085452fa045b 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl | |||
@@ -2338,15 +2338,17 @@ sub success { | |||
2338 | 2338 | ||
2339 | sub answer_bisect { | 2339 | sub answer_bisect { |
2340 | for (;;) { | 2340 | for (;;) { |
2341 | doprint "Pass or fail? [p/f]"; | 2341 | doprint "Pass, fail, or skip? [p/f/s]"; |
2342 | my $ans = <STDIN>; | 2342 | my $ans = <STDIN>; |
2343 | chomp $ans; | 2343 | chomp $ans; |
2344 | if ($ans eq "p" || $ans eq "P") { | 2344 | if ($ans eq "p" || $ans eq "P") { |
2345 | return 1; | 2345 | return 1; |
2346 | } elsif ($ans eq "f" || $ans eq "F") { | 2346 | } elsif ($ans eq "f" || $ans eq "F") { |
2347 | return 0; | 2347 | return 0; |
2348 | } elsif ($ans eq "s" || $ans eq "S") { | ||
2349 | return -1; | ||
2348 | } else { | 2350 | } else { |
2349 | print "Please answer 'P' or 'F'\n"; | 2351 | print "Please answer 'p', 'f', or 's'\n"; |
2350 | } | 2352 | } |
2351 | } | 2353 | } |
2352 | } | 2354 | } |