diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-03-11 03:43:15 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-03-15 12:06:02 -0400 |
commit | 6ef73ec449af998ca34673636d00decc8e808544 (patch) | |
tree | 34b558440b9b8874659fe9457fe72a76a5a24c53 /tools/perf | |
parent | b3a319d528fd57ef600731ee1b84d00b7204881d (diff) |
perf evlist: Pass struct perf_target to perf_evlist__prepare_workload()
It's a preparation step of removing @opts arg from the function so that
it can be used more widely.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1362987798-24969-4-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r-- | tools/perf/builtin-record.c | 3 | ||||
-rw-r--r-- | tools/perf/builtin-trace.c | 3 | ||||
-rw-r--r-- | tools/perf/tests/perf-record.c | 2 | ||||
-rw-r--r-- | tools/perf/util/evlist.c | 3 | ||||
-rw-r--r-- | tools/perf/util/evlist.h | 1 |
5 files changed, 8 insertions, 4 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index e3261eae0ad7..a80301797e89 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c | |||
@@ -474,7 +474,8 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv) | |||
474 | } | 474 | } |
475 | 475 | ||
476 | if (forks) { | 476 | if (forks) { |
477 | err = perf_evlist__prepare_workload(evsel_list, opts, argv); | 477 | err = perf_evlist__prepare_workload(evsel_list, &opts->target, |
478 | opts, argv); | ||
478 | if (err < 0) { | 479 | if (err < 0) { |
479 | pr_err("Couldn't run the workload!\n"); | 480 | pr_err("Couldn't run the workload!\n"); |
480 | goto out_delete_session; | 481 | goto out_delete_session; |
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 6198eb11e1c6..1de3971437c9 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c | |||
@@ -461,7 +461,8 @@ static int trace__run(struct trace *trace, int argc, const char **argv) | |||
461 | signal(SIGINT, sig_handler); | 461 | signal(SIGINT, sig_handler); |
462 | 462 | ||
463 | if (forks) { | 463 | if (forks) { |
464 | err = perf_evlist__prepare_workload(evlist, &trace->opts, argv); | 464 | err = perf_evlist__prepare_workload(evlist, &trace->opts.target, |
465 | &trace->opts, argv); | ||
465 | if (err < 0) { | 466 | if (err < 0) { |
466 | printf("Couldn't run the workload!\n"); | 467 | printf("Couldn't run the workload!\n"); |
467 | goto out_delete_evlist; | 468 | goto out_delete_evlist; |
diff --git a/tools/perf/tests/perf-record.c b/tools/perf/tests/perf-record.c index f6ba75a983a8..adf6b4a21a60 100644 --- a/tools/perf/tests/perf-record.c +++ b/tools/perf/tests/perf-record.c | |||
@@ -93,7 +93,7 @@ int test__PERF_RECORD(void) | |||
93 | * so that we have time to open the evlist (calling sys_perf_event_open | 93 | * so that we have time to open the evlist (calling sys_perf_event_open |
94 | * on all the fds) and then mmap them. | 94 | * on all the fds) and then mmap them. |
95 | */ | 95 | */ |
96 | err = perf_evlist__prepare_workload(evlist, &opts, argv); | 96 | err = perf_evlist__prepare_workload(evlist, &opts.target, &opts, argv); |
97 | if (err < 0) { | 97 | if (err < 0) { |
98 | pr_debug("Couldn't run the workload!\n"); | 98 | pr_debug("Couldn't run the workload!\n"); |
99 | goto out_delete_maps; | 99 | goto out_delete_maps; |
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 7d71a691b864..291884c804e9 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c | |||
@@ -745,6 +745,7 @@ out_err: | |||
745 | } | 745 | } |
746 | 746 | ||
747 | int perf_evlist__prepare_workload(struct perf_evlist *evlist, | 747 | int perf_evlist__prepare_workload(struct perf_evlist *evlist, |
748 | struct perf_target *target, | ||
748 | struct perf_record_opts *opts, | 749 | struct perf_record_opts *opts, |
749 | const char *argv[]) | 750 | const char *argv[]) |
750 | { | 751 | { |
@@ -800,7 +801,7 @@ int perf_evlist__prepare_workload(struct perf_evlist *evlist, | |||
800 | exit(-1); | 801 | exit(-1); |
801 | } | 802 | } |
802 | 803 | ||
803 | if (perf_target__none(&opts->target)) | 804 | if (perf_target__none(target)) |
804 | evlist->threads->map[0] = evlist->workload.pid; | 805 | evlist->threads->map[0] = evlist->workload.pid; |
805 | 806 | ||
806 | close(child_ready_pipe[1]); | 807 | close(child_ready_pipe[1]); |
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h index 9a7b76e3a873..e089906cb4de 100644 --- a/tools/perf/util/evlist.h +++ b/tools/perf/util/evlist.h | |||
@@ -86,6 +86,7 @@ void perf_evlist__config(struct perf_evlist *evlist, | |||
86 | struct perf_record_opts *opts); | 86 | struct perf_record_opts *opts); |
87 | 87 | ||
88 | int perf_evlist__prepare_workload(struct perf_evlist *evlist, | 88 | int perf_evlist__prepare_workload(struct perf_evlist *evlist, |
89 | struct perf_target *target, | ||
89 | struct perf_record_opts *opts, | 90 | struct perf_record_opts *opts, |
90 | const char *argv[]); | 91 | const char *argv[]); |
91 | int perf_evlist__start_workload(struct perf_evlist *evlist); | 92 | int perf_evlist__start_workload(struct perf_evlist *evlist); |