diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-12-20 00:11:12 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-12-20 11:34:53 -0500 |
commit | a42101418072d3be357b534521be2849518611e6 (patch) | |
tree | c8eb768c64ab0c7a85ff33912d1f466325182807 /tools/perf | |
parent | cc22e575a6fddbe3183ac14c28e2f792704995c5 (diff) |
perf report: Use pr_*() functions where applicable
There're some places printing messages to stdout/err directly.
It should be converted to use proper error printing functions instead.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1387516278-17024-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r-- | tools/perf/builtin-report.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index ec7399a84872..0c9ec3e3f0fc 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
@@ -242,8 +242,8 @@ static int process_sample_event(struct perf_tool *tool, | |||
242 | int ret; | 242 | int ret; |
243 | 243 | ||
244 | if (perf_event__preprocess_sample(event, machine, &al, sample) < 0) { | 244 | if (perf_event__preprocess_sample(event, machine, &al, sample) < 0) { |
245 | fprintf(stderr, "problem processing %d event, skipping it.\n", | 245 | pr_debug("problem processing %d event, skipping it.\n", |
246 | event->header.type); | 246 | event->header.type); |
247 | return -1; | 247 | return -1; |
248 | } | 248 | } |
249 | 249 | ||
@@ -637,7 +637,7 @@ parse_callchain_opt(const struct option *opt, const char *arg, int unset) | |||
637 | return -1; | 637 | return -1; |
638 | setup: | 638 | setup: |
639 | if (callchain_register_param(&callchain_param) < 0) { | 639 | if (callchain_register_param(&callchain_param) < 0) { |
640 | fprintf(stderr, "Can't register callchain params\n"); | 640 | pr_err("Can't register callchain params\n"); |
641 | return -1; | 641 | return -1; |
642 | } | 642 | } |
643 | return 0; | 643 | return 0; |
@@ -859,7 +859,7 @@ repeat: | |||
859 | } | 859 | } |
860 | if (report.mem_mode) { | 860 | if (report.mem_mode) { |
861 | if (sort__mode == SORT_MODE__BRANCH) { | 861 | if (sort__mode == SORT_MODE__BRANCH) { |
862 | fprintf(stderr, "branch and mem mode incompatible\n"); | 862 | pr_err("branch and mem mode incompatible\n"); |
863 | goto error; | 863 | goto error; |
864 | } | 864 | } |
865 | sort__mode = SORT_MODE__MEMORY; | 865 | sort__mode = SORT_MODE__MEMORY; |