diff options
author | Masami Hiramatsu <mhiramat@redhat.com> | 2010-04-14 18:39:35 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-04-14 16:41:14 -0400 |
commit | dd259c5db26ccda46409dbf6efc79d5a2b259e38 (patch) | |
tree | c392f55f5a6529c053c1a5581d96b007f2a92229 /tools/perf | |
parent | 7ca5989dd065cbc48a958666c273794686ea7525 (diff) |
perf probe: Fix mis-estimation for shortening filename
Fix mis-estimation size for making a short filename.
Since the buffer size is 32 bytes and there are '@' prefix and
'\0' termination, maximum shorten filename length should be
30. This means, before searching '/', it should be 31 bytes.
LKML-Reference: <20100414223935.14630.11954.stgit@localhost6.localdomain6>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r-- | tools/perf/util/probe-event.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 1c4a20a284c0..6d438391bae5 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c | |||
@@ -806,12 +806,12 @@ static char *synthesize_perf_probe_point(struct perf_probe_point *pp) | |||
806 | goto error; | 806 | goto error; |
807 | } | 807 | } |
808 | if (pp->file) { | 808 | if (pp->file) { |
809 | len = strlen(pp->file) - 32; | 809 | len = strlen(pp->file) - 31; |
810 | if (len < 0) | 810 | if (len < 0) |
811 | len = 0; | 811 | len = 0; |
812 | tmp = strchr(pp->file + len, '/'); | 812 | tmp = strchr(pp->file + len, '/'); |
813 | if (!tmp) | 813 | if (!tmp) |
814 | tmp = pp->file + len - 1; | 814 | tmp = pp->file + len; |
815 | ret = e_snprintf(file, 32, "@%s", tmp + 1); | 815 | ret = e_snprintf(file, 32, "@%s", tmp + 1); |
816 | if (ret <= 0) | 816 | if (ret <= 0) |
817 | goto error; | 817 | goto error; |