aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2012-04-18 15:07:38 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-04-18 15:07:38 -0400
commitd86b0597c4bd41ea3edc6446a855306eed34f93b (patch)
treea2363453f0073ccaf7defddde7ac703a2a71bbd9 /tools/perf/util
parent4f9d03251b9d202ebce805757360ef0fac5eb74e (diff)
perf annotate: Parse call targets earlier
No need to do it everytime the user presses enter/-> on a call instruction. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-ybgss44m5ycry8mk7b1qdbre@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util')
-rw-r--r--tools/perf/util/annotate.c18
-rw-r--r--tools/perf/util/annotate.h1
2 files changed, 18 insertions, 1 deletions
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 4ee2c07924bc..a4296fdd9a68 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -18,6 +18,21 @@
18 18
19const char *disassembler_style; 19const char *disassembler_style;
20 20
21static int call_ops__parse_target(const char *operands, u64 *target)
22{
23 *target = strtoull(operands, NULL, 16);
24 return 0;
25}
26
27static struct ins_ops call_ops = {
28 .parse_target = call_ops__parse_target,
29};
30
31bool ins__is_call(const struct ins *ins)
32{
33 return ins->ops == &call_ops;
34}
35
21static int jump_ops__parse_target(const char *operands, u64 *target) 36static int jump_ops__parse_target(const char *operands, u64 *target)
22{ 37{
23 const char *s = strchr(operands, '+'); 38 const char *s = strchr(operands, '+');
@@ -38,11 +53,12 @@ bool ins__is_jump(const struct ins *ins)
38 return ins->ops == &jump_ops; 53 return ins->ops == &jump_ops;
39} 54}
40 55
41
42/* 56/*
43 * Must be sorted by name! 57 * Must be sorted by name!
44 */ 58 */
45static struct ins instructions[] = { 59static struct ins instructions[] = {
60 { .name = "call", .ops = &call_ops, },
61 { .name = "callq", .ops = &call_ops, },
46 { .name = "ja", .ops = &jump_ops, }, 62 { .name = "ja", .ops = &jump_ops, },
47 { .name = "je", .ops = &jump_ops, }, 63 { .name = "je", .ops = &jump_ops, },
48 { .name = "jmp", .ops = &jump_ops, }, 64 { .name = "jmp", .ops = &jump_ops, },
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 934c6fe3a91b..a2105f204a42 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -17,6 +17,7 @@ struct ins {
17}; 17};
18 18
19bool ins__is_jump(const struct ins *ins); 19bool ins__is_jump(const struct ins *ins);
20bool ins__is_call(const struct ins *ins);
20 21
21struct disasm_line { 22struct disasm_line {
22 struct list_head node; 23 struct list_head node;