diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-19 20:36:08 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-19 20:36:08 -0400 |
commit | df48d8716eab9608fe93924e4ae06ff110e8674f (patch) | |
tree | 0fe10733a414b3651e1dae29518b7960a4da0aa4 /tools/perf/util | |
parent | acd30250d7d0f495685d1c7c6184636a22fcdf7f (diff) | |
parent | 29510ec3b626c86de9707bb8904ff940d430289b (diff) |
Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
* 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip: (107 commits)
perf stat: Add more cache-miss percentage printouts
perf stat: Add -d -d and -d -d -d options to show more CPU events
ftrace/kbuild: Add recordmcount files to force full build
ftrace: Add self-tests for multiple function trace users
ftrace: Modify ftrace_set_filter/notrace to take ops
ftrace: Allow dynamically allocated function tracers
ftrace: Implement separate user function filtering
ftrace: Free hash with call_rcu_sched()
ftrace: Have global_ops store the functions that are to be traced
ftrace: Add ops parameter to ftrace_startup/shutdown functions
ftrace: Add enabled_functions file
ftrace: Use counters to enable functions to trace
ftrace: Separate hash allocation and assignment
ftrace: Create a global_ops to hold the filter and notrace hashes
ftrace: Use hash instead for FTRACE_FL_FILTER
ftrace: Replace FTRACE_FL_NOTRACE flag with a hash of ignored functions
perf bench, x86: Add alternatives-asm.h wrapper
x86, 64-bit: Fix copy_[to/from]_user() checks for the userspace address limit
x86, mem: memset_64.S: Optimize memset by enhanced REP MOVSB/STOSB
x86, mem: memmove_64.S: Optimize memmove by enhanced REP MOVSB/STOSB
...
Diffstat (limited to 'tools/perf/util')
-rw-r--r-- | tools/perf/util/include/asm/alternative-asm.h | 8 | ||||
-rw-r--r-- | tools/perf/util/parse-events.c | 123 | ||||
-rw-r--r-- | tools/perf/util/probe-finder.c | 73 | ||||
-rw-r--r-- | tools/perf/util/probe-finder.h | 2 | ||||
-rw-r--r-- | tools/perf/util/python.c | 3 | ||||
-rw-r--r-- | tools/perf/util/session.c | 12 | ||||
-rw-r--r-- | tools/perf/util/session.h | 3 | ||||
-rw-r--r-- | tools/perf/util/symbol.c | 629 | ||||
-rw-r--r-- | tools/perf/util/symbol.h | 78 |
9 files changed, 534 insertions, 397 deletions
diff --git a/tools/perf/util/include/asm/alternative-asm.h b/tools/perf/util/include/asm/alternative-asm.h new file mode 100644 index 000000000000..6789d788d494 --- /dev/null +++ b/tools/perf/util/include/asm/alternative-asm.h | |||
@@ -0,0 +1,8 @@ | |||
1 | #ifndef _PERF_ASM_ALTERNATIVE_ASM_H | ||
2 | #define _PERF_ASM_ALTERNATIVE_ASM_H | ||
3 | |||
4 | /* Just disable it so we can build arch/x86/lib/memcpy_64.S for perf bench: */ | ||
5 | |||
6 | #define altinstruction_entry # | ||
7 | |||
8 | #endif | ||
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 952b4ae3d954..41982c373faf 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c | |||
@@ -31,34 +31,36 @@ char debugfs_path[MAXPATHLEN]; | |||
31 | #define CSW(x) .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_##x | 31 | #define CSW(x) .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_##x |
32 | 32 | ||
33 | static struct event_symbol event_symbols[] = { | 33 | static struct event_symbol event_symbols[] = { |
34 | { CHW(CPU_CYCLES), "cpu-cycles", "cycles" }, | 34 | { CHW(CPU_CYCLES), "cpu-cycles", "cycles" }, |
35 | { CHW(INSTRUCTIONS), "instructions", "" }, | 35 | { CHW(STALLED_CYCLES_FRONTEND), "stalled-cycles-frontend", "idle-cycles-frontend" }, |
36 | { CHW(CACHE_REFERENCES), "cache-references", "" }, | 36 | { CHW(STALLED_CYCLES_BACKEND), "stalled-cycles-backend", "idle-cycles-backend" }, |
37 | { CHW(CACHE_MISSES), "cache-misses", "" }, | 37 | { CHW(INSTRUCTIONS), "instructions", "" }, |
38 | { CHW(BRANCH_INSTRUCTIONS), "branch-instructions", "branches" }, | 38 | { CHW(CACHE_REFERENCES), "cache-references", "" }, |
39 | { CHW(BRANCH_MISSES), "branch-misses", "" }, | 39 | { CHW(CACHE_MISSES), "cache-misses", "" }, |
40 | { CHW(BUS_CYCLES), "bus-cycles", "" }, | 40 | { CHW(BRANCH_INSTRUCTIONS), "branch-instructions", "branches" }, |
41 | 41 | { CHW(BRANCH_MISSES), "branch-misses", "" }, | |
42 | { CSW(CPU_CLOCK), "cpu-clock", "" }, | 42 | { CHW(BUS_CYCLES), "bus-cycles", "" }, |
43 | { CSW(TASK_CLOCK), "task-clock", "" }, | 43 | |
44 | { CSW(PAGE_FAULTS), "page-faults", "faults" }, | 44 | { CSW(CPU_CLOCK), "cpu-clock", "" }, |
45 | { CSW(PAGE_FAULTS_MIN), "minor-faults", "" }, | 45 | { CSW(TASK_CLOCK), "task-clock", "" }, |
46 | { CSW(PAGE_FAULTS_MAJ), "major-faults", "" }, | 46 | { CSW(PAGE_FAULTS), "page-faults", "faults" }, |
47 | { CSW(CONTEXT_SWITCHES), "context-switches", "cs" }, | 47 | { CSW(PAGE_FAULTS_MIN), "minor-faults", "" }, |
48 | { CSW(CPU_MIGRATIONS), "cpu-migrations", "migrations" }, | 48 | { CSW(PAGE_FAULTS_MAJ), "major-faults", "" }, |
49 | { CSW(ALIGNMENT_FAULTS), "alignment-faults", "" }, | 49 | { CSW(CONTEXT_SWITCHES), "context-switches", "cs" }, |
50 | { CSW(EMULATION_FAULTS), "emulation-faults", "" }, | 50 | { CSW(CPU_MIGRATIONS), "cpu-migrations", "migrations" }, |
51 | { CSW(ALIGNMENT_FAULTS), "alignment-faults", "" }, | ||
52 | { CSW(EMULATION_FAULTS), "emulation-faults", "" }, | ||
51 | }; | 53 | }; |
52 | 54 | ||
53 | #define __PERF_EVENT_FIELD(config, name) \ | 55 | #define __PERF_EVENT_FIELD(config, name) \ |
54 | ((config & PERF_EVENT_##name##_MASK) >> PERF_EVENT_##name##_SHIFT) | 56 | ((config & PERF_EVENT_##name##_MASK) >> PERF_EVENT_##name##_SHIFT) |
55 | 57 | ||
56 | #define PERF_EVENT_RAW(config) __PERF_EVENT_FIELD(config, RAW) | 58 | #define PERF_EVENT_RAW(config) __PERF_EVENT_FIELD(config, RAW) |
57 | #define PERF_EVENT_CONFIG(config) __PERF_EVENT_FIELD(config, CONFIG) | 59 | #define PERF_EVENT_CONFIG(config) __PERF_EVENT_FIELD(config, CONFIG) |
58 | #define PERF_EVENT_TYPE(config) __PERF_EVENT_FIELD(config, TYPE) | 60 | #define PERF_EVENT_TYPE(config) __PERF_EVENT_FIELD(config, TYPE) |
59 | #define PERF_EVENT_ID(config) __PERF_EVENT_FIELD(config, EVENT) | 61 | #define PERF_EVENT_ID(config) __PERF_EVENT_FIELD(config, EVENT) |
60 | 62 | ||
61 | static const char *hw_event_names[] = { | 63 | static const char *hw_event_names[PERF_COUNT_HW_MAX] = { |
62 | "cycles", | 64 | "cycles", |
63 | "instructions", | 65 | "instructions", |
64 | "cache-references", | 66 | "cache-references", |
@@ -66,11 +68,13 @@ static const char *hw_event_names[] = { | |||
66 | "branches", | 68 | "branches", |
67 | "branch-misses", | 69 | "branch-misses", |
68 | "bus-cycles", | 70 | "bus-cycles", |
71 | "stalled-cycles-frontend", | ||
72 | "stalled-cycles-backend", | ||
69 | }; | 73 | }; |
70 | 74 | ||
71 | static const char *sw_event_names[] = { | 75 | static const char *sw_event_names[PERF_COUNT_SW_MAX] = { |
72 | "cpu-clock-msecs", | 76 | "cpu-clock", |
73 | "task-clock-msecs", | 77 | "task-clock", |
74 | "page-faults", | 78 | "page-faults", |
75 | "context-switches", | 79 | "context-switches", |
76 | "CPU-migrations", | 80 | "CPU-migrations", |
@@ -307,7 +311,7 @@ const char *__event_name(int type, u64 config) | |||
307 | 311 | ||
308 | switch (type) { | 312 | switch (type) { |
309 | case PERF_TYPE_HARDWARE: | 313 | case PERF_TYPE_HARDWARE: |
310 | if (config < PERF_COUNT_HW_MAX) | 314 | if (config < PERF_COUNT_HW_MAX && hw_event_names[config]) |
311 | return hw_event_names[config]; | 315 | return hw_event_names[config]; |
312 | return "unknown-hardware"; | 316 | return "unknown-hardware"; |
313 | 317 | ||
@@ -333,7 +337,7 @@ const char *__event_name(int type, u64 config) | |||
333 | } | 337 | } |
334 | 338 | ||
335 | case PERF_TYPE_SOFTWARE: | 339 | case PERF_TYPE_SOFTWARE: |
336 | if (config < PERF_COUNT_SW_MAX) | 340 | if (config < PERF_COUNT_SW_MAX && sw_event_names[config]) |
337 | return sw_event_names[config]; | 341 | return sw_event_names[config]; |
338 | return "unknown-software"; | 342 | return "unknown-software"; |
339 | 343 | ||
@@ -648,13 +652,15 @@ static int check_events(const char *str, unsigned int i) | |||
648 | int n; | 652 | int n; |
649 | 653 | ||
650 | n = strlen(event_symbols[i].symbol); | 654 | n = strlen(event_symbols[i].symbol); |
651 | if (!strncmp(str, event_symbols[i].symbol, n)) | 655 | if (!strncasecmp(str, event_symbols[i].symbol, n)) |
652 | return n; | 656 | return n; |
653 | 657 | ||
654 | n = strlen(event_symbols[i].alias); | 658 | n = strlen(event_symbols[i].alias); |
655 | if (n) | 659 | if (n) { |
656 | if (!strncmp(str, event_symbols[i].alias, n)) | 660 | if (!strncasecmp(str, event_symbols[i].alias, n)) |
657 | return n; | 661 | return n; |
662 | } | ||
663 | |||
658 | return 0; | 664 | return 0; |
659 | } | 665 | } |
660 | 666 | ||
@@ -718,15 +724,22 @@ parse_numeric_event(const char **strp, struct perf_event_attr *attr) | |||
718 | return EVT_FAILED; | 724 | return EVT_FAILED; |
719 | } | 725 | } |
720 | 726 | ||
721 | static enum event_result | 727 | static int |
722 | parse_event_modifier(const char **strp, struct perf_event_attr *attr) | 728 | parse_event_modifier(const char **strp, struct perf_event_attr *attr) |
723 | { | 729 | { |
724 | const char *str = *strp; | 730 | const char *str = *strp; |
725 | int exclude = 0; | 731 | int exclude = 0; |
726 | int eu = 0, ek = 0, eh = 0, precise = 0; | 732 | int eu = 0, ek = 0, eh = 0, precise = 0; |
727 | 733 | ||
728 | if (*str++ != ':') | 734 | if (!*str) |
735 | return 0; | ||
736 | |||
737 | if (*str == ',') | ||
729 | return 0; | 738 | return 0; |
739 | |||
740 | if (*str++ != ':') | ||
741 | return -1; | ||
742 | |||
730 | while (*str) { | 743 | while (*str) { |
731 | if (*str == 'u') { | 744 | if (*str == 'u') { |
732 | if (!exclude) | 745 | if (!exclude) |
@@ -747,14 +760,16 @@ parse_event_modifier(const char **strp, struct perf_event_attr *attr) | |||
747 | 760 | ||
748 | ++str; | 761 | ++str; |
749 | } | 762 | } |
750 | if (str >= *strp + 2) { | 763 | if (str < *strp + 2) |
751 | *strp = str; | 764 | return -1; |
752 | attr->exclude_user = eu; | 765 | |
753 | attr->exclude_kernel = ek; | 766 | *strp = str; |
754 | attr->exclude_hv = eh; | 767 | |
755 | attr->precise_ip = precise; | 768 | attr->exclude_user = eu; |
756 | return 1; | 769 | attr->exclude_kernel = ek; |
757 | } | 770 | attr->exclude_hv = eh; |
771 | attr->precise_ip = precise; | ||
772 | |||
758 | return 0; | 773 | return 0; |
759 | } | 774 | } |
760 | 775 | ||
@@ -797,7 +812,12 @@ parse_event_symbols(const struct option *opt, const char **str, | |||
797 | return EVT_FAILED; | 812 | return EVT_FAILED; |
798 | 813 | ||
799 | modifier: | 814 | modifier: |
800 | parse_event_modifier(str, attr); | 815 | if (parse_event_modifier(str, attr) < 0) { |
816 | fprintf(stderr, "invalid event modifier: '%s'\n", *str); | ||
817 | fprintf(stderr, "Run 'perf list' for a list of valid events and modifiers\n"); | ||
818 | |||
819 | return EVT_FAILED; | ||
820 | } | ||
801 | 821 | ||
802 | return ret; | 822 | return ret; |
803 | } | 823 | } |
@@ -912,7 +932,7 @@ void print_tracepoint_events(const char *subsys_glob, const char *event_glob) | |||
912 | 932 | ||
913 | snprintf(evt_path, MAXPATHLEN, "%s:%s", | 933 | snprintf(evt_path, MAXPATHLEN, "%s:%s", |
914 | sys_dirent.d_name, evt_dirent.d_name); | 934 | sys_dirent.d_name, evt_dirent.d_name); |
915 | printf(" %-42s [%s]\n", evt_path, | 935 | printf(" %-50s [%s]\n", evt_path, |
916 | event_type_descriptors[PERF_TYPE_TRACEPOINT]); | 936 | event_type_descriptors[PERF_TYPE_TRACEPOINT]); |
917 | } | 937 | } |
918 | closedir(evt_dir); | 938 | closedir(evt_dir); |
@@ -977,7 +997,7 @@ void print_events_type(u8 type) | |||
977 | else | 997 | else |
978 | snprintf(name, sizeof(name), "%s", syms->symbol); | 998 | snprintf(name, sizeof(name), "%s", syms->symbol); |
979 | 999 | ||
980 | printf(" %-42s [%s]\n", name, | 1000 | printf(" %-50s [%s]\n", name, |
981 | event_type_descriptors[type]); | 1001 | event_type_descriptors[type]); |
982 | } | 1002 | } |
983 | } | 1003 | } |
@@ -995,11 +1015,10 @@ int print_hwcache_events(const char *event_glob) | |||
995 | for (i = 0; i < PERF_COUNT_HW_CACHE_RESULT_MAX; i++) { | 1015 | for (i = 0; i < PERF_COUNT_HW_CACHE_RESULT_MAX; i++) { |
996 | char *name = event_cache_name(type, op, i); | 1016 | char *name = event_cache_name(type, op, i); |
997 | 1017 | ||
998 | if (event_glob != NULL && | 1018 | if (event_glob != NULL && !strglobmatch(name, event_glob)) |
999 | !strglobmatch(name, event_glob)) | ||
1000 | continue; | 1019 | continue; |
1001 | 1020 | ||
1002 | printf(" %-42s [%s]\n", name, | 1021 | printf(" %-50s [%s]\n", name, |
1003 | event_type_descriptors[PERF_TYPE_HW_CACHE]); | 1022 | event_type_descriptors[PERF_TYPE_HW_CACHE]); |
1004 | ++printed; | 1023 | ++printed; |
1005 | } | 1024 | } |
@@ -1009,14 +1028,16 @@ int print_hwcache_events(const char *event_glob) | |||
1009 | return printed; | 1028 | return printed; |
1010 | } | 1029 | } |
1011 | 1030 | ||
1031 | #define MAX_NAME_LEN 100 | ||
1032 | |||
1012 | /* | 1033 | /* |
1013 | * Print the help text for the event symbols: | 1034 | * Print the help text for the event symbols: |
1014 | */ | 1035 | */ |
1015 | void print_events(const char *event_glob) | 1036 | void print_events(const char *event_glob) |
1016 | { | 1037 | { |
1017 | struct event_symbol *syms = event_symbols; | ||
1018 | unsigned int i, type, prev_type = -1, printed = 0, ntypes_printed = 0; | 1038 | unsigned int i, type, prev_type = -1, printed = 0, ntypes_printed = 0; |
1019 | char name[40]; | 1039 | struct event_symbol *syms = event_symbols; |
1040 | char name[MAX_NAME_LEN]; | ||
1020 | 1041 | ||
1021 | printf("\n"); | 1042 | printf("\n"); |
1022 | printf("List of pre-defined events (to be used in -e):\n"); | 1043 | printf("List of pre-defined events (to be used in -e):\n"); |
@@ -1036,10 +1057,10 @@ void print_events(const char *event_glob) | |||
1036 | continue; | 1057 | continue; |
1037 | 1058 | ||
1038 | if (strlen(syms->alias)) | 1059 | if (strlen(syms->alias)) |
1039 | sprintf(name, "%s OR %s", syms->symbol, syms->alias); | 1060 | snprintf(name, MAX_NAME_LEN, "%s OR %s", syms->symbol, syms->alias); |
1040 | else | 1061 | else |
1041 | strcpy(name, syms->symbol); | 1062 | strncpy(name, syms->symbol, MAX_NAME_LEN); |
1042 | printf(" %-42s [%s]\n", name, | 1063 | printf(" %-50s [%s]\n", name, |
1043 | event_type_descriptors[type]); | 1064 | event_type_descriptors[type]); |
1044 | 1065 | ||
1045 | prev_type = type; | 1066 | prev_type = type; |
@@ -1056,12 +1077,12 @@ void print_events(const char *event_glob) | |||
1056 | return; | 1077 | return; |
1057 | 1078 | ||
1058 | printf("\n"); | 1079 | printf("\n"); |
1059 | printf(" %-42s [%s]\n", | 1080 | printf(" %-50s [%s]\n", |
1060 | "rNNN (see 'perf list --help' on how to encode it)", | 1081 | "rNNN (see 'perf list --help' on how to encode it)", |
1061 | event_type_descriptors[PERF_TYPE_RAW]); | 1082 | event_type_descriptors[PERF_TYPE_RAW]); |
1062 | printf("\n"); | 1083 | printf("\n"); |
1063 | 1084 | ||
1064 | printf(" %-42s [%s]\n", | 1085 | printf(" %-50s [%s]\n", |
1065 | "mem:<addr>[:access]", | 1086 | "mem:<addr>[:access]", |
1066 | event_type_descriptors[PERF_TYPE_BREAKPOINT]); | 1087 | event_type_descriptors[PERF_TYPE_BREAKPOINT]); |
1067 | printf("\n"); | 1088 | printf("\n"); |
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c index b7c85ce466a1..3b9d0b800d5c 100644 --- a/tools/perf/util/probe-finder.c +++ b/tools/perf/util/probe-finder.c | |||
@@ -1471,6 +1471,38 @@ static int find_probe_point_by_func(struct probe_finder *pf) | |||
1471 | return _param.retval; | 1471 | return _param.retval; |
1472 | } | 1472 | } |
1473 | 1473 | ||
1474 | struct pubname_callback_param { | ||
1475 | char *function; | ||
1476 | char *file; | ||
1477 | Dwarf_Die *cu_die; | ||
1478 | Dwarf_Die *sp_die; | ||
1479 | int found; | ||
1480 | }; | ||
1481 | |||
1482 | static int pubname_search_cb(Dwarf *dbg, Dwarf_Global *gl, void *data) | ||
1483 | { | ||
1484 | struct pubname_callback_param *param = data; | ||
1485 | |||
1486 | if (dwarf_offdie(dbg, gl->die_offset, param->sp_die)) { | ||
1487 | if (dwarf_tag(param->sp_die) != DW_TAG_subprogram) | ||
1488 | return DWARF_CB_OK; | ||
1489 | |||
1490 | if (die_compare_name(param->sp_die, param->function)) { | ||
1491 | if (!dwarf_offdie(dbg, gl->cu_offset, param->cu_die)) | ||
1492 | return DWARF_CB_OK; | ||
1493 | |||
1494 | if (param->file && | ||
1495 | strtailcmp(param->file, dwarf_decl_file(param->sp_die))) | ||
1496 | return DWARF_CB_OK; | ||
1497 | |||
1498 | param->found = 1; | ||
1499 | return DWARF_CB_ABORT; | ||
1500 | } | ||
1501 | } | ||
1502 | |||
1503 | return DWARF_CB_OK; | ||
1504 | } | ||
1505 | |||
1474 | /* Find probe points from debuginfo */ | 1506 | /* Find probe points from debuginfo */ |
1475 | static int find_probes(int fd, struct probe_finder *pf) | 1507 | static int find_probes(int fd, struct probe_finder *pf) |
1476 | { | 1508 | { |
@@ -1498,6 +1530,28 @@ static int find_probes(int fd, struct probe_finder *pf) | |||
1498 | 1530 | ||
1499 | off = 0; | 1531 | off = 0; |
1500 | line_list__init(&pf->lcache); | 1532 | line_list__init(&pf->lcache); |
1533 | |||
1534 | /* Fastpath: lookup by function name from .debug_pubnames section */ | ||
1535 | if (pp->function) { | ||
1536 | struct pubname_callback_param pubname_param = { | ||
1537 | .function = pp->function, | ||
1538 | .file = pp->file, | ||
1539 | .cu_die = &pf->cu_die, | ||
1540 | .sp_die = &pf->sp_die, | ||
1541 | .found = 0, | ||
1542 | }; | ||
1543 | struct dwarf_callback_param probe_param = { | ||
1544 | .data = pf, | ||
1545 | }; | ||
1546 | |||
1547 | dwarf_getpubnames(dbg, pubname_search_cb, &pubname_param, 0); | ||
1548 | if (pubname_param.found) { | ||
1549 | ret = probe_point_search_cb(&pf->sp_die, &probe_param); | ||
1550 | if (ret) | ||
1551 | goto found; | ||
1552 | } | ||
1553 | } | ||
1554 | |||
1501 | /* Loop on CUs (Compilation Unit) */ | 1555 | /* Loop on CUs (Compilation Unit) */ |
1502 | while (!dwarf_nextcu(dbg, off, &noff, &cuhl, NULL, NULL, NULL)) { | 1556 | while (!dwarf_nextcu(dbg, off, &noff, &cuhl, NULL, NULL, NULL)) { |
1503 | /* Get the DIE(Debugging Information Entry) of this CU */ | 1557 | /* Get the DIE(Debugging Information Entry) of this CU */ |
@@ -1525,6 +1579,8 @@ static int find_probes(int fd, struct probe_finder *pf) | |||
1525 | } | 1579 | } |
1526 | off = noff; | 1580 | off = noff; |
1527 | } | 1581 | } |
1582 | |||
1583 | found: | ||
1528 | line_list__free(&pf->lcache); | 1584 | line_list__free(&pf->lcache); |
1529 | if (dwfl) | 1585 | if (dwfl) |
1530 | dwfl_end(dwfl); | 1586 | dwfl_end(dwfl); |
@@ -1946,6 +2002,22 @@ int find_line_range(int fd, struct line_range *lr) | |||
1946 | return -EBADF; | 2002 | return -EBADF; |
1947 | } | 2003 | } |
1948 | 2004 | ||
2005 | /* Fastpath: lookup by function name from .debug_pubnames section */ | ||
2006 | if (lr->function) { | ||
2007 | struct pubname_callback_param pubname_param = { | ||
2008 | .function = lr->function, .file = lr->file, | ||
2009 | .cu_die = &lf.cu_die, .sp_die = &lf.sp_die, .found = 0}; | ||
2010 | struct dwarf_callback_param line_range_param = { | ||
2011 | .data = (void *)&lf, .retval = 0}; | ||
2012 | |||
2013 | dwarf_getpubnames(dbg, pubname_search_cb, &pubname_param, 0); | ||
2014 | if (pubname_param.found) { | ||
2015 | line_range_search_cb(&lf.sp_die, &line_range_param); | ||
2016 | if (lf.found) | ||
2017 | goto found; | ||
2018 | } | ||
2019 | } | ||
2020 | |||
1949 | /* Loop on CUs (Compilation Unit) */ | 2021 | /* Loop on CUs (Compilation Unit) */ |
1950 | while (!lf.found && ret >= 0) { | 2022 | while (!lf.found && ret >= 0) { |
1951 | if (dwarf_nextcu(dbg, off, &noff, &cuhl, NULL, NULL, NULL) != 0) | 2023 | if (dwarf_nextcu(dbg, off, &noff, &cuhl, NULL, NULL, NULL) != 0) |
@@ -1974,6 +2046,7 @@ int find_line_range(int fd, struct line_range *lr) | |||
1974 | off = noff; | 2046 | off = noff; |
1975 | } | 2047 | } |
1976 | 2048 | ||
2049 | found: | ||
1977 | /* Store comp_dir */ | 2050 | /* Store comp_dir */ |
1978 | if (lf.found) { | 2051 | if (lf.found) { |
1979 | comp_dir = cu_get_comp_dir(&lf.cu_die); | 2052 | comp_dir = cu_get_comp_dir(&lf.cu_die); |
diff --git a/tools/perf/util/probe-finder.h b/tools/perf/util/probe-finder.h index beaefc3c1223..605730a366db 100644 --- a/tools/perf/util/probe-finder.h +++ b/tools/perf/util/probe-finder.h | |||
@@ -49,6 +49,7 @@ struct probe_finder { | |||
49 | Dwarf_Addr addr; /* Address */ | 49 | Dwarf_Addr addr; /* Address */ |
50 | const char *fname; /* Real file name */ | 50 | const char *fname; /* Real file name */ |
51 | Dwarf_Die cu_die; /* Current CU */ | 51 | Dwarf_Die cu_die; /* Current CU */ |
52 | Dwarf_Die sp_die; | ||
52 | struct list_head lcache; /* Line cache for lazy match */ | 53 | struct list_head lcache; /* Line cache for lazy match */ |
53 | 54 | ||
54 | /* For variable searching */ | 55 | /* For variable searching */ |
@@ -83,6 +84,7 @@ struct line_finder { | |||
83 | int lno_s; /* Start line number */ | 84 | int lno_s; /* Start line number */ |
84 | int lno_e; /* End line number */ | 85 | int lno_e; /* End line number */ |
85 | Dwarf_Die cu_die; /* Current CU */ | 86 | Dwarf_Die cu_die; /* Current CU */ |
87 | Dwarf_Die sp_die; | ||
86 | int found; | 88 | int found; |
87 | }; | 89 | }; |
88 | 90 | ||
diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 99c722672f84..b5c7d818001c 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c | |||
@@ -810,6 +810,9 @@ static struct { | |||
810 | { "COUNT_HW_CACHE_RESULT_ACCESS", PERF_COUNT_HW_CACHE_RESULT_ACCESS }, | 810 | { "COUNT_HW_CACHE_RESULT_ACCESS", PERF_COUNT_HW_CACHE_RESULT_ACCESS }, |
811 | { "COUNT_HW_CACHE_RESULT_MISS", PERF_COUNT_HW_CACHE_RESULT_MISS }, | 811 | { "COUNT_HW_CACHE_RESULT_MISS", PERF_COUNT_HW_CACHE_RESULT_MISS }, |
812 | 812 | ||
813 | { "COUNT_HW_STALLED_CYCLES_FRONTEND", PERF_COUNT_HW_STALLED_CYCLES_FRONTEND }, | ||
814 | { "COUNT_HW_STALLED_CYCLES_BACKEND", PERF_COUNT_HW_STALLED_CYCLES_BACKEND }, | ||
815 | |||
813 | { "COUNT_SW_CPU_CLOCK", PERF_COUNT_SW_CPU_CLOCK }, | 816 | { "COUNT_SW_CPU_CLOCK", PERF_COUNT_SW_CPU_CLOCK }, |
814 | { "COUNT_SW_TASK_CLOCK", PERF_COUNT_SW_TASK_CLOCK }, | 817 | { "COUNT_SW_TASK_CLOCK", PERF_COUNT_SW_TASK_CLOCK }, |
815 | { "COUNT_SW_PAGE_FAULTS", PERF_COUNT_SW_PAGE_FAULTS }, | 818 | { "COUNT_SW_PAGE_FAULTS", PERF_COUNT_SW_PAGE_FAULTS }, |
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index caa224522fea..fff66741f18d 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c | |||
@@ -1156,6 +1156,18 @@ size_t perf_session__fprintf_nr_events(struct perf_session *session, FILE *fp) | |||
1156 | return ret; | 1156 | return ret; |
1157 | } | 1157 | } |
1158 | 1158 | ||
1159 | struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session, | ||
1160 | unsigned int type) | ||
1161 | { | ||
1162 | struct perf_evsel *pos; | ||
1163 | |||
1164 | list_for_each_entry(pos, &session->evlist->entries, node) { | ||
1165 | if (pos->attr.type == type) | ||
1166 | return pos; | ||
1167 | } | ||
1168 | return NULL; | ||
1169 | } | ||
1170 | |||
1159 | void perf_session__print_symbols(union perf_event *event, | 1171 | void perf_session__print_symbols(union perf_event *event, |
1160 | struct perf_sample *sample, | 1172 | struct perf_sample *sample, |
1161 | struct perf_session *session) | 1173 | struct perf_session *session) |
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h index 1ac481fc1100..8daaa2d15396 100644 --- a/tools/perf/util/session.h +++ b/tools/perf/util/session.h | |||
@@ -162,6 +162,9 @@ static inline int perf_session__parse_sample(struct perf_session *session, | |||
162 | session->sample_id_all, sample); | 162 | session->sample_id_all, sample); |
163 | } | 163 | } |
164 | 164 | ||
165 | struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session, | ||
166 | unsigned int type); | ||
167 | |||
165 | void perf_session__print_symbols(union perf_event *event, | 168 | void perf_session__print_symbols(union perf_event *event, |
166 | struct perf_sample *sample, | 169 | struct perf_sample *sample, |
167 | struct perf_session *session); | 170 | struct perf_session *session); |
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index f06c10f092ba..516876dfbe52 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c | |||
@@ -31,13 +31,13 @@ | |||
31 | #define NT_GNU_BUILD_ID 3 | 31 | #define NT_GNU_BUILD_ID 3 |
32 | #endif | 32 | #endif |
33 | 33 | ||
34 | static bool dso__build_id_equal(const struct dso *self, u8 *build_id); | 34 | static bool dso__build_id_equal(const struct dso *dso, u8 *build_id); |
35 | static int elf_read_build_id(Elf *elf, void *bf, size_t size); | 35 | static int elf_read_build_id(Elf *elf, void *bf, size_t size); |
36 | static void dsos__add(struct list_head *head, struct dso *dso); | 36 | static void dsos__add(struct list_head *head, struct dso *dso); |
37 | static struct map *map__new2(u64 start, struct dso *dso, enum map_type type); | 37 | static struct map *map__new2(u64 start, struct dso *dso, enum map_type type); |
38 | static int dso__load_kernel_sym(struct dso *self, struct map *map, | 38 | static int dso__load_kernel_sym(struct dso *dso, struct map *map, |
39 | symbol_filter_t filter); | 39 | symbol_filter_t filter); |
40 | static int dso__load_guest_kernel_sym(struct dso *self, struct map *map, | 40 | static int dso__load_guest_kernel_sym(struct dso *dso, struct map *map, |
41 | symbol_filter_t filter); | 41 | symbol_filter_t filter); |
42 | static int vmlinux_path__nr_entries; | 42 | static int vmlinux_path__nr_entries; |
43 | static char **vmlinux_path; | 43 | static char **vmlinux_path; |
@@ -49,27 +49,27 @@ struct symbol_conf symbol_conf = { | |||
49 | .symfs = "", | 49 | .symfs = "", |
50 | }; | 50 | }; |
51 | 51 | ||
52 | int dso__name_len(const struct dso *self) | 52 | int dso__name_len(const struct dso *dso) |
53 | { | 53 | { |
54 | if (verbose) | 54 | if (verbose) |
55 | return self->long_name_len; | 55 | return dso->long_name_len; |
56 | 56 | ||
57 | return self->short_name_len; | 57 | return dso->short_name_len; |
58 | } | 58 | } |
59 | 59 | ||
60 | bool dso__loaded(const struct dso *self, enum map_type type) | 60 | bool dso__loaded(const struct dso *dso, enum map_type type) |
61 | { | 61 | { |
62 | return self->loaded & (1 << type); | 62 | return dso->loaded & (1 << type); |
63 | } | 63 | } |
64 | 64 | ||
65 | bool dso__sorted_by_name(const struct dso *self, enum map_type type) | 65 | bool dso__sorted_by_name(const struct dso *dso, enum map_type type) |
66 | { | 66 | { |
67 | return self->sorted_by_name & (1 << type); | 67 | return dso->sorted_by_name & (1 << type); |
68 | } | 68 | } |
69 | 69 | ||
70 | static void dso__set_sorted_by_name(struct dso *self, enum map_type type) | 70 | static void dso__set_sorted_by_name(struct dso *dso, enum map_type type) |
71 | { | 71 | { |
72 | self->sorted_by_name |= (1 << type); | 72 | dso->sorted_by_name |= (1 << type); |
73 | } | 73 | } |
74 | 74 | ||
75 | bool symbol_type__is_a(char symbol_type, enum map_type map_type) | 75 | bool symbol_type__is_a(char symbol_type, enum map_type map_type) |
@@ -84,9 +84,9 @@ bool symbol_type__is_a(char symbol_type, enum map_type map_type) | |||
84 | } | 84 | } |
85 | } | 85 | } |
86 | 86 | ||
87 | static void symbols__fixup_end(struct rb_root *self) | 87 | static void symbols__fixup_end(struct rb_root *symbols) |
88 | { | 88 | { |
89 | struct rb_node *nd, *prevnd = rb_first(self); | 89 | struct rb_node *nd, *prevnd = rb_first(symbols); |
90 | struct symbol *curr, *prev; | 90 | struct symbol *curr, *prev; |
91 | 91 | ||
92 | if (prevnd == NULL) | 92 | if (prevnd == NULL) |
@@ -107,10 +107,10 @@ static void symbols__fixup_end(struct rb_root *self) | |||
107 | curr->end = roundup(curr->start, 4096); | 107 | curr->end = roundup(curr->start, 4096); |
108 | } | 108 | } |
109 | 109 | ||
110 | static void __map_groups__fixup_end(struct map_groups *self, enum map_type type) | 110 | static void __map_groups__fixup_end(struct map_groups *mg, enum map_type type) |
111 | { | 111 | { |
112 | struct map *prev, *curr; | 112 | struct map *prev, *curr; |
113 | struct rb_node *nd, *prevnd = rb_first(&self->maps[type]); | 113 | struct rb_node *nd, *prevnd = rb_first(&mg->maps[type]); |
114 | 114 | ||
115 | if (prevnd == NULL) | 115 | if (prevnd == NULL) |
116 | return; | 116 | return; |
@@ -130,128 +130,128 @@ static void __map_groups__fixup_end(struct map_groups *self, enum map_type type) | |||
130 | curr->end = ~0ULL; | 130 | curr->end = ~0ULL; |
131 | } | 131 | } |
132 | 132 | ||
133 | static void map_groups__fixup_end(struct map_groups *self) | 133 | static void map_groups__fixup_end(struct map_groups *mg) |
134 | { | 134 | { |
135 | int i; | 135 | int i; |
136 | for (i = 0; i < MAP__NR_TYPES; ++i) | 136 | for (i = 0; i < MAP__NR_TYPES; ++i) |
137 | __map_groups__fixup_end(self, i); | 137 | __map_groups__fixup_end(mg, i); |
138 | } | 138 | } |
139 | 139 | ||
140 | static struct symbol *symbol__new(u64 start, u64 len, u8 binding, | 140 | static struct symbol *symbol__new(u64 start, u64 len, u8 binding, |
141 | const char *name) | 141 | const char *name) |
142 | { | 142 | { |
143 | size_t namelen = strlen(name) + 1; | 143 | size_t namelen = strlen(name) + 1; |
144 | struct symbol *self = calloc(1, (symbol_conf.priv_size + | 144 | struct symbol *sym = calloc(1, (symbol_conf.priv_size + |
145 | sizeof(*self) + namelen)); | 145 | sizeof(*sym) + namelen)); |
146 | if (self == NULL) | 146 | if (sym == NULL) |
147 | return NULL; | 147 | return NULL; |
148 | 148 | ||
149 | if (symbol_conf.priv_size) | 149 | if (symbol_conf.priv_size) |
150 | self = ((void *)self) + symbol_conf.priv_size; | 150 | sym = ((void *)sym) + symbol_conf.priv_size; |
151 | |||
152 | self->start = start; | ||
153 | self->end = len ? start + len - 1 : start; | ||
154 | self->binding = binding; | ||
155 | self->namelen = namelen - 1; | ||
156 | 151 | ||
157 | pr_debug4("%s: %s %#" PRIx64 "-%#" PRIx64 "\n", __func__, name, start, self->end); | 152 | sym->start = start; |
153 | sym->end = len ? start + len - 1 : start; | ||
154 | sym->binding = binding; | ||
155 | sym->namelen = namelen - 1; | ||
158 | 156 | ||
159 | memcpy(self->name, name, namelen); | 157 | pr_debug4("%s: %s %#" PRIx64 "-%#" PRIx64 "\n", |
158 | __func__, name, start, sym->end); | ||
159 | memcpy(sym->name, name, namelen); | ||
160 | 160 | ||
161 | return self; | 161 | return sym; |
162 | } | 162 | } |
163 | 163 | ||
164 | void symbol__delete(struct symbol *self) | 164 | void symbol__delete(struct symbol *sym) |
165 | { | 165 | { |
166 | free(((void *)self) - symbol_conf.priv_size); | 166 | free(((void *)sym) - symbol_conf.priv_size); |
167 | } | 167 | } |
168 | 168 | ||
169 | static size_t symbol__fprintf(struct symbol *self, FILE *fp) | 169 | static size_t symbol__fprintf(struct symbol *sym, FILE *fp) |
170 | { | 170 | { |
171 | return fprintf(fp, " %" PRIx64 "-%" PRIx64 " %c %s\n", | 171 | return fprintf(fp, " %" PRIx64 "-%" PRIx64 " %c %s\n", |
172 | self->start, self->end, | 172 | sym->start, sym->end, |
173 | self->binding == STB_GLOBAL ? 'g' : | 173 | sym->binding == STB_GLOBAL ? 'g' : |
174 | self->binding == STB_LOCAL ? 'l' : 'w', | 174 | sym->binding == STB_LOCAL ? 'l' : 'w', |
175 | self->name); | 175 | sym->name); |
176 | } | 176 | } |
177 | 177 | ||
178 | void dso__set_long_name(struct dso *self, char *name) | 178 | void dso__set_long_name(struct dso *dso, char *name) |
179 | { | 179 | { |
180 | if (name == NULL) | 180 | if (name == NULL) |
181 | return; | 181 | return; |
182 | self->long_name = name; | 182 | dso->long_name = name; |
183 | self->long_name_len = strlen(name); | 183 | dso->long_name_len = strlen(name); |
184 | } | 184 | } |
185 | 185 | ||
186 | static void dso__set_short_name(struct dso *self, const char *name) | 186 | static void dso__set_short_name(struct dso *dso, const char *name) |
187 | { | 187 | { |
188 | if (name == NULL) | 188 | if (name == NULL) |
189 | return; | 189 | return; |
190 | self->short_name = name; | 190 | dso->short_name = name; |
191 | self->short_name_len = strlen(name); | 191 | dso->short_name_len = strlen(name); |
192 | } | 192 | } |
193 | 193 | ||
194 | static void dso__set_basename(struct dso *self) | 194 | static void dso__set_basename(struct dso *dso) |
195 | { | 195 | { |
196 | dso__set_short_name(self, basename(self->long_name)); | 196 | dso__set_short_name(dso, basename(dso->long_name)); |
197 | } | 197 | } |
198 | 198 | ||
199 | struct dso *dso__new(const char *name) | 199 | struct dso *dso__new(const char *name) |
200 | { | 200 | { |
201 | struct dso *self = calloc(1, sizeof(*self) + strlen(name) + 1); | 201 | struct dso *dso = calloc(1, sizeof(*dso) + strlen(name) + 1); |
202 | 202 | ||
203 | if (self != NULL) { | 203 | if (dso != NULL) { |
204 | int i; | 204 | int i; |
205 | strcpy(self->name, name); | 205 | strcpy(dso->name, name); |
206 | dso__set_long_name(self, self->name); | 206 | dso__set_long_name(dso, dso->name); |
207 | dso__set_short_name(self, self->name); | 207 | dso__set_short_name(dso, dso->name); |
208 | for (i = 0; i < MAP__NR_TYPES; ++i) | 208 | for (i = 0; i < MAP__NR_TYPES; ++i) |
209 | self->symbols[i] = self->symbol_names[i] = RB_ROOT; | 209 | dso->symbols[i] = dso->symbol_names[i] = RB_ROOT; |
210 | self->symtab_type = SYMTAB__NOT_FOUND; | 210 | dso->symtab_type = SYMTAB__NOT_FOUND; |
211 | self->loaded = 0; | 211 | dso->loaded = 0; |
212 | self->sorted_by_name = 0; | 212 | dso->sorted_by_name = 0; |
213 | self->has_build_id = 0; | 213 | dso->has_build_id = 0; |
214 | self->kernel = DSO_TYPE_USER; | 214 | dso->kernel = DSO_TYPE_USER; |
215 | INIT_LIST_HEAD(&self->node); | 215 | INIT_LIST_HEAD(&dso->node); |
216 | } | 216 | } |
217 | 217 | ||
218 | return self; | 218 | return dso; |
219 | } | 219 | } |
220 | 220 | ||
221 | static void symbols__delete(struct rb_root *self) | 221 | static void symbols__delete(struct rb_root *symbols) |
222 | { | 222 | { |
223 | struct symbol *pos; | 223 | struct symbol *pos; |
224 | struct rb_node *next = rb_first(self); | 224 | struct rb_node *next = rb_first(symbols); |
225 | 225 | ||
226 | while (next) { | 226 | while (next) { |
227 | pos = rb_entry(next, struct symbol, rb_node); | 227 | pos = rb_entry(next, struct symbol, rb_node); |
228 | next = rb_next(&pos->rb_node); | 228 | next = rb_next(&pos->rb_node); |
229 | rb_erase(&pos->rb_node, self); | 229 | rb_erase(&pos->rb_node, symbols); |
230 | symbol__delete(pos); | 230 | symbol__delete(pos); |
231 | } | 231 | } |
232 | } | 232 | } |
233 | 233 | ||
234 | void dso__delete(struct dso *self) | 234 | void dso__delete(struct dso *dso) |
235 | { | 235 | { |
236 | int i; | 236 | int i; |
237 | for (i = 0; i < MAP__NR_TYPES; ++i) | 237 | for (i = 0; i < MAP__NR_TYPES; ++i) |
238 | symbols__delete(&self->symbols[i]); | 238 | symbols__delete(&dso->symbols[i]); |
239 | if (self->sname_alloc) | 239 | if (dso->sname_alloc) |
240 | free((char *)self->short_name); | 240 | free((char *)dso->short_name); |
241 | if (self->lname_alloc) | 241 | if (dso->lname_alloc) |
242 | free(self->long_name); | 242 | free(dso->long_name); |
243 | free(self); | 243 | free(dso); |
244 | } | 244 | } |
245 | 245 | ||
246 | void dso__set_build_id(struct dso *self, void *build_id) | 246 | void dso__set_build_id(struct dso *dso, void *build_id) |
247 | { | 247 | { |
248 | memcpy(self->build_id, build_id, sizeof(self->build_id)); | 248 | memcpy(dso->build_id, build_id, sizeof(dso->build_id)); |
249 | self->has_build_id = 1; | 249 | dso->has_build_id = 1; |
250 | } | 250 | } |
251 | 251 | ||
252 | static void symbols__insert(struct rb_root *self, struct symbol *sym) | 252 | static void symbols__insert(struct rb_root *symbols, struct symbol *sym) |
253 | { | 253 | { |
254 | struct rb_node **p = &self->rb_node; | 254 | struct rb_node **p = &symbols->rb_node; |
255 | struct rb_node *parent = NULL; | 255 | struct rb_node *parent = NULL; |
256 | const u64 ip = sym->start; | 256 | const u64 ip = sym->start; |
257 | struct symbol *s; | 257 | struct symbol *s; |
@@ -265,17 +265,17 @@ static void symbols__insert(struct rb_root *self, struct symbol *sym) | |||
265 | p = &(*p)->rb_right; | 265 | p = &(*p)->rb_right; |
266 | } | 266 | } |
267 | rb_link_node(&sym->rb_node, parent, p); | 267 | rb_link_node(&sym->rb_node, parent, p); |
268 | rb_insert_color(&sym->rb_node, self); | 268 | rb_insert_color(&sym->rb_node, symbols); |
269 | } | 269 | } |
270 | 270 | ||
271 | static struct symbol *symbols__find(struct rb_root *self, u64 ip) | 271 | static struct symbol *symbols__find(struct rb_root *symbols, u64 ip) |
272 | { | 272 | { |
273 | struct rb_node *n; | 273 | struct rb_node *n; |
274 | 274 | ||
275 | if (self == NULL) | 275 | if (symbols == NULL) |
276 | return NULL; | 276 | return NULL; |
277 | 277 | ||
278 | n = self->rb_node; | 278 | n = symbols->rb_node; |
279 | 279 | ||
280 | while (n) { | 280 | while (n) { |
281 | struct symbol *s = rb_entry(n, struct symbol, rb_node); | 281 | struct symbol *s = rb_entry(n, struct symbol, rb_node); |
@@ -296,9 +296,9 @@ struct symbol_name_rb_node { | |||
296 | struct symbol sym; | 296 | struct symbol sym; |
297 | }; | 297 | }; |
298 | 298 | ||
299 | static void symbols__insert_by_name(struct rb_root *self, struct symbol *sym) | 299 | static void symbols__insert_by_name(struct rb_root *symbols, struct symbol *sym) |
300 | { | 300 | { |
301 | struct rb_node **p = &self->rb_node; | 301 | struct rb_node **p = &symbols->rb_node; |
302 | struct rb_node *parent = NULL; | 302 | struct rb_node *parent = NULL; |
303 | struct symbol_name_rb_node *symn, *s; | 303 | struct symbol_name_rb_node *symn, *s; |
304 | 304 | ||
@@ -313,27 +313,29 @@ static void symbols__insert_by_name(struct rb_root *self, struct symbol *sym) | |||
313 | p = &(*p)->rb_right; | 313 | p = &(*p)->rb_right; |
314 | } | 314 | } |
315 | rb_link_node(&symn->rb_node, parent, p); | 315 | rb_link_node(&symn->rb_node, parent, p); |
316 | rb_insert_color(&symn->rb_node, self); | 316 | rb_insert_color(&symn->rb_node, symbols); |
317 | } | 317 | } |
318 | 318 | ||
319 | static void symbols__sort_by_name(struct rb_root *self, struct rb_root *source) | 319 | static void symbols__sort_by_name(struct rb_root *symbols, |
320 | struct rb_root *source) | ||
320 | { | 321 | { |
321 | struct rb_node *nd; | 322 | struct rb_node *nd; |
322 | 323 | ||
323 | for (nd = rb_first(source); nd; nd = rb_next(nd)) { | 324 | for (nd = rb_first(source); nd; nd = rb_next(nd)) { |
324 | struct symbol *pos = rb_entry(nd, struct symbol, rb_node); | 325 | struct symbol *pos = rb_entry(nd, struct symbol, rb_node); |
325 | symbols__insert_by_name(self, pos); | 326 | symbols__insert_by_name(symbols, pos); |
326 | } | 327 | } |
327 | } | 328 | } |
328 | 329 | ||
329 | static struct symbol *symbols__find_by_name(struct rb_root *self, const char *name) | 330 | static struct symbol *symbols__find_by_name(struct rb_root *symbols, |
331 | const char *name) | ||
330 | { | 332 | { |
331 | struct rb_node *n; | 333 | struct rb_node *n; |
332 | 334 | ||
333 | if (self == NULL) | 335 | if (symbols == NULL) |
334 | return NULL; | 336 | return NULL; |
335 | 337 | ||
336 | n = self->rb_node; | 338 | n = symbols->rb_node; |
337 | 339 | ||
338 | while (n) { | 340 | while (n) { |
339 | struct symbol_name_rb_node *s; | 341 | struct symbol_name_rb_node *s; |
@@ -353,29 +355,29 @@ static struct symbol *symbols__find_by_name(struct rb_root *self, const char *na | |||
353 | return NULL; | 355 | return NULL; |
354 | } | 356 | } |
355 | 357 | ||
356 | struct symbol *dso__find_symbol(struct dso *self, | 358 | struct symbol *dso__find_symbol(struct dso *dso, |
357 | enum map_type type, u64 addr) | 359 | enum map_type type, u64 addr) |
358 | { | 360 | { |
359 | return symbols__find(&self->symbols[type], addr); | 361 | return symbols__find(&dso->symbols[type], addr); |
360 | } | 362 | } |
361 | 363 | ||
362 | struct symbol *dso__find_symbol_by_name(struct dso *self, enum map_type type, | 364 | struct symbol *dso__find_symbol_by_name(struct dso *dso, enum map_type type, |
363 | const char *name) | 365 | const char *name) |
364 | { | 366 | { |
365 | return symbols__find_by_name(&self->symbol_names[type], name); | 367 | return symbols__find_by_name(&dso->symbol_names[type], name); |
366 | } | 368 | } |
367 | 369 | ||
368 | void dso__sort_by_name(struct dso *self, enum map_type type) | 370 | void dso__sort_by_name(struct dso *dso, enum map_type type) |
369 | { | 371 | { |
370 | dso__set_sorted_by_name(self, type); | 372 | dso__set_sorted_by_name(dso, type); |
371 | return symbols__sort_by_name(&self->symbol_names[type], | 373 | return symbols__sort_by_name(&dso->symbol_names[type], |
372 | &self->symbols[type]); | 374 | &dso->symbols[type]); |
373 | } | 375 | } |
374 | 376 | ||
375 | int build_id__sprintf(const u8 *self, int len, char *bf) | 377 | int build_id__sprintf(const u8 *build_id, int len, char *bf) |
376 | { | 378 | { |
377 | char *bid = bf; | 379 | char *bid = bf; |
378 | const u8 *raw = self; | 380 | const u8 *raw = build_id; |
379 | int i; | 381 | int i; |
380 | 382 | ||
381 | for (i = 0; i < len; ++i) { | 383 | for (i = 0; i < len; ++i) { |
@@ -384,24 +386,25 @@ int build_id__sprintf(const u8 *self, int len, char *bf) | |||
384 | bid += 2; | 386 | bid += 2; |
385 | } | 387 | } |
386 | 388 | ||
387 | return raw - self; | 389 | return raw - build_id; |
388 | } | 390 | } |
389 | 391 | ||
390 | size_t dso__fprintf_buildid(struct dso *self, FILE *fp) | 392 | size_t dso__fprintf_buildid(struct dso *dso, FILE *fp) |
391 | { | 393 | { |
392 | char sbuild_id[BUILD_ID_SIZE * 2 + 1]; | 394 | char sbuild_id[BUILD_ID_SIZE * 2 + 1]; |
393 | 395 | ||
394 | build_id__sprintf(self->build_id, sizeof(self->build_id), sbuild_id); | 396 | build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id); |
395 | return fprintf(fp, "%s", sbuild_id); | 397 | return fprintf(fp, "%s", sbuild_id); |
396 | } | 398 | } |
397 | 399 | ||
398 | size_t dso__fprintf_symbols_by_name(struct dso *self, enum map_type type, FILE *fp) | 400 | size_t dso__fprintf_symbols_by_name(struct dso *dso, |
401 | enum map_type type, FILE *fp) | ||
399 | { | 402 | { |
400 | size_t ret = 0; | 403 | size_t ret = 0; |
401 | struct rb_node *nd; | 404 | struct rb_node *nd; |
402 | struct symbol_name_rb_node *pos; | 405 | struct symbol_name_rb_node *pos; |
403 | 406 | ||
404 | for (nd = rb_first(&self->symbol_names[type]); nd; nd = rb_next(nd)) { | 407 | for (nd = rb_first(&dso->symbol_names[type]); nd; nd = rb_next(nd)) { |
405 | pos = rb_entry(nd, struct symbol_name_rb_node, rb_node); | 408 | pos = rb_entry(nd, struct symbol_name_rb_node, rb_node); |
406 | fprintf(fp, "%s\n", pos->sym.name); | 409 | fprintf(fp, "%s\n", pos->sym.name); |
407 | } | 410 | } |
@@ -409,18 +412,18 @@ size_t dso__fprintf_symbols_by_name(struct dso *self, enum map_type type, FILE * | |||
409 | return ret; | 412 | return ret; |
410 | } | 413 | } |
411 | 414 | ||
412 | size_t dso__fprintf(struct dso *self, enum map_type type, FILE *fp) | 415 | size_t dso__fprintf(struct dso *dso, enum map_type type, FILE *fp) |
413 | { | 416 | { |
414 | struct rb_node *nd; | 417 | struct rb_node *nd; |
415 | size_t ret = fprintf(fp, "dso: %s (", self->short_name); | 418 | size_t ret = fprintf(fp, "dso: %s (", dso->short_name); |
416 | 419 | ||
417 | if (self->short_name != self->long_name) | 420 | if (dso->short_name != dso->long_name) |
418 | ret += fprintf(fp, "%s, ", self->long_name); | 421 | ret += fprintf(fp, "%s, ", dso->long_name); |
419 | ret += fprintf(fp, "%s, %sloaded, ", map_type__name[type], | 422 | ret += fprintf(fp, "%s, %sloaded, ", map_type__name[type], |
420 | self->loaded ? "" : "NOT "); | 423 | dso->loaded ? "" : "NOT "); |
421 | ret += dso__fprintf_buildid(self, fp); | 424 | ret += dso__fprintf_buildid(dso, fp); |
422 | ret += fprintf(fp, ")\n"); | 425 | ret += fprintf(fp, ")\n"); |
423 | for (nd = rb_first(&self->symbols[type]); nd; nd = rb_next(nd)) { | 426 | for (nd = rb_first(&dso->symbols[type]); nd; nd = rb_next(nd)) { |
424 | struct symbol *pos = rb_entry(nd, struct symbol, rb_node); | 427 | struct symbol *pos = rb_entry(nd, struct symbol, rb_node); |
425 | ret += symbol__fprintf(pos, fp); | 428 | ret += symbol__fprintf(pos, fp); |
426 | } | 429 | } |
@@ -543,10 +546,10 @@ static int map__process_kallsym_symbol(void *arg, const char *name, | |||
543 | * so that we can in the next step set the symbol ->end address and then | 546 | * so that we can in the next step set the symbol ->end address and then |
544 | * call kernel_maps__split_kallsyms. | 547 | * call kernel_maps__split_kallsyms. |
545 | */ | 548 | */ |
546 | static int dso__load_all_kallsyms(struct dso *self, const char *filename, | 549 | static int dso__load_all_kallsyms(struct dso *dso, const char *filename, |
547 | struct map *map) | 550 | struct map *map) |
548 | { | 551 | { |
549 | struct process_kallsyms_args args = { .map = map, .dso = self, }; | 552 | struct process_kallsyms_args args = { .map = map, .dso = dso, }; |
550 | return kallsyms__parse(filename, &args, map__process_kallsym_symbol); | 553 | return kallsyms__parse(filename, &args, map__process_kallsym_symbol); |
551 | } | 554 | } |
552 | 555 | ||
@@ -555,7 +558,7 @@ static int dso__load_all_kallsyms(struct dso *self, const char *filename, | |||
555 | * kernel range is broken in several maps, named [kernel].N, as we don't have | 558 | * kernel range is broken in several maps, named [kernel].N, as we don't have |
556 | * the original ELF section names vmlinux have. | 559 | * the original ELF section names vmlinux have. |
557 | */ | 560 | */ |
558 | static int dso__split_kallsyms(struct dso *self, struct map *map, | 561 | static int dso__split_kallsyms(struct dso *dso, struct map *map, |
559 | symbol_filter_t filter) | 562 | symbol_filter_t filter) |
560 | { | 563 | { |
561 | struct map_groups *kmaps = map__kmap(map)->kmaps; | 564 | struct map_groups *kmaps = map__kmap(map)->kmaps; |
@@ -563,7 +566,7 @@ static int dso__split_kallsyms(struct dso *self, struct map *map, | |||
563 | struct map *curr_map = map; | 566 | struct map *curr_map = map; |
564 | struct symbol *pos; | 567 | struct symbol *pos; |
565 | int count = 0, moved = 0; | 568 | int count = 0, moved = 0; |
566 | struct rb_root *root = &self->symbols[map->type]; | 569 | struct rb_root *root = &dso->symbols[map->type]; |
567 | struct rb_node *next = rb_first(root); | 570 | struct rb_node *next = rb_first(root); |
568 | int kernel_range = 0; | 571 | int kernel_range = 0; |
569 | 572 | ||
@@ -582,7 +585,7 @@ static int dso__split_kallsyms(struct dso *self, struct map *map, | |||
582 | 585 | ||
583 | if (strcmp(curr_map->dso->short_name, module)) { | 586 | if (strcmp(curr_map->dso->short_name, module)) { |
584 | if (curr_map != map && | 587 | if (curr_map != map && |
585 | self->kernel == DSO_TYPE_GUEST_KERNEL && | 588 | dso->kernel == DSO_TYPE_GUEST_KERNEL && |
586 | machine__is_default_guest(machine)) { | 589 | machine__is_default_guest(machine)) { |
587 | /* | 590 | /* |
588 | * We assume all symbols of a module are | 591 | * We assume all symbols of a module are |
@@ -618,14 +621,14 @@ static int dso__split_kallsyms(struct dso *self, struct map *map, | |||
618 | pos->end = curr_map->map_ip(curr_map, pos->end); | 621 | pos->end = curr_map->map_ip(curr_map, pos->end); |
619 | } else if (curr_map != map) { | 622 | } else if (curr_map != map) { |
620 | char dso_name[PATH_MAX]; | 623 | char dso_name[PATH_MAX]; |
621 | struct dso *dso; | 624 | struct dso *ndso; |
622 | 625 | ||
623 | if (count == 0) { | 626 | if (count == 0) { |
624 | curr_map = map; | 627 | curr_map = map; |
625 | goto filter_symbol; | 628 | goto filter_symbol; |
626 | } | 629 | } |
627 | 630 | ||
628 | if (self->kernel == DSO_TYPE_GUEST_KERNEL) | 631 | if (dso->kernel == DSO_TYPE_GUEST_KERNEL) |
629 | snprintf(dso_name, sizeof(dso_name), | 632 | snprintf(dso_name, sizeof(dso_name), |
630 | "[guest.kernel].%d", | 633 | "[guest.kernel].%d", |
631 | kernel_range++); | 634 | kernel_range++); |
@@ -634,15 +637,15 @@ static int dso__split_kallsyms(struct dso *self, struct map *map, | |||
634 | "[kernel].%d", | 637 | "[kernel].%d", |
635 | kernel_range++); | 638 | kernel_range++); |
636 | 639 | ||
637 | dso = dso__new(dso_name); | 640 | ndso = dso__new(dso_name); |
638 | if (dso == NULL) | 641 | if (ndso == NULL) |
639 | return -1; | 642 | return -1; |
640 | 643 | ||
641 | dso->kernel = self->kernel; | 644 | ndso->kernel = dso->kernel; |
642 | 645 | ||
643 | curr_map = map__new2(pos->start, dso, map->type); | 646 | curr_map = map__new2(pos->start, ndso, map->type); |
644 | if (curr_map == NULL) { | 647 | if (curr_map == NULL) { |
645 | dso__delete(dso); | 648 | dso__delete(ndso); |
646 | return -1; | 649 | return -1; |
647 | } | 650 | } |
648 | 651 | ||
@@ -665,7 +668,7 @@ discard_symbol: rb_erase(&pos->rb_node, root); | |||
665 | } | 668 | } |
666 | 669 | ||
667 | if (curr_map != map && | 670 | if (curr_map != map && |
668 | self->kernel == DSO_TYPE_GUEST_KERNEL && | 671 | dso->kernel == DSO_TYPE_GUEST_KERNEL && |
669 | machine__is_default_guest(kmaps->machine)) { | 672 | machine__is_default_guest(kmaps->machine)) { |
670 | dso__set_loaded(curr_map->dso, curr_map->type); | 673 | dso__set_loaded(curr_map->dso, curr_map->type); |
671 | } | 674 | } |
@@ -673,21 +676,21 @@ discard_symbol: rb_erase(&pos->rb_node, root); | |||
673 | return count + moved; | 676 | return count + moved; |
674 | } | 677 | } |
675 | 678 | ||
676 | int dso__load_kallsyms(struct dso *self, const char *filename, | 679 | int dso__load_kallsyms(struct dso *dso, const char *filename, |
677 | struct map *map, symbol_filter_t filter) | 680 | struct map *map, symbol_filter_t filter) |
678 | { | 681 | { |
679 | if (dso__load_all_kallsyms(self, filename, map) < 0) | 682 | if (dso__load_all_kallsyms(dso, filename, map) < 0) |
680 | return -1; | 683 | return -1; |
681 | 684 | ||
682 | if (self->kernel == DSO_TYPE_GUEST_KERNEL) | 685 | if (dso->kernel == DSO_TYPE_GUEST_KERNEL) |
683 | self->symtab_type = SYMTAB__GUEST_KALLSYMS; | 686 | dso->symtab_type = SYMTAB__GUEST_KALLSYMS; |
684 | else | 687 | else |
685 | self->symtab_type = SYMTAB__KALLSYMS; | 688 | dso->symtab_type = SYMTAB__KALLSYMS; |
686 | 689 | ||
687 | return dso__split_kallsyms(self, map, filter); | 690 | return dso__split_kallsyms(dso, map, filter); |
688 | } | 691 | } |
689 | 692 | ||
690 | static int dso__load_perf_map(struct dso *self, struct map *map, | 693 | static int dso__load_perf_map(struct dso *dso, struct map *map, |
691 | symbol_filter_t filter) | 694 | symbol_filter_t filter) |
692 | { | 695 | { |
693 | char *line = NULL; | 696 | char *line = NULL; |
@@ -695,7 +698,7 @@ static int dso__load_perf_map(struct dso *self, struct map *map, | |||
695 | FILE *file; | 698 | FILE *file; |
696 | int nr_syms = 0; | 699 | int nr_syms = 0; |
697 | 700 | ||
698 | file = fopen(self->long_name, "r"); | 701 | file = fopen(dso->long_name, "r"); |
699 | if (file == NULL) | 702 | if (file == NULL) |
700 | goto out_failure; | 703 | goto out_failure; |
701 | 704 | ||
@@ -733,7 +736,7 @@ static int dso__load_perf_map(struct dso *self, struct map *map, | |||
733 | if (filter && filter(map, sym)) | 736 | if (filter && filter(map, sym)) |
734 | symbol__delete(sym); | 737 | symbol__delete(sym); |
735 | else { | 738 | else { |
736 | symbols__insert(&self->symbols[map->type], sym); | 739 | symbols__insert(&dso->symbols[map->type], sym); |
737 | nr_syms++; | 740 | nr_syms++; |
738 | } | 741 | } |
739 | } | 742 | } |
@@ -752,7 +755,7 @@ out_failure: | |||
752 | /** | 755 | /** |
753 | * elf_symtab__for_each_symbol - iterate thru all the symbols | 756 | * elf_symtab__for_each_symbol - iterate thru all the symbols |
754 | * | 757 | * |
755 | * @self: struct elf_symtab instance to iterate | 758 | * @syms: struct elf_symtab instance to iterate |
756 | * @idx: uint32_t idx | 759 | * @idx: uint32_t idx |
757 | * @sym: GElf_Sym iterator | 760 | * @sym: GElf_Sym iterator |
758 | */ | 761 | */ |
@@ -852,7 +855,7 @@ static Elf_Scn *elf_section_by_name(Elf *elf, GElf_Ehdr *ep, | |||
852 | * And always look at the original dso, not at debuginfo packages, that | 855 | * And always look at the original dso, not at debuginfo packages, that |
853 | * have the PLT data stripped out (shdr_rel_plt.sh_type == SHT_NOBITS). | 856 | * have the PLT data stripped out (shdr_rel_plt.sh_type == SHT_NOBITS). |
854 | */ | 857 | */ |
855 | static int dso__synthesize_plt_symbols(struct dso *self, struct map *map, | 858 | static int dso__synthesize_plt_symbols(struct dso *dso, struct map *map, |
856 | symbol_filter_t filter) | 859 | symbol_filter_t filter) |
857 | { | 860 | { |
858 | uint32_t nr_rel_entries, idx; | 861 | uint32_t nr_rel_entries, idx; |
@@ -871,7 +874,7 @@ static int dso__synthesize_plt_symbols(struct dso *self, struct map *map, | |||
871 | char name[PATH_MAX]; | 874 | char name[PATH_MAX]; |
872 | 875 | ||
873 | snprintf(name, sizeof(name), "%s%s", | 876 | snprintf(name, sizeof(name), "%s%s", |
874 | symbol_conf.symfs, self->long_name); | 877 | symbol_conf.symfs, dso->long_name); |
875 | fd = open(name, O_RDONLY); | 878 | fd = open(name, O_RDONLY); |
876 | if (fd < 0) | 879 | if (fd < 0) |
877 | goto out; | 880 | goto out; |
@@ -947,7 +950,7 @@ static int dso__synthesize_plt_symbols(struct dso *self, struct map *map, | |||
947 | if (filter && filter(map, f)) | 950 | if (filter && filter(map, f)) |
948 | symbol__delete(f); | 951 | symbol__delete(f); |
949 | else { | 952 | else { |
950 | symbols__insert(&self->symbols[map->type], f); | 953 | symbols__insert(&dso->symbols[map->type], f); |
951 | ++nr; | 954 | ++nr; |
952 | } | 955 | } |
953 | } | 956 | } |
@@ -969,7 +972,7 @@ static int dso__synthesize_plt_symbols(struct dso *self, struct map *map, | |||
969 | if (filter && filter(map, f)) | 972 | if (filter && filter(map, f)) |
970 | symbol__delete(f); | 973 | symbol__delete(f); |
971 | else { | 974 | else { |
972 | symbols__insert(&self->symbols[map->type], f); | 975 | symbols__insert(&dso->symbols[map->type], f); |
973 | ++nr; | 976 | ++nr; |
974 | } | 977 | } |
975 | } | 978 | } |
@@ -985,29 +988,30 @@ out_close: | |||
985 | return nr; | 988 | return nr; |
986 | out: | 989 | out: |
987 | pr_debug("%s: problems reading %s PLT info.\n", | 990 | pr_debug("%s: problems reading %s PLT info.\n", |
988 | __func__, self->long_name); | 991 | __func__, dso->long_name); |
989 | return 0; | 992 | return 0; |
990 | } | 993 | } |
991 | 994 | ||
992 | static bool elf_sym__is_a(GElf_Sym *self, enum map_type type) | 995 | static bool elf_sym__is_a(GElf_Sym *sym, enum map_type type) |
993 | { | 996 | { |
994 | switch (type) { | 997 | switch (type) { |
995 | case MAP__FUNCTION: | 998 | case MAP__FUNCTION: |
996 | return elf_sym__is_function(self); | 999 | return elf_sym__is_function(sym); |
997 | case MAP__VARIABLE: | 1000 | case MAP__VARIABLE: |
998 | return elf_sym__is_object(self); | 1001 | return elf_sym__is_object(sym); |
999 | default: | 1002 | default: |
1000 | return false; | 1003 | return false; |
1001 | } | 1004 | } |
1002 | } | 1005 | } |
1003 | 1006 | ||
1004 | static bool elf_sec__is_a(GElf_Shdr *self, Elf_Data *secstrs, enum map_type type) | 1007 | static bool elf_sec__is_a(GElf_Shdr *shdr, Elf_Data *secstrs, |
1008 | enum map_type type) | ||
1005 | { | 1009 | { |
1006 | switch (type) { | 1010 | switch (type) { |
1007 | case MAP__FUNCTION: | 1011 | case MAP__FUNCTION: |
1008 | return elf_sec__is_text(self, secstrs); | 1012 | return elf_sec__is_text(shdr, secstrs); |
1009 | case MAP__VARIABLE: | 1013 | case MAP__VARIABLE: |
1010 | return elf_sec__is_data(self, secstrs); | 1014 | return elf_sec__is_data(shdr, secstrs); |
1011 | default: | 1015 | default: |
1012 | return false; | 1016 | return false; |
1013 | } | 1017 | } |
@@ -1032,13 +1036,13 @@ static size_t elf_addr_to_index(Elf *elf, GElf_Addr addr) | |||
1032 | return -1; | 1036 | return -1; |
1033 | } | 1037 | } |
1034 | 1038 | ||
1035 | static int dso__load_sym(struct dso *self, struct map *map, const char *name, | 1039 | static int dso__load_sym(struct dso *dso, struct map *map, const char *name, |
1036 | int fd, symbol_filter_t filter, int kmodule, | 1040 | int fd, symbol_filter_t filter, int kmodule, |
1037 | int want_symtab) | 1041 | int want_symtab) |
1038 | { | 1042 | { |
1039 | struct kmap *kmap = self->kernel ? map__kmap(map) : NULL; | 1043 | struct kmap *kmap = dso->kernel ? map__kmap(map) : NULL; |
1040 | struct map *curr_map = map; | 1044 | struct map *curr_map = map; |
1041 | struct dso *curr_dso = self; | 1045 | struct dso *curr_dso = dso; |
1042 | Elf_Data *symstrs, *secstrs; | 1046 | Elf_Data *symstrs, *secstrs; |
1043 | uint32_t nr_syms; | 1047 | uint32_t nr_syms; |
1044 | int err = -1; | 1048 | int err = -1; |
@@ -1064,14 +1068,14 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name, | |||
1064 | } | 1068 | } |
1065 | 1069 | ||
1066 | /* Always reject images with a mismatched build-id: */ | 1070 | /* Always reject images with a mismatched build-id: */ |
1067 | if (self->has_build_id) { | 1071 | if (dso->has_build_id) { |
1068 | u8 build_id[BUILD_ID_SIZE]; | 1072 | u8 build_id[BUILD_ID_SIZE]; |
1069 | 1073 | ||
1070 | if (elf_read_build_id(elf, build_id, | 1074 | if (elf_read_build_id(elf, build_id, |
1071 | BUILD_ID_SIZE) != BUILD_ID_SIZE) | 1075 | BUILD_ID_SIZE) != BUILD_ID_SIZE) |
1072 | goto out_elf_end; | 1076 | goto out_elf_end; |
1073 | 1077 | ||
1074 | if (!dso__build_id_equal(self, build_id)) | 1078 | if (!dso__build_id_equal(dso, build_id)) |
1075 | goto out_elf_end; | 1079 | goto out_elf_end; |
1076 | } | 1080 | } |
1077 | 1081 | ||
@@ -1112,13 +1116,14 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name, | |||
1112 | nr_syms = shdr.sh_size / shdr.sh_entsize; | 1116 | nr_syms = shdr.sh_size / shdr.sh_entsize; |
1113 | 1117 | ||
1114 | memset(&sym, 0, sizeof(sym)); | 1118 | memset(&sym, 0, sizeof(sym)); |
1115 | if (self->kernel == DSO_TYPE_USER) { | 1119 | if (dso->kernel == DSO_TYPE_USER) { |
1116 | self->adjust_symbols = (ehdr.e_type == ET_EXEC || | 1120 | dso->adjust_symbols = (ehdr.e_type == ET_EXEC || |
1117 | elf_section_by_name(elf, &ehdr, &shdr, | 1121 | elf_section_by_name(elf, &ehdr, &shdr, |
1118 | ".gnu.prelink_undo", | 1122 | ".gnu.prelink_undo", |
1119 | NULL) != NULL); | 1123 | NULL) != NULL); |
1120 | } else self->adjust_symbols = 0; | 1124 | } else { |
1121 | 1125 | dso->adjust_symbols = 0; | |
1126 | } | ||
1122 | elf_symtab__for_each_symbol(syms, nr_syms, idx, sym) { | 1127 | elf_symtab__for_each_symbol(syms, nr_syms, idx, sym) { |
1123 | struct symbol *f; | 1128 | struct symbol *f; |
1124 | const char *elf_name = elf_sym__name(&sym, symstrs); | 1129 | const char *elf_name = elf_sym__name(&sym, symstrs); |
@@ -1168,22 +1173,22 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name, | |||
1168 | (sym.st_value & 1)) | 1173 | (sym.st_value & 1)) |
1169 | --sym.st_value; | 1174 | --sym.st_value; |
1170 | 1175 | ||
1171 | if (self->kernel != DSO_TYPE_USER || kmodule) { | 1176 | if (dso->kernel != DSO_TYPE_USER || kmodule) { |
1172 | char dso_name[PATH_MAX]; | 1177 | char dso_name[PATH_MAX]; |
1173 | 1178 | ||
1174 | if (strcmp(section_name, | 1179 | if (strcmp(section_name, |
1175 | (curr_dso->short_name + | 1180 | (curr_dso->short_name + |
1176 | self->short_name_len)) == 0) | 1181 | dso->short_name_len)) == 0) |
1177 | goto new_symbol; | 1182 | goto new_symbol; |
1178 | 1183 | ||
1179 | if (strcmp(section_name, ".text") == 0) { | 1184 | if (strcmp(section_name, ".text") == 0) { |
1180 | curr_map = map; | 1185 | curr_map = map; |
1181 | curr_dso = self; | 1186 | curr_dso = dso; |
1182 | goto new_symbol; | 1187 | goto new_symbol; |
1183 | } | 1188 | } |
1184 | 1189 | ||
1185 | snprintf(dso_name, sizeof(dso_name), | 1190 | snprintf(dso_name, sizeof(dso_name), |
1186 | "%s%s", self->short_name, section_name); | 1191 | "%s%s", dso->short_name, section_name); |
1187 | 1192 | ||
1188 | curr_map = map_groups__find_by_name(kmap->kmaps, map->type, dso_name); | 1193 | curr_map = map_groups__find_by_name(kmap->kmaps, map->type, dso_name); |
1189 | if (curr_map == NULL) { | 1194 | if (curr_map == NULL) { |
@@ -1195,9 +1200,9 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name, | |||
1195 | curr_dso = dso__new(dso_name); | 1200 | curr_dso = dso__new(dso_name); |
1196 | if (curr_dso == NULL) | 1201 | if (curr_dso == NULL) |
1197 | goto out_elf_end; | 1202 | goto out_elf_end; |
1198 | curr_dso->kernel = self->kernel; | 1203 | curr_dso->kernel = dso->kernel; |
1199 | curr_dso->long_name = self->long_name; | 1204 | curr_dso->long_name = dso->long_name; |
1200 | curr_dso->long_name_len = self->long_name_len; | 1205 | curr_dso->long_name_len = dso->long_name_len; |
1201 | curr_map = map__new2(start, curr_dso, | 1206 | curr_map = map__new2(start, curr_dso, |
1202 | map->type); | 1207 | map->type); |
1203 | if (curr_map == NULL) { | 1208 | if (curr_map == NULL) { |
@@ -1206,9 +1211,9 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name, | |||
1206 | } | 1211 | } |
1207 | curr_map->map_ip = identity__map_ip; | 1212 | curr_map->map_ip = identity__map_ip; |
1208 | curr_map->unmap_ip = identity__map_ip; | 1213 | curr_map->unmap_ip = identity__map_ip; |
1209 | curr_dso->symtab_type = self->symtab_type; | 1214 | curr_dso->symtab_type = dso->symtab_type; |
1210 | map_groups__insert(kmap->kmaps, curr_map); | 1215 | map_groups__insert(kmap->kmaps, curr_map); |
1211 | dsos__add(&self->node, curr_dso); | 1216 | dsos__add(&dso->node, curr_dso); |
1212 | dso__set_loaded(curr_dso, map->type); | 1217 | dso__set_loaded(curr_dso, map->type); |
1213 | } else | 1218 | } else |
1214 | curr_dso = curr_map->dso; | 1219 | curr_dso = curr_map->dso; |
@@ -1250,7 +1255,7 @@ new_symbol: | |||
1250 | * For misannotated, zeroed, ASM function sizes. | 1255 | * For misannotated, zeroed, ASM function sizes. |
1251 | */ | 1256 | */ |
1252 | if (nr > 0) { | 1257 | if (nr > 0) { |
1253 | symbols__fixup_end(&self->symbols[map->type]); | 1258 | symbols__fixup_end(&dso->symbols[map->type]); |
1254 | if (kmap) { | 1259 | if (kmap) { |
1255 | /* | 1260 | /* |
1256 | * We need to fixup this here too because we create new | 1261 | * We need to fixup this here too because we create new |
@@ -1266,9 +1271,9 @@ out_close: | |||
1266 | return err; | 1271 | return err; |
1267 | } | 1272 | } |
1268 | 1273 | ||
1269 | static bool dso__build_id_equal(const struct dso *self, u8 *build_id) | 1274 | static bool dso__build_id_equal(const struct dso *dso, u8 *build_id) |
1270 | { | 1275 | { |
1271 | return memcmp(self->build_id, build_id, sizeof(self->build_id)) == 0; | 1276 | return memcmp(dso->build_id, build_id, sizeof(dso->build_id)) == 0; |
1272 | } | 1277 | } |
1273 | 1278 | ||
1274 | bool __dsos__read_build_ids(struct list_head *head, bool with_hits) | 1279 | bool __dsos__read_build_ids(struct list_head *head, bool with_hits) |
@@ -1429,7 +1434,7 @@ out: | |||
1429 | return err; | 1434 | return err; |
1430 | } | 1435 | } |
1431 | 1436 | ||
1432 | char dso__symtab_origin(const struct dso *self) | 1437 | char dso__symtab_origin(const struct dso *dso) |
1433 | { | 1438 | { |
1434 | static const char origin[] = { | 1439 | static const char origin[] = { |
1435 | [SYMTAB__KALLSYMS] = 'k', | 1440 | [SYMTAB__KALLSYMS] = 'k', |
@@ -1444,12 +1449,12 @@ char dso__symtab_origin(const struct dso *self) | |||
1444 | [SYMTAB__GUEST_KMODULE] = 'G', | 1449 | [SYMTAB__GUEST_KMODULE] = 'G', |
1445 | }; | 1450 | }; |
1446 | 1451 | ||
1447 | if (self == NULL || self->symtab_type == SYMTAB__NOT_FOUND) | 1452 | if (dso == NULL || dso->symtab_type == SYMTAB__NOT_FOUND) |
1448 | return '!'; | 1453 | return '!'; |
1449 | return origin[self->symtab_type]; | 1454 | return origin[dso->symtab_type]; |
1450 | } | 1455 | } |
1451 | 1456 | ||
1452 | int dso__load(struct dso *self, struct map *map, symbol_filter_t filter) | 1457 | int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) |
1453 | { | 1458 | { |
1454 | int size = PATH_MAX; | 1459 | int size = PATH_MAX; |
1455 | char *name; | 1460 | char *name; |
@@ -1459,12 +1464,12 @@ int dso__load(struct dso *self, struct map *map, symbol_filter_t filter) | |||
1459 | const char *root_dir; | 1464 | const char *root_dir; |
1460 | int want_symtab; | 1465 | int want_symtab; |
1461 | 1466 | ||
1462 | dso__set_loaded(self, map->type); | 1467 | dso__set_loaded(dso, map->type); |
1463 | 1468 | ||
1464 | if (self->kernel == DSO_TYPE_KERNEL) | 1469 | if (dso->kernel == DSO_TYPE_KERNEL) |
1465 | return dso__load_kernel_sym(self, map, filter); | 1470 | return dso__load_kernel_sym(dso, map, filter); |
1466 | else if (self->kernel == DSO_TYPE_GUEST_KERNEL) | 1471 | else if (dso->kernel == DSO_TYPE_GUEST_KERNEL) |
1467 | return dso__load_guest_kernel_sym(self, map, filter); | 1472 | return dso__load_guest_kernel_sym(dso, map, filter); |
1468 | 1473 | ||
1469 | if (map->groups && map->groups->machine) | 1474 | if (map->groups && map->groups->machine) |
1470 | machine = map->groups->machine; | 1475 | machine = map->groups->machine; |
@@ -1475,11 +1480,11 @@ int dso__load(struct dso *self, struct map *map, symbol_filter_t filter) | |||
1475 | if (!name) | 1480 | if (!name) |
1476 | return -1; | 1481 | return -1; |
1477 | 1482 | ||
1478 | self->adjust_symbols = 0; | 1483 | dso->adjust_symbols = 0; |
1479 | 1484 | ||
1480 | if (strncmp(self->name, "/tmp/perf-", 10) == 0) { | 1485 | if (strncmp(dso->name, "/tmp/perf-", 10) == 0) { |
1481 | ret = dso__load_perf_map(self, map, filter); | 1486 | ret = dso__load_perf_map(dso, map, filter); |
1482 | self->symtab_type = ret > 0 ? SYMTAB__JAVA_JIT : | 1487 | dso->symtab_type = ret > 0 ? SYMTAB__JAVA_JIT : |
1483 | SYMTAB__NOT_FOUND; | 1488 | SYMTAB__NOT_FOUND; |
1484 | return ret; | 1489 | return ret; |
1485 | } | 1490 | } |
@@ -1490,33 +1495,33 @@ int dso__load(struct dso *self, struct map *map, symbol_filter_t filter) | |||
1490 | */ | 1495 | */ |
1491 | want_symtab = 1; | 1496 | want_symtab = 1; |
1492 | restart: | 1497 | restart: |
1493 | for (self->symtab_type = SYMTAB__BUILD_ID_CACHE; | 1498 | for (dso->symtab_type = SYMTAB__BUILD_ID_CACHE; |
1494 | self->symtab_type != SYMTAB__NOT_FOUND; | 1499 | dso->symtab_type != SYMTAB__NOT_FOUND; |
1495 | self->symtab_type++) { | 1500 | dso->symtab_type++) { |
1496 | switch (self->symtab_type) { | 1501 | switch (dso->symtab_type) { |
1497 | case SYMTAB__BUILD_ID_CACHE: | 1502 | case SYMTAB__BUILD_ID_CACHE: |
1498 | /* skip the locally configured cache if a symfs is given */ | 1503 | /* skip the locally configured cache if a symfs is given */ |
1499 | if (symbol_conf.symfs[0] || | 1504 | if (symbol_conf.symfs[0] || |
1500 | (dso__build_id_filename(self, name, size) == NULL)) { | 1505 | (dso__build_id_filename(dso, name, size) == NULL)) { |
1501 | continue; | 1506 | continue; |
1502 | } | 1507 | } |
1503 | break; | 1508 | break; |
1504 | case SYMTAB__FEDORA_DEBUGINFO: | 1509 | case SYMTAB__FEDORA_DEBUGINFO: |
1505 | snprintf(name, size, "%s/usr/lib/debug%s.debug", | 1510 | snprintf(name, size, "%s/usr/lib/debug%s.debug", |
1506 | symbol_conf.symfs, self->long_name); | 1511 | symbol_conf.symfs, dso->long_name); |
1507 | break; | 1512 | break; |
1508 | case SYMTAB__UBUNTU_DEBUGINFO: | 1513 | case SYMTAB__UBUNTU_DEBUGINFO: |
1509 | snprintf(name, size, "%s/usr/lib/debug%s", | 1514 | snprintf(name, size, "%s/usr/lib/debug%s", |
1510 | symbol_conf.symfs, self->long_name); | 1515 | symbol_conf.symfs, dso->long_name); |
1511 | break; | 1516 | break; |
1512 | case SYMTAB__BUILDID_DEBUGINFO: { | 1517 | case SYMTAB__BUILDID_DEBUGINFO: { |
1513 | char build_id_hex[BUILD_ID_SIZE * 2 + 1]; | 1518 | char build_id_hex[BUILD_ID_SIZE * 2 + 1]; |
1514 | 1519 | ||
1515 | if (!self->has_build_id) | 1520 | if (!dso->has_build_id) |
1516 | continue; | 1521 | continue; |
1517 | 1522 | ||
1518 | build_id__sprintf(self->build_id, | 1523 | build_id__sprintf(dso->build_id, |
1519 | sizeof(self->build_id), | 1524 | sizeof(dso->build_id), |
1520 | build_id_hex); | 1525 | build_id_hex); |
1521 | snprintf(name, size, | 1526 | snprintf(name, size, |
1522 | "%s/usr/lib/debug/.build-id/%.2s/%s.debug", | 1527 | "%s/usr/lib/debug/.build-id/%.2s/%s.debug", |
@@ -1525,7 +1530,7 @@ restart: | |||
1525 | break; | 1530 | break; |
1526 | case SYMTAB__SYSTEM_PATH_DSO: | 1531 | case SYMTAB__SYSTEM_PATH_DSO: |
1527 | snprintf(name, size, "%s%s", | 1532 | snprintf(name, size, "%s%s", |
1528 | symbol_conf.symfs, self->long_name); | 1533 | symbol_conf.symfs, dso->long_name); |
1529 | break; | 1534 | break; |
1530 | case SYMTAB__GUEST_KMODULE: | 1535 | case SYMTAB__GUEST_KMODULE: |
1531 | if (map->groups && machine) | 1536 | if (map->groups && machine) |
@@ -1533,12 +1538,12 @@ restart: | |||
1533 | else | 1538 | else |
1534 | root_dir = ""; | 1539 | root_dir = ""; |
1535 | snprintf(name, size, "%s%s%s", symbol_conf.symfs, | 1540 | snprintf(name, size, "%s%s%s", symbol_conf.symfs, |
1536 | root_dir, self->long_name); | 1541 | root_dir, dso->long_name); |
1537 | break; | 1542 | break; |
1538 | 1543 | ||
1539 | case SYMTAB__SYSTEM_PATH_KMODULE: | 1544 | case SYMTAB__SYSTEM_PATH_KMODULE: |
1540 | snprintf(name, size, "%s%s", symbol_conf.symfs, | 1545 | snprintf(name, size, "%s%s", symbol_conf.symfs, |
1541 | self->long_name); | 1546 | dso->long_name); |
1542 | break; | 1547 | break; |
1543 | default:; | 1548 | default:; |
1544 | } | 1549 | } |
@@ -1548,7 +1553,7 @@ restart: | |||
1548 | if (fd < 0) | 1553 | if (fd < 0) |
1549 | continue; | 1554 | continue; |
1550 | 1555 | ||
1551 | ret = dso__load_sym(self, map, name, fd, filter, 0, | 1556 | ret = dso__load_sym(dso, map, name, fd, filter, 0, |
1552 | want_symtab); | 1557 | want_symtab); |
1553 | close(fd); | 1558 | close(fd); |
1554 | 1559 | ||
@@ -1560,7 +1565,8 @@ restart: | |||
1560 | continue; | 1565 | continue; |
1561 | 1566 | ||
1562 | if (ret > 0) { | 1567 | if (ret > 0) { |
1563 | int nr_plt = dso__synthesize_plt_symbols(self, map, filter); | 1568 | int nr_plt = dso__synthesize_plt_symbols(dso, map, |
1569 | filter); | ||
1564 | if (nr_plt > 0) | 1570 | if (nr_plt > 0) |
1565 | ret += nr_plt; | 1571 | ret += nr_plt; |
1566 | break; | 1572 | break; |
@@ -1577,17 +1583,17 @@ restart: | |||
1577 | } | 1583 | } |
1578 | 1584 | ||
1579 | free(name); | 1585 | free(name); |
1580 | if (ret < 0 && strstr(self->name, " (deleted)") != NULL) | 1586 | if (ret < 0 && strstr(dso->name, " (deleted)") != NULL) |
1581 | return 0; | 1587 | return 0; |
1582 | return ret; | 1588 | return ret; |
1583 | } | 1589 | } |
1584 | 1590 | ||
1585 | struct map *map_groups__find_by_name(struct map_groups *self, | 1591 | struct map *map_groups__find_by_name(struct map_groups *mg, |
1586 | enum map_type type, const char *name) | 1592 | enum map_type type, const char *name) |
1587 | { | 1593 | { |
1588 | struct rb_node *nd; | 1594 | struct rb_node *nd; |
1589 | 1595 | ||
1590 | for (nd = rb_first(&self->maps[type]); nd; nd = rb_next(nd)) { | 1596 | for (nd = rb_first(&mg->maps[type]); nd; nd = rb_next(nd)) { |
1591 | struct map *map = rb_entry(nd, struct map, rb_node); | 1597 | struct map *map = rb_entry(nd, struct map, rb_node); |
1592 | 1598 | ||
1593 | if (map->dso && strcmp(map->dso->short_name, name) == 0) | 1599 | if (map->dso && strcmp(map->dso->short_name, name) == 0) |
@@ -1597,28 +1603,28 @@ struct map *map_groups__find_by_name(struct map_groups *self, | |||
1597 | return NULL; | 1603 | return NULL; |
1598 | } | 1604 | } |
1599 | 1605 | ||
1600 | static int dso__kernel_module_get_build_id(struct dso *self, | 1606 | static int dso__kernel_module_get_build_id(struct dso *dso, |
1601 | const char *root_dir) | 1607 | const char *root_dir) |
1602 | { | 1608 | { |
1603 | char filename[PATH_MAX]; | 1609 | char filename[PATH_MAX]; |
1604 | /* | 1610 | /* |
1605 | * kernel module short names are of the form "[module]" and | 1611 | * kernel module short names are of the form "[module]" and |
1606 | * we need just "module" here. | 1612 | * we need just "module" here. |
1607 | */ | 1613 | */ |
1608 | const char *name = self->short_name + 1; | 1614 | const char *name = dso->short_name + 1; |
1609 | 1615 | ||
1610 | snprintf(filename, sizeof(filename), | 1616 | snprintf(filename, sizeof(filename), |
1611 | "%s/sys/module/%.*s/notes/.note.gnu.build-id", | 1617 | "%s/sys/module/%.*s/notes/.note.gnu.build-id", |
1612 | root_dir, (int)strlen(name) - 1, name); | 1618 | root_dir, (int)strlen(name) - 1, name); |
1613 | 1619 | ||
1614 | if (sysfs__read_build_id(filename, self->build_id, | 1620 | if (sysfs__read_build_id(filename, dso->build_id, |
1615 | sizeof(self->build_id)) == 0) | 1621 | sizeof(dso->build_id)) == 0) |
1616 | self->has_build_id = true; | 1622 | dso->has_build_id = true; |
1617 | 1623 | ||
1618 | return 0; | 1624 | return 0; |
1619 | } | 1625 | } |
1620 | 1626 | ||
1621 | static int map_groups__set_modules_path_dir(struct map_groups *self, | 1627 | static int map_groups__set_modules_path_dir(struct map_groups *mg, |
1622 | const char *dir_name) | 1628 | const char *dir_name) |
1623 | { | 1629 | { |
1624 | struct dirent *dent; | 1630 | struct dirent *dent; |
@@ -1646,7 +1652,7 @@ static int map_groups__set_modules_path_dir(struct map_groups *self, | |||
1646 | 1652 | ||
1647 | snprintf(path, sizeof(path), "%s/%s", | 1653 | snprintf(path, sizeof(path), "%s/%s", |
1648 | dir_name, dent->d_name); | 1654 | dir_name, dent->d_name); |
1649 | ret = map_groups__set_modules_path_dir(self, path); | 1655 | ret = map_groups__set_modules_path_dir(mg, path); |
1650 | if (ret < 0) | 1656 | if (ret < 0) |
1651 | goto out; | 1657 | goto out; |
1652 | } else { | 1658 | } else { |
@@ -1661,7 +1667,8 @@ static int map_groups__set_modules_path_dir(struct map_groups *self, | |||
1661 | (int)(dot - dent->d_name), dent->d_name); | 1667 | (int)(dot - dent->d_name), dent->d_name); |
1662 | 1668 | ||
1663 | strxfrchar(dso_name, '-', '_'); | 1669 | strxfrchar(dso_name, '-', '_'); |
1664 | map = map_groups__find_by_name(self, MAP__FUNCTION, dso_name); | 1670 | map = map_groups__find_by_name(mg, MAP__FUNCTION, |
1671 | dso_name); | ||
1665 | if (map == NULL) | 1672 | if (map == NULL) |
1666 | continue; | 1673 | continue; |
1667 | 1674 | ||
@@ -1711,20 +1718,20 @@ static char *get_kernel_version(const char *root_dir) | |||
1711 | return strdup(name); | 1718 | return strdup(name); |
1712 | } | 1719 | } |
1713 | 1720 | ||
1714 | static int machine__set_modules_path(struct machine *self) | 1721 | static int machine__set_modules_path(struct machine *machine) |
1715 | { | 1722 | { |
1716 | char *version; | 1723 | char *version; |
1717 | char modules_path[PATH_MAX]; | 1724 | char modules_path[PATH_MAX]; |
1718 | 1725 | ||
1719 | version = get_kernel_version(self->root_dir); | 1726 | version = get_kernel_version(machine->root_dir); |
1720 | if (!version) | 1727 | if (!version) |
1721 | return -1; | 1728 | return -1; |
1722 | 1729 | ||
1723 | snprintf(modules_path, sizeof(modules_path), "%s/lib/modules/%s/kernel", | 1730 | snprintf(modules_path, sizeof(modules_path), "%s/lib/modules/%s/kernel", |
1724 | self->root_dir, version); | 1731 | machine->root_dir, version); |
1725 | free(version); | 1732 | free(version); |
1726 | 1733 | ||
1727 | return map_groups__set_modules_path_dir(&self->kmaps, modules_path); | 1734 | return map_groups__set_modules_path_dir(&machine->kmaps, modules_path); |
1728 | } | 1735 | } |
1729 | 1736 | ||
1730 | /* | 1737 | /* |
@@ -1734,23 +1741,23 @@ static int machine__set_modules_path(struct machine *self) | |||
1734 | */ | 1741 | */ |
1735 | static struct map *map__new2(u64 start, struct dso *dso, enum map_type type) | 1742 | static struct map *map__new2(u64 start, struct dso *dso, enum map_type type) |
1736 | { | 1743 | { |
1737 | struct map *self = calloc(1, (sizeof(*self) + | 1744 | struct map *map = calloc(1, (sizeof(*map) + |
1738 | (dso->kernel ? sizeof(struct kmap) : 0))); | 1745 | (dso->kernel ? sizeof(struct kmap) : 0))); |
1739 | if (self != NULL) { | 1746 | if (map != NULL) { |
1740 | /* | 1747 | /* |
1741 | * ->end will be filled after we load all the symbols | 1748 | * ->end will be filled after we load all the symbols |
1742 | */ | 1749 | */ |
1743 | map__init(self, type, start, 0, 0, dso); | 1750 | map__init(map, type, start, 0, 0, dso); |
1744 | } | 1751 | } |
1745 | 1752 | ||
1746 | return self; | 1753 | return map; |
1747 | } | 1754 | } |
1748 | 1755 | ||
1749 | struct map *machine__new_module(struct machine *self, u64 start, | 1756 | struct map *machine__new_module(struct machine *machine, u64 start, |
1750 | const char *filename) | 1757 | const char *filename) |
1751 | { | 1758 | { |
1752 | struct map *map; | 1759 | struct map *map; |
1753 | struct dso *dso = __dsos__findnew(&self->kernel_dsos, filename); | 1760 | struct dso *dso = __dsos__findnew(&machine->kernel_dsos, filename); |
1754 | 1761 | ||
1755 | if (dso == NULL) | 1762 | if (dso == NULL) |
1756 | return NULL; | 1763 | return NULL; |
@@ -1759,15 +1766,15 @@ struct map *machine__new_module(struct machine *self, u64 start, | |||
1759 | if (map == NULL) | 1766 | if (map == NULL) |
1760 | return NULL; | 1767 | return NULL; |
1761 | 1768 | ||
1762 | if (machine__is_host(self)) | 1769 | if (machine__is_host(machine)) |
1763 | dso->symtab_type = SYMTAB__SYSTEM_PATH_KMODULE; | 1770 | dso->symtab_type = SYMTAB__SYSTEM_PATH_KMODULE; |
1764 | else | 1771 | else |
1765 | dso->symtab_type = SYMTAB__GUEST_KMODULE; | 1772 | dso->symtab_type = SYMTAB__GUEST_KMODULE; |
1766 | map_groups__insert(&self->kmaps, map); | 1773 | map_groups__insert(&machine->kmaps, map); |
1767 | return map; | 1774 | return map; |
1768 | } | 1775 | } |
1769 | 1776 | ||
1770 | static int machine__create_modules(struct machine *self) | 1777 | static int machine__create_modules(struct machine *machine) |
1771 | { | 1778 | { |
1772 | char *line = NULL; | 1779 | char *line = NULL; |
1773 | size_t n; | 1780 | size_t n; |
@@ -1776,10 +1783,10 @@ static int machine__create_modules(struct machine *self) | |||
1776 | const char *modules; | 1783 | const char *modules; |
1777 | char path[PATH_MAX]; | 1784 | char path[PATH_MAX]; |
1778 | 1785 | ||
1779 | if (machine__is_default_guest(self)) | 1786 | if (machine__is_default_guest(machine)) |
1780 | modules = symbol_conf.default_guest_modules; | 1787 | modules = symbol_conf.default_guest_modules; |
1781 | else { | 1788 | else { |
1782 | sprintf(path, "%s/proc/modules", self->root_dir); | 1789 | sprintf(path, "%s/proc/modules", machine->root_dir); |
1783 | modules = path; | 1790 | modules = path; |
1784 | } | 1791 | } |
1785 | 1792 | ||
@@ -1815,16 +1822,16 @@ static int machine__create_modules(struct machine *self) | |||
1815 | *sep = '\0'; | 1822 | *sep = '\0'; |
1816 | 1823 | ||
1817 | snprintf(name, sizeof(name), "[%s]", line); | 1824 | snprintf(name, sizeof(name), "[%s]", line); |
1818 | map = machine__new_module(self, start, name); | 1825 | map = machine__new_module(machine, start, name); |
1819 | if (map == NULL) | 1826 | if (map == NULL) |
1820 | goto out_delete_line; | 1827 | goto out_delete_line; |
1821 | dso__kernel_module_get_build_id(map->dso, self->root_dir); | 1828 | dso__kernel_module_get_build_id(map->dso, machine->root_dir); |
1822 | } | 1829 | } |
1823 | 1830 | ||
1824 | free(line); | 1831 | free(line); |
1825 | fclose(file); | 1832 | fclose(file); |
1826 | 1833 | ||
1827 | return machine__set_modules_path(self); | 1834 | return machine__set_modules_path(machine); |
1828 | 1835 | ||
1829 | out_delete_line: | 1836 | out_delete_line: |
1830 | free(line); | 1837 | free(line); |
@@ -1832,7 +1839,7 @@ out_failure: | |||
1832 | return -1; | 1839 | return -1; |
1833 | } | 1840 | } |
1834 | 1841 | ||
1835 | int dso__load_vmlinux(struct dso *self, struct map *map, | 1842 | int dso__load_vmlinux(struct dso *dso, struct map *map, |
1836 | const char *vmlinux, symbol_filter_t filter) | 1843 | const char *vmlinux, symbol_filter_t filter) |
1837 | { | 1844 | { |
1838 | int err = -1, fd; | 1845 | int err = -1, fd; |
@@ -1844,9 +1851,9 @@ int dso__load_vmlinux(struct dso *self, struct map *map, | |||
1844 | if (fd < 0) | 1851 | if (fd < 0) |
1845 | return -1; | 1852 | return -1; |
1846 | 1853 | ||
1847 | dso__set_long_name(self, (char *)vmlinux); | 1854 | dso__set_long_name(dso, (char *)vmlinux); |
1848 | dso__set_loaded(self, map->type); | 1855 | dso__set_loaded(dso, map->type); |
1849 | err = dso__load_sym(self, map, symfs_vmlinux, fd, filter, 0, 0); | 1856 | err = dso__load_sym(dso, map, symfs_vmlinux, fd, filter, 0, 0); |
1850 | close(fd); | 1857 | close(fd); |
1851 | 1858 | ||
1852 | if (err > 0) | 1859 | if (err > 0) |
@@ -1855,7 +1862,7 @@ int dso__load_vmlinux(struct dso *self, struct map *map, | |||
1855 | return err; | 1862 | return err; |
1856 | } | 1863 | } |
1857 | 1864 | ||
1858 | int dso__load_vmlinux_path(struct dso *self, struct map *map, | 1865 | int dso__load_vmlinux_path(struct dso *dso, struct map *map, |
1859 | symbol_filter_t filter) | 1866 | symbol_filter_t filter) |
1860 | { | 1867 | { |
1861 | int i, err = 0; | 1868 | int i, err = 0; |
@@ -1864,20 +1871,20 @@ int dso__load_vmlinux_path(struct dso *self, struct map *map, | |||
1864 | pr_debug("Looking at the vmlinux_path (%d entries long)\n", | 1871 | pr_debug("Looking at the vmlinux_path (%d entries long)\n", |
1865 | vmlinux_path__nr_entries + 1); | 1872 | vmlinux_path__nr_entries + 1); |
1866 | 1873 | ||
1867 | filename = dso__build_id_filename(self, NULL, 0); | 1874 | filename = dso__build_id_filename(dso, NULL, 0); |
1868 | if (filename != NULL) { | 1875 | if (filename != NULL) { |
1869 | err = dso__load_vmlinux(self, map, filename, filter); | 1876 | err = dso__load_vmlinux(dso, map, filename, filter); |
1870 | if (err > 0) { | 1877 | if (err > 0) { |
1871 | dso__set_long_name(self, filename); | 1878 | dso__set_long_name(dso, filename); |
1872 | goto out; | 1879 | goto out; |
1873 | } | 1880 | } |
1874 | free(filename); | 1881 | free(filename); |
1875 | } | 1882 | } |
1876 | 1883 | ||
1877 | for (i = 0; i < vmlinux_path__nr_entries; ++i) { | 1884 | for (i = 0; i < vmlinux_path__nr_entries; ++i) { |
1878 | err = dso__load_vmlinux(self, map, vmlinux_path[i], filter); | 1885 | err = dso__load_vmlinux(dso, map, vmlinux_path[i], filter); |
1879 | if (err > 0) { | 1886 | if (err > 0) { |
1880 | dso__set_long_name(self, strdup(vmlinux_path[i])); | 1887 | dso__set_long_name(dso, strdup(vmlinux_path[i])); |
1881 | break; | 1888 | break; |
1882 | } | 1889 | } |
1883 | } | 1890 | } |
@@ -1885,7 +1892,7 @@ out: | |||
1885 | return err; | 1892 | return err; |
1886 | } | 1893 | } |
1887 | 1894 | ||
1888 | static int dso__load_kernel_sym(struct dso *self, struct map *map, | 1895 | static int dso__load_kernel_sym(struct dso *dso, struct map *map, |
1889 | symbol_filter_t filter) | 1896 | symbol_filter_t filter) |
1890 | { | 1897 | { |
1891 | int err; | 1898 | int err; |
@@ -1912,10 +1919,10 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map, | |||
1912 | } | 1919 | } |
1913 | 1920 | ||
1914 | if (symbol_conf.vmlinux_name != NULL) { | 1921 | if (symbol_conf.vmlinux_name != NULL) { |
1915 | err = dso__load_vmlinux(self, map, | 1922 | err = dso__load_vmlinux(dso, map, |
1916 | symbol_conf.vmlinux_name, filter); | 1923 | symbol_conf.vmlinux_name, filter); |
1917 | if (err > 0) { | 1924 | if (err > 0) { |
1918 | dso__set_long_name(self, | 1925 | dso__set_long_name(dso, |
1919 | strdup(symbol_conf.vmlinux_name)); | 1926 | strdup(symbol_conf.vmlinux_name)); |
1920 | goto out_fixup; | 1927 | goto out_fixup; |
1921 | } | 1928 | } |
@@ -1923,7 +1930,7 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map, | |||
1923 | } | 1930 | } |
1924 | 1931 | ||
1925 | if (vmlinux_path != NULL) { | 1932 | if (vmlinux_path != NULL) { |
1926 | err = dso__load_vmlinux_path(self, map, filter); | 1933 | err = dso__load_vmlinux_path(dso, map, filter); |
1927 | if (err > 0) | 1934 | if (err > 0) |
1928 | goto out_fixup; | 1935 | goto out_fixup; |
1929 | } | 1936 | } |
@@ -1937,13 +1944,13 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map, | |||
1937 | * we have a build-id, so check if it is the same as the running kernel, | 1944 | * we have a build-id, so check if it is the same as the running kernel, |
1938 | * using it if it is. | 1945 | * using it if it is. |
1939 | */ | 1946 | */ |
1940 | if (self->has_build_id) { | 1947 | if (dso->has_build_id) { |
1941 | u8 kallsyms_build_id[BUILD_ID_SIZE]; | 1948 | u8 kallsyms_build_id[BUILD_ID_SIZE]; |
1942 | char sbuild_id[BUILD_ID_SIZE * 2 + 1]; | 1949 | char sbuild_id[BUILD_ID_SIZE * 2 + 1]; |
1943 | 1950 | ||
1944 | if (sysfs__read_build_id("/sys/kernel/notes", kallsyms_build_id, | 1951 | if (sysfs__read_build_id("/sys/kernel/notes", kallsyms_build_id, |
1945 | sizeof(kallsyms_build_id)) == 0) { | 1952 | sizeof(kallsyms_build_id)) == 0) { |
1946 | if (dso__build_id_equal(self, kallsyms_build_id)) { | 1953 | if (dso__build_id_equal(dso, kallsyms_build_id)) { |
1947 | kallsyms_filename = "/proc/kallsyms"; | 1954 | kallsyms_filename = "/proc/kallsyms"; |
1948 | goto do_kallsyms; | 1955 | goto do_kallsyms; |
1949 | } | 1956 | } |
@@ -1952,7 +1959,7 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map, | |||
1952 | * Now look if we have it on the build-id cache in | 1959 | * Now look if we have it on the build-id cache in |
1953 | * $HOME/.debug/[kernel.kallsyms]. | 1960 | * $HOME/.debug/[kernel.kallsyms]. |
1954 | */ | 1961 | */ |
1955 | build_id__sprintf(self->build_id, sizeof(self->build_id), | 1962 | build_id__sprintf(dso->build_id, sizeof(dso->build_id), |
1956 | sbuild_id); | 1963 | sbuild_id); |
1957 | 1964 | ||
1958 | if (asprintf(&kallsyms_allocated_filename, | 1965 | if (asprintf(&kallsyms_allocated_filename, |
@@ -1979,7 +1986,7 @@ static int dso__load_kernel_sym(struct dso *self, struct map *map, | |||
1979 | } | 1986 | } |
1980 | 1987 | ||
1981 | do_kallsyms: | 1988 | do_kallsyms: |
1982 | err = dso__load_kallsyms(self, kallsyms_filename, map, filter); | 1989 | err = dso__load_kallsyms(dso, kallsyms_filename, map, filter); |
1983 | if (err > 0) | 1990 | if (err > 0) |
1984 | pr_debug("Using %s for symbols\n", kallsyms_filename); | 1991 | pr_debug("Using %s for symbols\n", kallsyms_filename); |
1985 | free(kallsyms_allocated_filename); | 1992 | free(kallsyms_allocated_filename); |
@@ -1987,7 +1994,7 @@ do_kallsyms: | |||
1987 | if (err > 0) { | 1994 | if (err > 0) { |
1988 | out_fixup: | 1995 | out_fixup: |
1989 | if (kallsyms_filename != NULL) | 1996 | if (kallsyms_filename != NULL) |
1990 | dso__set_long_name(self, strdup("[kernel.kallsyms]")); | 1997 | dso__set_long_name(dso, strdup("[kernel.kallsyms]")); |
1991 | map__fixup_start(map); | 1998 | map__fixup_start(map); |
1992 | map__fixup_end(map); | 1999 | map__fixup_end(map); |
1993 | } | 2000 | } |
@@ -1995,8 +2002,8 @@ out_fixup: | |||
1995 | return err; | 2002 | return err; |
1996 | } | 2003 | } |
1997 | 2004 | ||
1998 | static int dso__load_guest_kernel_sym(struct dso *self, struct map *map, | 2005 | static int dso__load_guest_kernel_sym(struct dso *dso, struct map *map, |
1999 | symbol_filter_t filter) | 2006 | symbol_filter_t filter) |
2000 | { | 2007 | { |
2001 | int err; | 2008 | int err; |
2002 | const char *kallsyms_filename = NULL; | 2009 | const char *kallsyms_filename = NULL; |
@@ -2016,7 +2023,7 @@ static int dso__load_guest_kernel_sym(struct dso *self, struct map *map, | |||
2016 | * Or use file guest_kallsyms inputted by user on commandline | 2023 | * Or use file guest_kallsyms inputted by user on commandline |
2017 | */ | 2024 | */ |
2018 | if (symbol_conf.default_guest_vmlinux_name != NULL) { | 2025 | if (symbol_conf.default_guest_vmlinux_name != NULL) { |
2019 | err = dso__load_vmlinux(self, map, | 2026 | err = dso__load_vmlinux(dso, map, |
2020 | symbol_conf.default_guest_vmlinux_name, filter); | 2027 | symbol_conf.default_guest_vmlinux_name, filter); |
2021 | goto out_try_fixup; | 2028 | goto out_try_fixup; |
2022 | } | 2029 | } |
@@ -2029,7 +2036,7 @@ static int dso__load_guest_kernel_sym(struct dso *self, struct map *map, | |||
2029 | kallsyms_filename = path; | 2036 | kallsyms_filename = path; |
2030 | } | 2037 | } |
2031 | 2038 | ||
2032 | err = dso__load_kallsyms(self, kallsyms_filename, map, filter); | 2039 | err = dso__load_kallsyms(dso, kallsyms_filename, map, filter); |
2033 | if (err > 0) | 2040 | if (err > 0) |
2034 | pr_debug("Using %s for symbols\n", kallsyms_filename); | 2041 | pr_debug("Using %s for symbols\n", kallsyms_filename); |
2035 | 2042 | ||
@@ -2037,7 +2044,7 @@ out_try_fixup: | |||
2037 | if (err > 0) { | 2044 | if (err > 0) { |
2038 | if (kallsyms_filename != NULL) { | 2045 | if (kallsyms_filename != NULL) { |
2039 | machine__mmap_name(machine, path, sizeof(path)); | 2046 | machine__mmap_name(machine, path, sizeof(path)); |
2040 | dso__set_long_name(self, strdup(path)); | 2047 | dso__set_long_name(dso, strdup(path)); |
2041 | } | 2048 | } |
2042 | map__fixup_start(map); | 2049 | map__fixup_start(map); |
2043 | map__fixup_end(map); | 2050 | map__fixup_end(map); |
@@ -2090,12 +2097,12 @@ size_t __dsos__fprintf(struct list_head *head, FILE *fp) | |||
2090 | return ret; | 2097 | return ret; |
2091 | } | 2098 | } |
2092 | 2099 | ||
2093 | size_t machines__fprintf_dsos(struct rb_root *self, FILE *fp) | 2100 | size_t machines__fprintf_dsos(struct rb_root *machines, FILE *fp) |
2094 | { | 2101 | { |
2095 | struct rb_node *nd; | 2102 | struct rb_node *nd; |
2096 | size_t ret = 0; | 2103 | size_t ret = 0; |
2097 | 2104 | ||
2098 | for (nd = rb_first(self); nd; nd = rb_next(nd)) { | 2105 | for (nd = rb_first(machines); nd; nd = rb_next(nd)) { |
2099 | struct machine *pos = rb_entry(nd, struct machine, rb_node); | 2106 | struct machine *pos = rb_entry(nd, struct machine, rb_node); |
2100 | ret += __dsos__fprintf(&pos->kernel_dsos, fp); | 2107 | ret += __dsos__fprintf(&pos->kernel_dsos, fp); |
2101 | ret += __dsos__fprintf(&pos->user_dsos, fp); | 2108 | ret += __dsos__fprintf(&pos->user_dsos, fp); |
@@ -2119,18 +2126,20 @@ static size_t __dsos__fprintf_buildid(struct list_head *head, FILE *fp, | |||
2119 | return ret; | 2126 | return ret; |
2120 | } | 2127 | } |
2121 | 2128 | ||
2122 | size_t machine__fprintf_dsos_buildid(struct machine *self, FILE *fp, bool with_hits) | 2129 | size_t machine__fprintf_dsos_buildid(struct machine *machine, FILE *fp, |
2130 | bool with_hits) | ||
2123 | { | 2131 | { |
2124 | return __dsos__fprintf_buildid(&self->kernel_dsos, fp, with_hits) + | 2132 | return __dsos__fprintf_buildid(&machine->kernel_dsos, fp, with_hits) + |
2125 | __dsos__fprintf_buildid(&self->user_dsos, fp, with_hits); | 2133 | __dsos__fprintf_buildid(&machine->user_dsos, fp, with_hits); |
2126 | } | 2134 | } |
2127 | 2135 | ||
2128 | size_t machines__fprintf_dsos_buildid(struct rb_root *self, FILE *fp, bool with_hits) | 2136 | size_t machines__fprintf_dsos_buildid(struct rb_root *machines, |
2137 | FILE *fp, bool with_hits) | ||
2129 | { | 2138 | { |
2130 | struct rb_node *nd; | 2139 | struct rb_node *nd; |
2131 | size_t ret = 0; | 2140 | size_t ret = 0; |
2132 | 2141 | ||
2133 | for (nd = rb_first(self); nd; nd = rb_next(nd)) { | 2142 | for (nd = rb_first(machines); nd; nd = rb_next(nd)) { |
2134 | struct machine *pos = rb_entry(nd, struct machine, rb_node); | 2143 | struct machine *pos = rb_entry(nd, struct machine, rb_node); |
2135 | ret += machine__fprintf_dsos_buildid(pos, fp, with_hits); | 2144 | ret += machine__fprintf_dsos_buildid(pos, fp, with_hits); |
2136 | } | 2145 | } |
@@ -2139,59 +2148,59 @@ size_t machines__fprintf_dsos_buildid(struct rb_root *self, FILE *fp, bool with_ | |||
2139 | 2148 | ||
2140 | struct dso *dso__new_kernel(const char *name) | 2149 | struct dso *dso__new_kernel(const char *name) |
2141 | { | 2150 | { |
2142 | struct dso *self = dso__new(name ?: "[kernel.kallsyms]"); | 2151 | struct dso *dso = dso__new(name ?: "[kernel.kallsyms]"); |
2143 | 2152 | ||
2144 | if (self != NULL) { | 2153 | if (dso != NULL) { |
2145 | dso__set_short_name(self, "[kernel]"); | 2154 | dso__set_short_name(dso, "[kernel]"); |
2146 | self->kernel = DSO_TYPE_KERNEL; | 2155 | dso->kernel = DSO_TYPE_KERNEL; |
2147 | } | 2156 | } |
2148 | 2157 | ||
2149 | return self; | 2158 | return dso; |
2150 | } | 2159 | } |
2151 | 2160 | ||
2152 | static struct dso *dso__new_guest_kernel(struct machine *machine, | 2161 | static struct dso *dso__new_guest_kernel(struct machine *machine, |
2153 | const char *name) | 2162 | const char *name) |
2154 | { | 2163 | { |
2155 | char bf[PATH_MAX]; | 2164 | char bf[PATH_MAX]; |
2156 | struct dso *self = dso__new(name ?: machine__mmap_name(machine, bf, sizeof(bf))); | 2165 | struct dso *dso = dso__new(name ?: machine__mmap_name(machine, bf, |
2157 | 2166 | sizeof(bf))); | |
2158 | if (self != NULL) { | 2167 | if (dso != NULL) { |
2159 | dso__set_short_name(self, "[guest.kernel]"); | 2168 | dso__set_short_name(dso, "[guest.kernel]"); |
2160 | self->kernel = DSO_TYPE_GUEST_KERNEL; | 2169 | dso->kernel = DSO_TYPE_GUEST_KERNEL; |
2161 | } | 2170 | } |
2162 | 2171 | ||
2163 | return self; | 2172 | return dso; |
2164 | } | 2173 | } |
2165 | 2174 | ||
2166 | void dso__read_running_kernel_build_id(struct dso *self, struct machine *machine) | 2175 | void dso__read_running_kernel_build_id(struct dso *dso, struct machine *machine) |
2167 | { | 2176 | { |
2168 | char path[PATH_MAX]; | 2177 | char path[PATH_MAX]; |
2169 | 2178 | ||
2170 | if (machine__is_default_guest(machine)) | 2179 | if (machine__is_default_guest(machine)) |
2171 | return; | 2180 | return; |
2172 | sprintf(path, "%s/sys/kernel/notes", machine->root_dir); | 2181 | sprintf(path, "%s/sys/kernel/notes", machine->root_dir); |
2173 | if (sysfs__read_build_id(path, self->build_id, | 2182 | if (sysfs__read_build_id(path, dso->build_id, |
2174 | sizeof(self->build_id)) == 0) | 2183 | sizeof(dso->build_id)) == 0) |
2175 | self->has_build_id = true; | 2184 | dso->has_build_id = true; |
2176 | } | 2185 | } |
2177 | 2186 | ||
2178 | static struct dso *machine__create_kernel(struct machine *self) | 2187 | static struct dso *machine__create_kernel(struct machine *machine) |
2179 | { | 2188 | { |
2180 | const char *vmlinux_name = NULL; | 2189 | const char *vmlinux_name = NULL; |
2181 | struct dso *kernel; | 2190 | struct dso *kernel; |
2182 | 2191 | ||
2183 | if (machine__is_host(self)) { | 2192 | if (machine__is_host(machine)) { |
2184 | vmlinux_name = symbol_conf.vmlinux_name; | 2193 | vmlinux_name = symbol_conf.vmlinux_name; |
2185 | kernel = dso__new_kernel(vmlinux_name); | 2194 | kernel = dso__new_kernel(vmlinux_name); |
2186 | } else { | 2195 | } else { |
2187 | if (machine__is_default_guest(self)) | 2196 | if (machine__is_default_guest(machine)) |
2188 | vmlinux_name = symbol_conf.default_guest_vmlinux_name; | 2197 | vmlinux_name = symbol_conf.default_guest_vmlinux_name; |
2189 | kernel = dso__new_guest_kernel(self, vmlinux_name); | 2198 | kernel = dso__new_guest_kernel(machine, vmlinux_name); |
2190 | } | 2199 | } |
2191 | 2200 | ||
2192 | if (kernel != NULL) { | 2201 | if (kernel != NULL) { |
2193 | dso__read_running_kernel_build_id(kernel, self); | 2202 | dso__read_running_kernel_build_id(kernel, machine); |
2194 | dsos__add(&self->kernel_dsos, kernel); | 2203 | dsos__add(&machine->kernel_dsos, kernel); |
2195 | } | 2204 | } |
2196 | return kernel; | 2205 | return kernel; |
2197 | } | 2206 | } |
@@ -2236,41 +2245,43 @@ static u64 machine__get_kernel_start_addr(struct machine *machine) | |||
2236 | return args.start; | 2245 | return args.start; |
2237 | } | 2246 | } |
2238 | 2247 | ||
2239 | int __machine__create_kernel_maps(struct machine *self, struct dso *kernel) | 2248 | int __machine__create_kernel_maps(struct machine *machine, struct dso *kernel) |
2240 | { | 2249 | { |
2241 | enum map_type type; | 2250 | enum map_type type; |
2242 | u64 start = machine__get_kernel_start_addr(self); | 2251 | u64 start = machine__get_kernel_start_addr(machine); |
2243 | 2252 | ||
2244 | for (type = 0; type < MAP__NR_TYPES; ++type) { | 2253 | for (type = 0; type < MAP__NR_TYPES; ++type) { |
2245 | struct kmap *kmap; | 2254 | struct kmap *kmap; |
2246 | 2255 | ||
2247 | self->vmlinux_maps[type] = map__new2(start, kernel, type); | 2256 | machine->vmlinux_maps[type] = map__new2(start, kernel, type); |
2248 | if (self->vmlinux_maps[type] == NULL) | 2257 | if (machine->vmlinux_maps[type] == NULL) |
2249 | return -1; | 2258 | return -1; |
2250 | 2259 | ||
2251 | self->vmlinux_maps[type]->map_ip = | 2260 | machine->vmlinux_maps[type]->map_ip = |
2252 | self->vmlinux_maps[type]->unmap_ip = identity__map_ip; | 2261 | machine->vmlinux_maps[type]->unmap_ip = |
2253 | 2262 | identity__map_ip; | |
2254 | kmap = map__kmap(self->vmlinux_maps[type]); | 2263 | kmap = map__kmap(machine->vmlinux_maps[type]); |
2255 | kmap->kmaps = &self->kmaps; | 2264 | kmap->kmaps = &machine->kmaps; |
2256 | map_groups__insert(&self->kmaps, self->vmlinux_maps[type]); | 2265 | map_groups__insert(&machine->kmaps, |
2266 | machine->vmlinux_maps[type]); | ||
2257 | } | 2267 | } |
2258 | 2268 | ||
2259 | return 0; | 2269 | return 0; |
2260 | } | 2270 | } |
2261 | 2271 | ||
2262 | void machine__destroy_kernel_maps(struct machine *self) | 2272 | void machine__destroy_kernel_maps(struct machine *machine) |
2263 | { | 2273 | { |
2264 | enum map_type type; | 2274 | enum map_type type; |
2265 | 2275 | ||
2266 | for (type = 0; type < MAP__NR_TYPES; ++type) { | 2276 | for (type = 0; type < MAP__NR_TYPES; ++type) { |
2267 | struct kmap *kmap; | 2277 | struct kmap *kmap; |
2268 | 2278 | ||
2269 | if (self->vmlinux_maps[type] == NULL) | 2279 | if (machine->vmlinux_maps[type] == NULL) |
2270 | continue; | 2280 | continue; |
2271 | 2281 | ||
2272 | kmap = map__kmap(self->vmlinux_maps[type]); | 2282 | kmap = map__kmap(machine->vmlinux_maps[type]); |
2273 | map_groups__remove(&self->kmaps, self->vmlinux_maps[type]); | 2283 | map_groups__remove(&machine->kmaps, |
2284 | machine->vmlinux_maps[type]); | ||
2274 | if (kmap->ref_reloc_sym) { | 2285 | if (kmap->ref_reloc_sym) { |
2275 | /* | 2286 | /* |
2276 | * ref_reloc_sym is shared among all maps, so free just | 2287 | * ref_reloc_sym is shared among all maps, so free just |
@@ -2284,25 +2295,25 @@ void machine__destroy_kernel_maps(struct machine *self) | |||
2284 | kmap->ref_reloc_sym = NULL; | 2295 | kmap->ref_reloc_sym = NULL; |
2285 | } | 2296 | } |
2286 | 2297 | ||
2287 | map__delete(self->vmlinux_maps[type]); | 2298 | map__delete(machine->vmlinux_maps[type]); |
2288 | self->vmlinux_maps[type] = NULL; | 2299 | machine->vmlinux_maps[type] = NULL; |
2289 | } | 2300 | } |
2290 | } | 2301 | } |
2291 | 2302 | ||
2292 | int machine__create_kernel_maps(struct machine *self) | 2303 | int machine__create_kernel_maps(struct machine *machine) |
2293 | { | 2304 | { |
2294 | struct dso *kernel = machine__create_kernel(self); | 2305 | struct dso *kernel = machine__create_kernel(machine); |
2295 | 2306 | ||
2296 | if (kernel == NULL || | 2307 | if (kernel == NULL || |
2297 | __machine__create_kernel_maps(self, kernel) < 0) | 2308 | __machine__create_kernel_maps(machine, kernel) < 0) |
2298 | return -1; | 2309 | return -1; |
2299 | 2310 | ||
2300 | if (symbol_conf.use_modules && machine__create_modules(self) < 0) | 2311 | if (symbol_conf.use_modules && machine__create_modules(machine) < 0) |
2301 | pr_debug("Problems creating module maps, continuing anyway...\n"); | 2312 | pr_debug("Problems creating module maps, continuing anyway...\n"); |
2302 | /* | 2313 | /* |
2303 | * Now that we have all the maps created, just set the ->end of them: | 2314 | * Now that we have all the maps created, just set the ->end of them: |
2304 | */ | 2315 | */ |
2305 | map_groups__fixup_end(&self->kmaps); | 2316 | map_groups__fixup_end(&machine->kmaps); |
2306 | return 0; | 2317 | return 0; |
2307 | } | 2318 | } |
2308 | 2319 | ||
@@ -2366,11 +2377,11 @@ out_fail: | |||
2366 | return -1; | 2377 | return -1; |
2367 | } | 2378 | } |
2368 | 2379 | ||
2369 | size_t machine__fprintf_vmlinux_path(struct machine *self, FILE *fp) | 2380 | size_t machine__fprintf_vmlinux_path(struct machine *machine, FILE *fp) |
2370 | { | 2381 | { |
2371 | int i; | 2382 | int i; |
2372 | size_t printed = 0; | 2383 | size_t printed = 0; |
2373 | struct dso *kdso = self->vmlinux_maps[MAP__FUNCTION]->dso; | 2384 | struct dso *kdso = machine->vmlinux_maps[MAP__FUNCTION]->dso; |
2374 | 2385 | ||
2375 | if (kdso->has_build_id) { | 2386 | if (kdso->has_build_id) { |
2376 | char filename[PATH_MAX]; | 2387 | char filename[PATH_MAX]; |
@@ -2467,9 +2478,9 @@ void symbol__exit(void) | |||
2467 | symbol_conf.initialized = false; | 2478 | symbol_conf.initialized = false; |
2468 | } | 2479 | } |
2469 | 2480 | ||
2470 | int machines__create_kernel_maps(struct rb_root *self, pid_t pid) | 2481 | int machines__create_kernel_maps(struct rb_root *machines, pid_t pid) |
2471 | { | 2482 | { |
2472 | struct machine *machine = machines__findnew(self, pid); | 2483 | struct machine *machine = machines__findnew(machines, pid); |
2473 | 2484 | ||
2474 | if (machine == NULL) | 2485 | if (machine == NULL) |
2475 | return -1; | 2486 | return -1; |
@@ -2520,7 +2531,7 @@ char *strxfrchar(char *s, char from, char to) | |||
2520 | return s; | 2531 | return s; |
2521 | } | 2532 | } |
2522 | 2533 | ||
2523 | int machines__create_guest_kernel_maps(struct rb_root *self) | 2534 | int machines__create_guest_kernel_maps(struct rb_root *machines) |
2524 | { | 2535 | { |
2525 | int ret = 0; | 2536 | int ret = 0; |
2526 | struct dirent **namelist = NULL; | 2537 | struct dirent **namelist = NULL; |
@@ -2531,7 +2542,7 @@ int machines__create_guest_kernel_maps(struct rb_root *self) | |||
2531 | if (symbol_conf.default_guest_vmlinux_name || | 2542 | if (symbol_conf.default_guest_vmlinux_name || |
2532 | symbol_conf.default_guest_modules || | 2543 | symbol_conf.default_guest_modules || |
2533 | symbol_conf.default_guest_kallsyms) { | 2544 | symbol_conf.default_guest_kallsyms) { |
2534 | machines__create_kernel_maps(self, DEFAULT_GUEST_KERNEL_ID); | 2545 | machines__create_kernel_maps(machines, DEFAULT_GUEST_KERNEL_ID); |
2535 | } | 2546 | } |
2536 | 2547 | ||
2537 | if (symbol_conf.guestmount) { | 2548 | if (symbol_conf.guestmount) { |
@@ -2552,7 +2563,7 @@ int machines__create_guest_kernel_maps(struct rb_root *self) | |||
2552 | pr_debug("Can't access file %s\n", path); | 2563 | pr_debug("Can't access file %s\n", path); |
2553 | goto failure; | 2564 | goto failure; |
2554 | } | 2565 | } |
2555 | machines__create_kernel_maps(self, pid); | 2566 | machines__create_kernel_maps(machines, pid); |
2556 | } | 2567 | } |
2557 | failure: | 2568 | failure: |
2558 | free(namelist); | 2569 | free(namelist); |
@@ -2561,23 +2572,23 @@ failure: | |||
2561 | return ret; | 2572 | return ret; |
2562 | } | 2573 | } |
2563 | 2574 | ||
2564 | void machines__destroy_guest_kernel_maps(struct rb_root *self) | 2575 | void machines__destroy_guest_kernel_maps(struct rb_root *machines) |
2565 | { | 2576 | { |
2566 | struct rb_node *next = rb_first(self); | 2577 | struct rb_node *next = rb_first(machines); |
2567 | 2578 | ||
2568 | while (next) { | 2579 | while (next) { |
2569 | struct machine *pos = rb_entry(next, struct machine, rb_node); | 2580 | struct machine *pos = rb_entry(next, struct machine, rb_node); |
2570 | 2581 | ||
2571 | next = rb_next(&pos->rb_node); | 2582 | next = rb_next(&pos->rb_node); |
2572 | rb_erase(&pos->rb_node, self); | 2583 | rb_erase(&pos->rb_node, machines); |
2573 | machine__delete(pos); | 2584 | machine__delete(pos); |
2574 | } | 2585 | } |
2575 | } | 2586 | } |
2576 | 2587 | ||
2577 | int machine__load_kallsyms(struct machine *self, const char *filename, | 2588 | int machine__load_kallsyms(struct machine *machine, const char *filename, |
2578 | enum map_type type, symbol_filter_t filter) | 2589 | enum map_type type, symbol_filter_t filter) |
2579 | { | 2590 | { |
2580 | struct map *map = self->vmlinux_maps[type]; | 2591 | struct map *map = machine->vmlinux_maps[type]; |
2581 | int ret = dso__load_kallsyms(map->dso, filename, map, filter); | 2592 | int ret = dso__load_kallsyms(map->dso, filename, map, filter); |
2582 | 2593 | ||
2583 | if (ret > 0) { | 2594 | if (ret > 0) { |
@@ -2587,16 +2598,16 @@ int machine__load_kallsyms(struct machine *self, const char *filename, | |||
2587 | * kernel, with modules between them, fixup the end of all | 2598 | * kernel, with modules between them, fixup the end of all |
2588 | * sections. | 2599 | * sections. |
2589 | */ | 2600 | */ |
2590 | __map_groups__fixup_end(&self->kmaps, type); | 2601 | __map_groups__fixup_end(&machine->kmaps, type); |
2591 | } | 2602 | } |
2592 | 2603 | ||
2593 | return ret; | 2604 | return ret; |
2594 | } | 2605 | } |
2595 | 2606 | ||
2596 | int machine__load_vmlinux_path(struct machine *self, enum map_type type, | 2607 | int machine__load_vmlinux_path(struct machine *machine, enum map_type type, |
2597 | symbol_filter_t filter) | 2608 | symbol_filter_t filter) |
2598 | { | 2609 | { |
2599 | struct map *map = self->vmlinux_maps[type]; | 2610 | struct map *map = machine->vmlinux_maps[type]; |
2600 | int ret = dso__load_vmlinux_path(map->dso, map, filter); | 2611 | int ret = dso__load_vmlinux_path(map->dso, map, filter); |
2601 | 2612 | ||
2602 | if (ret > 0) { | 2613 | if (ret > 0) { |
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 713b0b40cc4a..242de0101a86 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
@@ -62,7 +62,7 @@ struct symbol { | |||
62 | char name[0]; | 62 | char name[0]; |
63 | }; | 63 | }; |
64 | 64 | ||
65 | void symbol__delete(struct symbol *self); | 65 | void symbol__delete(struct symbol *sym); |
66 | 66 | ||
67 | struct strlist; | 67 | struct strlist; |
68 | 68 | ||
@@ -96,9 +96,9 @@ struct symbol_conf { | |||
96 | 96 | ||
97 | extern struct symbol_conf symbol_conf; | 97 | extern struct symbol_conf symbol_conf; |
98 | 98 | ||
99 | static inline void *symbol__priv(struct symbol *self) | 99 | static inline void *symbol__priv(struct symbol *sym) |
100 | { | 100 | { |
101 | return ((void *)self) - symbol_conf.priv_size; | 101 | return ((void *)sym) - symbol_conf.priv_size; |
102 | } | 102 | } |
103 | 103 | ||
104 | struct ref_reloc_sym { | 104 | struct ref_reloc_sym { |
@@ -155,43 +155,45 @@ struct dso { | |||
155 | 155 | ||
156 | struct dso *dso__new(const char *name); | 156 | struct dso *dso__new(const char *name); |
157 | struct dso *dso__new_kernel(const char *name); | 157 | struct dso *dso__new_kernel(const char *name); |
158 | void dso__delete(struct dso *self); | 158 | void dso__delete(struct dso *dso); |
159 | 159 | ||
160 | int dso__name_len(const struct dso *self); | 160 | int dso__name_len(const struct dso *dso); |
161 | 161 | ||
162 | bool dso__loaded(const struct dso *self, enum map_type type); | 162 | bool dso__loaded(const struct dso *dso, enum map_type type); |
163 | bool dso__sorted_by_name(const struct dso *self, enum map_type type); | 163 | bool dso__sorted_by_name(const struct dso *dso, enum map_type type); |
164 | 164 | ||
165 | static inline void dso__set_loaded(struct dso *self, enum map_type type) | 165 | static inline void dso__set_loaded(struct dso *dso, enum map_type type) |
166 | { | 166 | { |
167 | self->loaded |= (1 << type); | 167 | dso->loaded |= (1 << type); |
168 | } | 168 | } |
169 | 169 | ||
170 | void dso__sort_by_name(struct dso *self, enum map_type type); | 170 | void dso__sort_by_name(struct dso *dso, enum map_type type); |
171 | 171 | ||
172 | struct dso *__dsos__findnew(struct list_head *head, const char *name); | 172 | struct dso *__dsos__findnew(struct list_head *head, const char *name); |
173 | 173 | ||
174 | int dso__load(struct dso *self, struct map *map, symbol_filter_t filter); | 174 | int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter); |
175 | int dso__load_vmlinux(struct dso *self, struct map *map, | 175 | int dso__load_vmlinux(struct dso *dso, struct map *map, |
176 | const char *vmlinux, symbol_filter_t filter); | 176 | const char *vmlinux, symbol_filter_t filter); |
177 | int dso__load_vmlinux_path(struct dso *self, struct map *map, | 177 | int dso__load_vmlinux_path(struct dso *dso, struct map *map, |
178 | symbol_filter_t filter); | 178 | symbol_filter_t filter); |
179 | int dso__load_kallsyms(struct dso *self, const char *filename, struct map *map, | 179 | int dso__load_kallsyms(struct dso *dso, const char *filename, struct map *map, |
180 | symbol_filter_t filter); | 180 | symbol_filter_t filter); |
181 | int machine__load_kallsyms(struct machine *self, const char *filename, | 181 | int machine__load_kallsyms(struct machine *machine, const char *filename, |
182 | enum map_type type, symbol_filter_t filter); | 182 | enum map_type type, symbol_filter_t filter); |
183 | int machine__load_vmlinux_path(struct machine *self, enum map_type type, | 183 | int machine__load_vmlinux_path(struct machine *machine, enum map_type type, |
184 | symbol_filter_t filter); | 184 | symbol_filter_t filter); |
185 | 185 | ||
186 | size_t __dsos__fprintf(struct list_head *head, FILE *fp); | 186 | size_t __dsos__fprintf(struct list_head *head, FILE *fp); |
187 | 187 | ||
188 | size_t machine__fprintf_dsos_buildid(struct machine *self, FILE *fp, bool with_hits); | 188 | size_t machine__fprintf_dsos_buildid(struct machine *machine, |
189 | size_t machines__fprintf_dsos(struct rb_root *self, FILE *fp); | 189 | FILE *fp, bool with_hits); |
190 | size_t machines__fprintf_dsos_buildid(struct rb_root *self, FILE *fp, bool with_hits); | 190 | size_t machines__fprintf_dsos(struct rb_root *machines, FILE *fp); |
191 | 191 | size_t machines__fprintf_dsos_buildid(struct rb_root *machines, | |
192 | size_t dso__fprintf_buildid(struct dso *self, FILE *fp); | 192 | FILE *fp, bool with_hits); |
193 | size_t dso__fprintf_symbols_by_name(struct dso *self, enum map_type type, FILE *fp); | 193 | size_t dso__fprintf_buildid(struct dso *dso, FILE *fp); |
194 | size_t dso__fprintf(struct dso *self, enum map_type type, FILE *fp); | 194 | size_t dso__fprintf_symbols_by_name(struct dso *dso, |
195 | enum map_type type, FILE *fp); | ||
196 | size_t dso__fprintf(struct dso *dso, enum map_type type, FILE *fp); | ||
195 | 197 | ||
196 | enum symtab_type { | 198 | enum symtab_type { |
197 | SYMTAB__KALLSYMS = 0, | 199 | SYMTAB__KALLSYMS = 0, |
@@ -207,34 +209,36 @@ enum symtab_type { | |||
207 | SYMTAB__NOT_FOUND, | 209 | SYMTAB__NOT_FOUND, |
208 | }; | 210 | }; |
209 | 211 | ||
210 | char dso__symtab_origin(const struct dso *self); | 212 | char dso__symtab_origin(const struct dso *dso); |
211 | void dso__set_long_name(struct dso *self, char *name); | 213 | void dso__set_long_name(struct dso *dso, char *name); |
212 | void dso__set_build_id(struct dso *self, void *build_id); | 214 | void dso__set_build_id(struct dso *dso, void *build_id); |
213 | void dso__read_running_kernel_build_id(struct dso *self, struct machine *machine); | 215 | void dso__read_running_kernel_build_id(struct dso *dso, |
214 | struct symbol *dso__find_symbol(struct dso *self, enum map_type type, u64 addr); | 216 | struct machine *machine); |
215 | struct symbol *dso__find_symbol_by_name(struct dso *self, enum map_type type, | 217 | struct symbol *dso__find_symbol(struct dso *dso, enum map_type type, |
218 | u64 addr); | ||
219 | struct symbol *dso__find_symbol_by_name(struct dso *dso, enum map_type type, | ||
216 | const char *name); | 220 | const char *name); |
217 | 221 | ||
218 | int filename__read_build_id(const char *filename, void *bf, size_t size); | 222 | int filename__read_build_id(const char *filename, void *bf, size_t size); |
219 | int sysfs__read_build_id(const char *filename, void *bf, size_t size); | 223 | int sysfs__read_build_id(const char *filename, void *bf, size_t size); |
220 | bool __dsos__read_build_ids(struct list_head *head, bool with_hits); | 224 | bool __dsos__read_build_ids(struct list_head *head, bool with_hits); |
221 | int build_id__sprintf(const u8 *self, int len, char *bf); | 225 | int build_id__sprintf(const u8 *build_id, int len, char *bf); |
222 | int kallsyms__parse(const char *filename, void *arg, | 226 | int kallsyms__parse(const char *filename, void *arg, |
223 | int (*process_symbol)(void *arg, const char *name, | 227 | int (*process_symbol)(void *arg, const char *name, |
224 | char type, u64 start, u64 end)); | 228 | char type, u64 start, u64 end)); |
225 | 229 | ||
226 | void machine__destroy_kernel_maps(struct machine *self); | 230 | void machine__destroy_kernel_maps(struct machine *machine); |
227 | int __machine__create_kernel_maps(struct machine *self, struct dso *kernel); | 231 | int __machine__create_kernel_maps(struct machine *machine, struct dso *kernel); |
228 | int machine__create_kernel_maps(struct machine *self); | 232 | int machine__create_kernel_maps(struct machine *machine); |
229 | 233 | ||
230 | int machines__create_kernel_maps(struct rb_root *self, pid_t pid); | 234 | int machines__create_kernel_maps(struct rb_root *machines, pid_t pid); |
231 | int machines__create_guest_kernel_maps(struct rb_root *self); | 235 | int machines__create_guest_kernel_maps(struct rb_root *machines); |
232 | void machines__destroy_guest_kernel_maps(struct rb_root *self); | 236 | void machines__destroy_guest_kernel_maps(struct rb_root *machines); |
233 | 237 | ||
234 | int symbol__init(void); | 238 | int symbol__init(void); |
235 | void symbol__exit(void); | 239 | void symbol__exit(void); |
236 | bool symbol_type__is_a(char symbol_type, enum map_type map_type); | 240 | bool symbol_type__is_a(char symbol_type, enum map_type map_type); |
237 | 241 | ||
238 | size_t machine__fprintf_vmlinux_path(struct machine *self, FILE *fp); | 242 | size_t machine__fprintf_vmlinux_path(struct machine *machine, FILE *fp); |
239 | 243 | ||
240 | #endif /* __PERF_SYMBOL */ | 244 | #endif /* __PERF_SYMBOL */ |