diff options
author | Cody P Schafer <cody@linux.vnet.ibm.com> | 2012-08-10 18:23:00 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-08-13 13:37:37 -0400 |
commit | d26cd12b46cb6b5595143804b43ba5aa7968551e (patch) | |
tree | 80a2c383f5b3d06d17692d65abd734102e37b8b3 /tools/perf/util/symbol.h | |
parent | a44f605b2f6eadb771a052aa3a5eefb342b38a39 (diff) |
perf symbols: Factor want_symtab out of dso__load_sym()
Only one callsite of dso__load_sym() uses the want_symtab functionality,
so place the logic at the callsite instead of within dso__load_sym().
This sets us up for removal of want_symtab completely once we keep
multiple elf handles (within symsrc's) around.
Setup for the later patch
"perf symbols: Use both runtime and debug images"
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Hellsley <matthltc@us.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1344637382-22789-15-git-send-email-cody@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/symbol.h')
-rw-r--r-- | tools/perf/util/symbol.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 2981513ce1d4..fa9f6b1cdc46 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
@@ -252,6 +252,7 @@ struct symsrc { | |||
252 | void symsrc__destroy(struct symsrc *ss); | 252 | void symsrc__destroy(struct symsrc *ss); |
253 | int symsrc__init(struct symsrc *ss, struct dso *dso, const char *name, | 253 | int symsrc__init(struct symsrc *ss, struct dso *dso, const char *name, |
254 | enum dso_binary_type type); | 254 | enum dso_binary_type type); |
255 | bool symsrc__has_symtab(struct symsrc *ss); | ||
255 | 256 | ||
256 | #define DSO__SWAP(dso, type, val) \ | 257 | #define DSO__SWAP(dso, type, val) \ |
257 | ({ \ | 258 | ({ \ |
@@ -369,7 +370,7 @@ ssize_t dso__data_read_addr(struct dso *dso, struct map *map, | |||
369 | u8 *data, ssize_t size); | 370 | u8 *data, ssize_t size); |
370 | int dso__test_data(void); | 371 | int dso__test_data(void); |
371 | int dso__load_sym(struct dso *dso, struct map *map, struct symsrc *ss, | 372 | int dso__load_sym(struct dso *dso, struct map *map, struct symsrc *ss, |
372 | symbol_filter_t filter, int kmodule, int want_symtab); | 373 | symbol_filter_t filter, int kmodule); |
373 | int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss, | 374 | int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss, |
374 | struct map *map, symbol_filter_t filter); | 375 | struct map *map, symbol_filter_t filter); |
375 | 376 | ||