diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-02 17:18:28 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-02 17:18:28 -0400 |
commit | 076c6e45215aea0de1ed34d3d5079fabeaabf5e1 (patch) | |
tree | a07e78f58e625eb69dfda8f32ab46e5316551025 /tools/perf/util/symbol.h | |
parent | 3772b734720e1a3f2dc1d95cfdfaa5332f4ccf01 (diff) |
perf session: Free the ref_reloc_sym memory at the right place
Which is at perf_session__destroy_kernel_maps, counterpart to the
perf_session__create_kernel_maps where the kmap structure is located, just
after the vmlinux_maps.
Make it also check if the kernel maps were actually created, which may not
be the case if, for instance, perf_session__new can't complete due to
permission problems in, for instance, a 'perf report' case, when a
segfault will take place, that is how this was noticed.
The problem was introduced in d65a458, thus post .35.
This also adds code to release guest machines as them are also created
in perf_session__create_kernel_maps, so should be deleted on this newly
introduced counterpart, perf_session__destroy_kernel_maps.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/symbol.h')
-rw-r--r-- | tools/perf/util/symbol.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 33d53ce28958..906be20011d9 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
@@ -212,11 +212,13 @@ int kallsyms__parse(const char *filename, void *arg, | |||
212 | int (*process_symbol)(void *arg, const char *name, | 212 | int (*process_symbol)(void *arg, const char *name, |
213 | char type, u64 start)); | 213 | char type, u64 start)); |
214 | 214 | ||
215 | void machine__destroy_kernel_maps(struct machine *self); | ||
215 | int __machine__create_kernel_maps(struct machine *self, struct dso *kernel); | 216 | int __machine__create_kernel_maps(struct machine *self, struct dso *kernel); |
216 | int machine__create_kernel_maps(struct machine *self); | 217 | int machine__create_kernel_maps(struct machine *self); |
217 | 218 | ||
218 | int machines__create_kernel_maps(struct rb_root *self, pid_t pid); | 219 | int machines__create_kernel_maps(struct rb_root *self, pid_t pid); |
219 | int machines__create_guest_kernel_maps(struct rb_root *self); | 220 | int machines__create_guest_kernel_maps(struct rb_root *self); |
221 | void machines__destroy_guest_kernel_maps(struct rb_root *self); | ||
220 | 222 | ||
221 | int symbol__init(void); | 223 | int symbol__init(void); |
222 | void symbol__exit(void); | 224 | void symbol__exit(void); |