diff options
author | Arnaldo Carvalho de Melo <acme@infradead.org> | 2010-02-25 10:57:40 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-02-25 11:39:14 -0500 |
commit | 628ada0cb03666dd463f7c25947eaccdf440c309 (patch) | |
tree | 2338cf888ccecb1bb9df32031cef43f527b05ca0 /tools/perf/util/symbol.h | |
parent | 3846df2e0a99a2bf10023de0e9c1496592012d4c (diff) |
perf annotate: Defer allocating sym_priv->hist array
Because symbol->end is not fixed up at symbol_filter time, only
after all symbols for a DSO are loaded, and that, for asm
symbols, may be bogus, causing segfaults when hits happen in
these symbols.
Reported-by: David Miller <davem@davemloft.net>
Reported-by: Anton Blanchard <anton@samba.org>
Acked-by: David Miller <davem@davemloft.net>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: <stable@kernel.org> # for .33.x. Does not apply cleanly, needs backport.
LKML-Reference: <20100225155740.GB8553@ghostprotocols.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/util/symbol.h')
-rw-r--r-- | tools/perf/util/symbol.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 1b4192ee5300..280dadd32a08 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
@@ -51,6 +51,8 @@ struct symbol { | |||
51 | char name[0]; | 51 | char name[0]; |
52 | }; | 52 | }; |
53 | 53 | ||
54 | void symbol__delete(struct symbol *self); | ||
55 | |||
54 | struct strlist; | 56 | struct strlist; |
55 | 57 | ||
56 | struct symbol_conf { | 58 | struct symbol_conf { |