diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-03-15 12:04:33 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-03-15 12:16:25 -0400 |
commit | d06d92b7c9b99ea52bdaeb13f544675529891b8a (patch) | |
tree | eb8bb2979883cecd6af007cab9e10dc83a0dfd3a /tools/perf/util/symbol.h | |
parent | b0a9ab62ab96e258a0ddd81d7fe2719c3db36006 (diff) |
perf annotate: Properly notify the user that vmlinux is missing
Before this patch we would not find a vmlinux, then try to pass
objdump "[kernel.kallsyms]" as the filename, it would get
confused and produce no output:
[root@doppio ~]# perf annotate n_tty_write
------------------------------------------------
Percent | Source code & Disassembly of [kernel.kallsyms]
------------------------------------------------
Now we check that and emit meaningful warning:
[root@doppio ~]# perf annotate n_tty_write
Can't annotate n_tty_write: No vmlinux file was found in the
path: [0] vmlinux
[1] /boot/vmlinux
[2] /boot/vmlinux-2.6.34-rc1-tip+
[3] /lib/modules/2.6.34-rc1-tip+/build/vmlinux
[4] /usr/lib/debug/lib/modules/2.6.34-rc1-tip+/vmlinux
[root@doppio ~]#
This bug was introduced when we added automatic search for
vmlinux, before that time the user had to specify a vmlinux
file.
v2: Print the warning just for the first symbol found when no
symbol name is specified, otherwise it will spam the screen
repeating the warning for each symbol.
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: <stable@kernel.org>
LKML-Reference: <1268669073-6856-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/util/symbol.h')
-rw-r--r-- | tools/perf/util/symbol.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index d983bbaf99c5..5bd91d142704 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
@@ -106,6 +106,7 @@ struct dso { | |||
106 | u8 has_build_id:1; | 106 | u8 has_build_id:1; |
107 | u8 kernel:1; | 107 | u8 kernel:1; |
108 | u8 hit:1; | 108 | u8 hit:1; |
109 | u8 annotate_warned:1; | ||
109 | unsigned char origin; | 110 | unsigned char origin; |
110 | u8 sorted_by_name; | 111 | u8 sorted_by_name; |
111 | u8 loaded; | 112 | u8 loaded; |