diff options
author | Srikar Dronamraju <srikar@linux.vnet.ibm.com> | 2012-01-20 07:13:54 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-01-24 17:31:02 -0500 |
commit | a844d1ef09872a8b8c66d431edd1b8a943e51c7a (patch) | |
tree | ff5f0b20f08c7b791a2c10d8a75ba4c64300feba /tools/perf/util/probe-event.c | |
parent | 2ef1ea3826434bdebe17b2941356a8f764ff5fcd (diff) |
perf probe: Usability fixes
Ingo pointed out few perf probe usability related errors during his
review of uprobes.
Since these issues are independent of uprobes, fixing them in a separate
patch.
Suggested-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Link: http://lkml.kernel.org/r/20120120121354.GL15447@linux.vnet.ibm.com
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/probe-event.c')
-rw-r--r-- | tools/perf/util/probe-event.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 29cb65459811..b9bbdd236357 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c | |||
@@ -1729,7 +1729,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev, | |||
1729 | } | 1729 | } |
1730 | 1730 | ||
1731 | ret = 0; | 1731 | ret = 0; |
1732 | printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":"); | 1732 | printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":"); |
1733 | for (i = 0; i < ntevs; i++) { | 1733 | for (i = 0; i < ntevs; i++) { |
1734 | tev = &tevs[i]; | 1734 | tev = &tevs[i]; |
1735 | if (pev->event) | 1735 | if (pev->event) |
@@ -1784,7 +1784,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev, | |||
1784 | 1784 | ||
1785 | if (ret >= 0) { | 1785 | if (ret >= 0) { |
1786 | /* Show how to use the event. */ | 1786 | /* Show how to use the event. */ |
1787 | printf("\nYou can now use it on all perf tools, such as:\n\n"); | 1787 | printf("\nYou can now use it in all perf tools, such as:\n\n"); |
1788 | printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group, | 1788 | printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group, |
1789 | tev->event); | 1789 | tev->event); |
1790 | } | 1790 | } |
@@ -1959,7 +1959,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent) | |||
1959 | goto error; | 1959 | goto error; |
1960 | } | 1960 | } |
1961 | 1961 | ||
1962 | printf("Remove event: %s\n", ent->s); | 1962 | printf("Removed event: %s\n", ent->s); |
1963 | return 0; | 1963 | return 0; |
1964 | error: | 1964 | error: |
1965 | pr_warning("Failed to delete event: %s\n", strerror(-ret)); | 1965 | pr_warning("Failed to delete event: %s\n", strerror(-ret)); |