diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-05-17 15:22:41 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-05-17 15:22:41 -0400 |
commit | edb7c60e27c1baff38d82440dc52eaffac9a45f4 (patch) | |
tree | fc49d1f862fd5f1393c8b6245d571d97b208d91a /tools/perf/util/parse-options.c | |
parent | 8035458fbb567ae138c77a5f710050107c6a7066 (diff) |
perf options: Type check all the remaining OPT_ variants
OPT_SET_INT was renamed to OPT_SET_UINT since the only use in these
tools is to set something that has an enum type, that is builtin
compatible with unsigned int.
Several string constifications were done to make OPT_STRING require a
const char * type.
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/parse-options.c')
-rw-r--r-- | tools/perf/util/parse-options.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/tools/perf/util/parse-options.c b/tools/perf/util/parse-options.c index 36d955e49422..99d02aa57dbf 100644 --- a/tools/perf/util/parse-options.c +++ b/tools/perf/util/parse-options.c | |||
@@ -51,7 +51,7 @@ static int get_value(struct parse_opt_ctx_t *p, | |||
51 | case OPTION_BOOLEAN: | 51 | case OPTION_BOOLEAN: |
52 | case OPTION_INCR: | 52 | case OPTION_INCR: |
53 | case OPTION_BIT: | 53 | case OPTION_BIT: |
54 | case OPTION_SET_INT: | 54 | case OPTION_SET_UINT: |
55 | case OPTION_SET_PTR: | 55 | case OPTION_SET_PTR: |
56 | return opterror(opt, "takes no value", flags); | 56 | return opterror(opt, "takes no value", flags); |
57 | case OPTION_END: | 57 | case OPTION_END: |
@@ -83,8 +83,8 @@ static int get_value(struct parse_opt_ctx_t *p, | |||
83 | *(int *)opt->value = unset ? 0 : *(int *)opt->value + 1; | 83 | *(int *)opt->value = unset ? 0 : *(int *)opt->value + 1; |
84 | return 0; | 84 | return 0; |
85 | 85 | ||
86 | case OPTION_SET_INT: | 86 | case OPTION_SET_UINT: |
87 | *(int *)opt->value = unset ? 0 : opt->defval; | 87 | *(unsigned int *)opt->value = unset ? 0 : opt->defval; |
88 | return 0; | 88 | return 0; |
89 | 89 | ||
90 | case OPTION_SET_PTR: | 90 | case OPTION_SET_PTR: |
@@ -515,13 +515,13 @@ int usage_with_options_internal(const char * const *usagestr, | |||
515 | pos += fprintf(stderr, " ..."); | 515 | pos += fprintf(stderr, " ..."); |
516 | } | 516 | } |
517 | break; | 517 | break; |
518 | default: /* OPTION_{BIT,BOOLEAN,SET_INT,SET_PTR} */ | 518 | default: /* OPTION_{BIT,BOOLEAN,SET_UINT,SET_PTR} */ |
519 | case OPTION_END: | 519 | case OPTION_END: |
520 | case OPTION_GROUP: | 520 | case OPTION_GROUP: |
521 | case OPTION_BIT: | 521 | case OPTION_BIT: |
522 | case OPTION_BOOLEAN: | 522 | case OPTION_BOOLEAN: |
523 | case OPTION_INCR: | 523 | case OPTION_INCR: |
524 | case OPTION_SET_INT: | 524 | case OPTION_SET_UINT: |
525 | case OPTION_SET_PTR: | 525 | case OPTION_SET_PTR: |
526 | break; | 526 | break; |
527 | } | 527 | } |