aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util/newt.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2010-05-14 12:16:55 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2010-05-14 12:16:55 -0400
commitcee75ac7ecc27084accdb9d9d6fde65a09f047ae (patch)
tree686208e18b1ab5356658980ee92c96486384412e /tools/perf/util/newt.c
parentc8446b9bdabcb0caa61bb341bd73c58f7104b503 (diff)
perf hist: Clarify events_stats fields usage
The events_stats.total field is too generic, rename it to .total_period, and also add a comment explaining that it is the sum of all the .period fields in samples, that is needed because we use auto-freq to avoid sampling artifacts. Ditto for events_stats.lost, that is the sum of all lost_event.lost fields, i.e. the number of events the kernel dropped. Looking at the users, builtin-sched.c can make use of these fields and stop doing it again. Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Tom Zanussi <tzanussi@gmail.com> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/newt.c')
-rw-r--r--tools/perf/util/newt.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c
index ba6acd04c082..010bacf40163 100644
--- a/tools/perf/util/newt.c
+++ b/tools/perf/util/newt.c
@@ -689,7 +689,7 @@ static int hist_browser__populate(struct hist_browser *self, struct hists *hists
689 } 689 }
690 690
691 snprintf(str, sizeof(str), "Samples: %Ld ", 691 snprintf(str, sizeof(str), "Samples: %Ld ",
692 hists->stats.total); 692 hists->stats.total_period);
693 newtDrawRootText(0, 0, str); 693 newtDrawRootText(0, 0, str);
694 694
695 newtGetScreenSize(NULL, &rows); 695 newtGetScreenSize(NULL, &rows);
@@ -718,12 +718,12 @@ static int hist_browser__populate(struct hist_browser *self, struct hists *hists
718 if (h->filtered) 718 if (h->filtered)
719 continue; 719 continue;
720 720
721 len = hist_entry__append_browser(h, self->tree, hists->stats.total); 721 len = hist_entry__append_browser(h, self->tree, hists->stats.total_period);
722 if (len > max_len) 722 if (len > max_len)
723 max_len = len; 723 max_len = len;
724 if (symbol_conf.use_callchain) 724 if (symbol_conf.use_callchain)
725 hist_entry__append_callchain_browser(h, self->tree, 725 hist_entry__append_callchain_browser(h, self->tree,
726 hists->stats.total, idx++); 726 hists->stats.total_period, idx++);
727 ++curr_hist; 727 ++curr_hist;
728 if (curr_hist % 5) 728 if (curr_hist % 5)
729 ui_progress__update(progress, curr_hist); 729 ui_progress__update(progress, curr_hist);