diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-10-21 15:34:06 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-10-23 02:22:47 -0400 |
commit | 6beba7adbe092e63dfe8d09fbd1e3ec140474a13 (patch) | |
tree | d45a3347de224513c6d3d0e1061b78641f9aaf8a /tools/perf/util/map.c | |
parent | 802da5f2289bbe363acef084805195c11f453c48 (diff) |
perf tools: Unify debug messages mechanisms
We were using eprintf in some places, that looks at a global
'verbose' level, and at other places passing a 'v' parameter to
specify the verbosity level, unify it by introducing
pr_{err,warning,debug,etc}, just like in the kernel.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256153646-10097-1-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/util/map.c')
-rw-r--r-- | tools/perf/util/map.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c index 55079c0200e0..c1c556825343 100644 --- a/tools/perf/util/map.c +++ b/tools/perf/util/map.c | |||
@@ -21,8 +21,7 @@ static int strcommon(const char *pathname, char *cwd, int cwdlen) | |||
21 | } | 21 | } |
22 | 22 | ||
23 | struct map *map__new(struct mmap_event *event, char *cwd, int cwdlen, | 23 | struct map *map__new(struct mmap_event *event, char *cwd, int cwdlen, |
24 | unsigned int sym_priv_size, symbol_filter_t filter, | 24 | unsigned int sym_priv_size, symbol_filter_t filter) |
25 | int v) | ||
26 | { | 25 | { |
27 | struct map *self = malloc(sizeof(*self)); | 26 | struct map *self = malloc(sizeof(*self)); |
28 | 27 | ||
@@ -58,16 +57,16 @@ struct map *map__new(struct mmap_event *event, char *cwd, int cwdlen, | |||
58 | goto out_delete; | 57 | goto out_delete; |
59 | 58 | ||
60 | if (new_dso) { | 59 | if (new_dso) { |
61 | int nr = dso__load(self->dso, self, filter, v); | 60 | int nr = dso__load(self->dso, self, filter); |
62 | 61 | ||
63 | if (nr < 0) | 62 | if (nr < 0) |
64 | eprintf("Failed to open %s, continuing " | 63 | pr_warning("Failed to open %s, continuing " |
65 | "without symbols\n", | 64 | "without symbols\n", |
66 | self->dso->long_name); | 65 | self->dso->long_name); |
67 | else if (nr == 0) | 66 | else if (nr == 0) |
68 | eprintf("No symbols found in %s, maybe " | 67 | pr_warning("No symbols found in %s, maybe " |
69 | "install a debug package?\n", | 68 | "install a debug package?\n", |
70 | self->dso->long_name); | 69 | self->dso->long_name); |
71 | } | 70 | } |
72 | 71 | ||
73 | if (self->dso == vdso || anon) | 72 | if (self->dso == vdso || anon) |