aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util/hist.c
diff options
context:
space:
mode:
authorJiri Olsa <jolsa@redhat.com>2012-03-22 09:37:26 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-03-22 14:12:09 -0400
commit4bf9ce1b5ecffffeb8b9d7e925bac3e6b10109aa (patch)
tree6405f45496261cbc233d8b4c1870bb05c647d966 /tools/perf/util/hist.c
parent5d7be90ed5cfb5dd3c9ab726d7daa91b86b81747 (diff)
perf diff: Fix to work with new hists design
The perf diff command is broken since: perf hists: Threaded addition and sorting of entries commit 1980c2ebd7020d82c024b8c4046849b38e78e7da Several places were broken: - hists data need to be collected into opened sessions instead of into events - session's hists data need to be initialized properly when the session is created - hist_entry__pcnt_snprintf: the percentage and displacement buffer preparation must not use 'ret' because it's used as a pointer to the final buffer Signed-off-by: Jiri Olsa <jolsa@redhat.com> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20120322133726.GB1601@m.brq.redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/hist.c')
-rw-r--r--tools/perf/util/hist.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 5fb19013ca0c..c61235f81260 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -891,9 +891,9 @@ static int hist_entry__pcnt_snprintf(struct hist_entry *he, char *s,
891 diff = new_percent - old_percent; 891 diff = new_percent - old_percent;
892 892
893 if (fabs(diff) >= 0.01) 893 if (fabs(diff) >= 0.01)
894 ret += scnprintf(bf, sizeof(bf), "%+4.2F%%", diff); 894 scnprintf(bf, sizeof(bf), "%+4.2F%%", diff);
895 else 895 else
896 ret += scnprintf(bf, sizeof(bf), " "); 896 scnprintf(bf, sizeof(bf), " ");
897 897
898 if (sep) 898 if (sep)
899 ret += scnprintf(s + ret, size - ret, "%c%s", *sep, bf); 899 ret += scnprintf(s + ret, size - ret, "%c%s", *sep, bf);
@@ -902,9 +902,9 @@ static int hist_entry__pcnt_snprintf(struct hist_entry *he, char *s,
902 902
903 if (show_displacement) { 903 if (show_displacement) {
904 if (displacement) 904 if (displacement)
905 ret += scnprintf(bf, sizeof(bf), "%+4ld", displacement); 905 scnprintf(bf, sizeof(bf), "%+4ld", displacement);
906 else 906 else
907 ret += scnprintf(bf, sizeof(bf), " "); 907 scnprintf(bf, sizeof(bf), " ");
908 908
909 if (sep) 909 if (sep)
910 ret += scnprintf(s + ret, size - ret, "%c%s", *sep, bf); 910 ret += scnprintf(s + ret, size - ret, "%c%s", *sep, bf);