diff options
author | Jiri Olsa <jolsa@redhat.com> | 2013-07-11 11:28:31 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-07-15 15:28:10 -0400 |
commit | 44b3c57802b7557d0e2d8c3bd39bce942e9324cc (patch) | |
tree | be43f34d893aeae93dd3e17475c7d5a32986f947 /tools/perf/util/header.c | |
parent | 5936678e7da5f8d2944a2ad45d66c88b4a7ccb67 (diff) |
perf tools: Remove event types from perf data file
Removing event types data storing/reading to/from perf data file as it's
no longer needed. The only user of this data 'perf timechart' was
switched to use tracepoints handler callbacks.
The event_types offset and size stay in the perf data file header but
are ignored from now on.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1373556513-3000-4-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/header.c')
-rw-r--r-- | tools/perf/util/header.c | 28 |
1 files changed, 1 insertions, 27 deletions
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index d12d79cf8d32..88626678bfc4 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c | |||
@@ -2334,16 +2334,6 @@ int perf_session__write_header(struct perf_session *session, | |||
2334 | } | 2334 | } |
2335 | } | 2335 | } |
2336 | 2336 | ||
2337 | header->event_offset = lseek(fd, 0, SEEK_CUR); | ||
2338 | header->event_size = trace_event_count * sizeof(struct perf_trace_event_type); | ||
2339 | if (trace_events) { | ||
2340 | err = do_write(fd, trace_events, header->event_size); | ||
2341 | if (err < 0) { | ||
2342 | pr_debug("failed to write perf header events\n"); | ||
2343 | return err; | ||
2344 | } | ||
2345 | } | ||
2346 | |||
2347 | header->data_offset = lseek(fd, 0, SEEK_CUR); | 2337 | header->data_offset = lseek(fd, 0, SEEK_CUR); |
2348 | 2338 | ||
2349 | if (at_exit) { | 2339 | if (at_exit) { |
@@ -2364,10 +2354,7 @@ int perf_session__write_header(struct perf_session *session, | |||
2364 | .offset = header->data_offset, | 2354 | .offset = header->data_offset, |
2365 | .size = header->data_size, | 2355 | .size = header->data_size, |
2366 | }, | 2356 | }, |
2367 | .event_types = { | 2357 | /* event_types is ignored, store zeros */ |
2368 | .offset = header->event_offset, | ||
2369 | .size = header->event_size, | ||
2370 | }, | ||
2371 | }; | 2358 | }; |
2372 | 2359 | ||
2373 | memcpy(&f_header.adds_features, &header->adds_features, sizeof(header->adds_features)); | 2360 | memcpy(&f_header.adds_features, &header->adds_features, sizeof(header->adds_features)); |
@@ -2614,8 +2601,6 @@ int perf_file_header__read(struct perf_file_header *header, | |||
2614 | memcpy(&ph->adds_features, &header->adds_features, | 2601 | memcpy(&ph->adds_features, &header->adds_features, |
2615 | sizeof(ph->adds_features)); | 2602 | sizeof(ph->adds_features)); |
2616 | 2603 | ||
2617 | ph->event_offset = header->event_types.offset; | ||
2618 | ph->event_size = header->event_types.size; | ||
2619 | ph->data_offset = header->data.offset; | 2604 | ph->data_offset = header->data.offset; |
2620 | ph->data_size = header->data.size; | 2605 | ph->data_size = header->data.size; |
2621 | return 0; | 2606 | return 0; |
@@ -2839,17 +2824,6 @@ int perf_session__read_header(struct perf_session *session, int fd) | |||
2839 | 2824 | ||
2840 | symbol_conf.nr_events = nr_attrs; | 2825 | symbol_conf.nr_events = nr_attrs; |
2841 | 2826 | ||
2842 | if (f_header.event_types.size) { | ||
2843 | lseek(fd, f_header.event_types.offset, SEEK_SET); | ||
2844 | trace_events = malloc(f_header.event_types.size); | ||
2845 | if (trace_events == NULL) | ||
2846 | return -ENOMEM; | ||
2847 | if (perf_header__getbuffer64(header, fd, trace_events, | ||
2848 | f_header.event_types.size)) | ||
2849 | goto out_errno; | ||
2850 | trace_event_count = f_header.event_types.size / sizeof(struct perf_trace_event_type); | ||
2851 | } | ||
2852 | |||
2853 | perf_header__process_sections(header, fd, &session->pevent, | 2827 | perf_header__process_sections(header, fd, &session->pevent, |
2854 | perf_file_section__process); | 2828 | perf_file_section__process); |
2855 | 2829 | ||