Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core

Pull perf improvements from Arnaldo Carvalho de Melo:

 * Replace event_name with perf_evsel__name, that handles the event
   modifiers and doesn't use static variables.

 * GTK browser improvements, from Namhyung Kim

 * Fix possible NULL pointer deref in the TUI annotate browser, from
   Samuel Liao

 * Add sort by source file:line number, using addr2line.

 * Allow printing histogram text snapshots at any point in top/report.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

1 files changed, 169 insertions, 27 deletions

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 9f6cebd798ee..876f639d69ed 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -78,7 +78,7 @@ static const char *perf_evsel__hw_names[PERF_COUNT_HW_MAX] = {
         "ref-cycles",
 };
 
-const char *__perf_evsel__hw_name(u64 config)
+static const char *__perf_evsel__hw_name(u64 config)
 {
         if (config < PERF_COUNT_HW_MAX && perf_evsel__hw_names[config])
                 return perf_evsel__hw_names[config];
@@ -86,16 +86,15 @@ const char *__perf_evsel__hw_name(u64 config)
         return "unknown-hardware";
 }
 
-static int perf_evsel__hw_name(struct perf_evsel *evsel, char *bf, size_t size)
+static int perf_evsel__add_modifiers(struct perf_evsel *evsel, char *bf, size_t size)
 {
-        int colon = 0;
+        int colon = 0, r = 0;
         struct perf_event_attr *attr = &evsel->attr;
-        int r = scnprintf(bf, size, "%s", __perf_evsel__hw_name(attr->config));
         bool exclude_guest_default = false;
 
 #define MOD_PRINT(context, mod) do {                                    \
                 if (!attr->exclude_##context) {                         \
-                        if (!colon) colon = r++;                        \
+                        if (!colon) colon = ++r;                        \
                         r += scnprintf(bf + r, size - r, "%c", mod);    \
                 } } while(0)
 
@@ -108,7 +107,7 @@ static int perf_evsel__hw_name(struct perf_evsel *evsel, char *bf, size_t size)
 
         if (attr->precise_ip) {
                 if (!colon)
-                        colon = r++;
+                        colon = ++r;
                 r += scnprintf(bf + r, size - r, "%.*s", attr->precise_ip, "ppp");
                 exclude_guest_default = true;
         }
@@ -119,39 +118,182 @@ static int perf_evsel__hw_name(struct perf_evsel *evsel, char *bf, size_t size)
         }
 #undef MOD_PRINT
         if (colon)
-                bf[colon] = ':';
+                bf[colon - 1] = ':';
         return r;
 }
 
-int perf_evsel__name(struct perf_evsel *evsel, char *bf, size_t size)
+static int perf_evsel__hw_name(struct perf_evsel *evsel, char *bf, size_t size)
+{
+        int r = scnprintf(bf, size, "%s", __perf_evsel__hw_name(evsel->attr.config));
+        return r + perf_evsel__add_modifiers(evsel, bf + r, size - r);
+}
+
+static const char *perf_evsel__sw_names[PERF_COUNT_SW_MAX] = {
+        "cpu-clock",
+        "task-clock",
+        "page-faults",
+        "context-switches",
+        "CPU-migrations",
+        "minor-faults",
+        "major-faults",
+        "alignment-faults",
+        "emulation-faults",
+};
+
+static const char *__perf_evsel__sw_name(u64 config)
+{
+        if (config < PERF_COUNT_SW_MAX && perf_evsel__sw_names[config])
+                return perf_evsel__sw_names[config];
+        return "unknown-software";
+}
+
+static int perf_evsel__sw_name(struct perf_evsel *evsel, char *bf, size_t size)
+{
+        int r = scnprintf(bf, size, "%s", __perf_evsel__sw_name(evsel->attr.config));
+        return r + perf_evsel__add_modifiers(evsel, bf + r, size - r);
+}
+
+const char *perf_evsel__hw_cache[PERF_COUNT_HW_CACHE_MAX]
+                                [PERF_EVSEL__MAX_ALIASES] = {
+ { "L1-dcache", "l1-d",         "l1d",          "L1-data",              },
+ { "L1-icache", "l1-i",         "l1i",          "L1-instruction",       },
+ { "LLC",       "L2",                                                   },
+ { "dTLB",      "d-tlb",        "Data-TLB",                             },
+ { "iTLB",      "i-tlb",        "Instruction-TLB",                      },
+ { "branch",    "branches",     "bpu",          "btb",          "bpc",  },
+ { "node",                                                              },
+};
+
+const char *perf_evsel__hw_cache_op[PERF_COUNT_HW_CACHE_OP_MAX]
+                                   [PERF_EVSEL__MAX_ALIASES] = {
+ { "load",      "loads",        "read",                                 },
+ { "store",     "stores",       "write",                                },
+ { "prefetch",  "prefetches",   "speculative-read", "speculative-load", },
+};
+
+const char *perf_evsel__hw_cache_result[PERF_COUNT_HW_CACHE_RESULT_MAX]
+                                       [PERF_EVSEL__MAX_ALIASES] = {
+ { "refs",      "Reference",    "ops",          "access",               },
+ { "misses",    "miss",                                                 },
+};
+
+#define C(x)            PERF_COUNT_HW_CACHE_##x
+#define CACHE_READ      (1 << C(OP_READ))
+#define CACHE_WRITE     (1 << C(OP_WRITE))
+#define CACHE_PREFETCH  (1 << C(OP_PREFETCH))
+#define COP(x)          (1 << x)
+
+/*
+ * cache operartion stat
+ * L1I : Read and prefetch only
+ * ITLB and BPU : Read-only
+ */
+static unsigned long perf_evsel__hw_cache_stat[C(MAX)] = {
+ [C(L1D)]       = (CACHE_READ | CACHE_WRITE | CACHE_PREFETCH),
+ [C(L1I)]       = (CACHE_READ | CACHE_PREFETCH),
+ [C(LL)]        = (CACHE_READ | CACHE_WRITE | CACHE_PREFETCH),
+ [C(DTLB)]      = (CACHE_READ | CACHE_WRITE | CACHE_PREFETCH),
+ [C(ITLB)]      = (CACHE_READ),
+ [C(BPU)]       = (CACHE_READ),
+ [C(NODE)]      = (CACHE_READ | CACHE_WRITE | CACHE_PREFETCH),
+};
+
+bool perf_evsel__is_cache_op_valid(u8 type, u8 op)
+{
+        if (perf_evsel__hw_cache_stat[type] & COP(op))
+                return true;    /* valid */
+        else
+                return false;   /* invalid */
+}
+
+int __perf_evsel__hw_cache_type_op_res_name(u8 type, u8 op, u8 result,
+                                            char *bf, size_t size)
+{
+        if (result) {
+                return scnprintf(bf, size, "%s-%s-%s", perf_evsel__hw_cache[type][0],
+                                 perf_evsel__hw_cache_op[op][0],
+                                 perf_evsel__hw_cache_result[result][0]);
+        }
+
+        return scnprintf(bf, size, "%s-%s", perf_evsel__hw_cache[type][0],
+                         perf_evsel__hw_cache_op[op][1]);
+}
+
+static int __perf_evsel__hw_cache_name(u64 config, char *bf, size_t size)
 {
-        int ret;
+        u8 op, result, type = (config >>  0) & 0xff;
+        const char *err = "unknown-ext-hardware-cache-type";
+
+        if (type > PERF_COUNT_HW_CACHE_MAX)
+                goto out_err;
+
+        op = (config >>  8) & 0xff;
+        err = "unknown-ext-hardware-cache-op";
+        if (op > PERF_COUNT_HW_CACHE_OP_MAX)
+                goto out_err;
+
+        result = (config >> 16) & 0xff;
+        err = "unknown-ext-hardware-cache-result";
+        if (result > PERF_COUNT_HW_CACHE_RESULT_MAX)
+                goto out_err;
+
+        err = "invalid-cache";
+        if (!perf_evsel__is_cache_op_valid(type, op))
+                goto out_err;
+
+        return __perf_evsel__hw_cache_type_op_res_name(type, op, result, bf, size);
+out_err:
+        return scnprintf(bf, size, "%s", err);
+}
+
+static int perf_evsel__hw_cache_name(struct perf_evsel *evsel, char *bf, size_t size)
+{
+        int ret = __perf_evsel__hw_cache_name(evsel->attr.config, bf, size);
+        return ret + perf_evsel__add_modifiers(evsel, bf + ret, size - ret);
+}
+
+static int perf_evsel__raw_name(struct perf_evsel *evsel, char *bf, size_t size)
+{
+        int ret = scnprintf(bf, size, "raw 0x%" PRIx64, evsel->attr.config);
+        return ret + perf_evsel__add_modifiers(evsel, bf + ret, size - ret);
+}
+
+const char *perf_evsel__name(struct perf_evsel *evsel)
+{
+        char bf[128];
+
+        if (evsel->name)
+                return evsel->name;
 
         switch (evsel->attr.type) {
         case PERF_TYPE_RAW:
-                ret = scnprintf(bf, size, "raw 0x%" PRIx64, evsel->attr.config);
+                perf_evsel__raw_name(evsel, bf, sizeof(bf));
                 break;
 
         case PERF_TYPE_HARDWARE:
-                ret = perf_evsel__hw_name(evsel, bf, size);
+                perf_evsel__hw_name(evsel, bf, sizeof(bf));
+                break;
+
+        case PERF_TYPE_HW_CACHE:
+                perf_evsel__hw_cache_name(evsel, bf, sizeof(bf));
+                break;
+
+        case PERF_TYPE_SOFTWARE:
+                perf_evsel__sw_name(evsel, bf, sizeof(bf));
                 break;
+
+        case PERF_TYPE_TRACEPOINT:
+                scnprintf(bf, sizeof(bf), "%s", "unknown tracepoint");
+                break;
+
         default:
-                /*
-                 * FIXME
-                 *
-                 * This is the minimal perf_evsel__name so that we can
-                 * reconstruct event names taking into account event modifiers.
-                 *
-                 * The old event_name uses it now for raw anr hw events, so that
-                 * we don't drag all the parsing stuff into the python binding.
-                 *
-                 * On the next devel cycle the rest of the event naming will be
-                 * brought here.
-                 */
-                return 0;
-        }
-
-        return ret;
+                scnprintf(bf, sizeof(bf), "%s", "unknown attr type");
+                break;
+        }
+
+        evsel->name = strdup(bf);
+
+        return evsel->name ?: "unknown";
 }
 
 void perf_evsel__config(struct perf_evsel *evsel, struct perf_record_opts *opts,