diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-03-26 20:16:22 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-04-02 15:27:55 -0400 |
commit | 5f4d3f8816461300ce54505c9117bf85b3044aa0 (patch) | |
tree | b69a6f22792480ab1ee02c67e5f8a650d66f208d /tools/perf/util/debug.h | |
parent | 7e5e1b1404c30db5f6bc3f5203b6c21c1d244f99 (diff) |
perf report: Add progress bars
For when we are processing the events and inserting the entries in the
browser.
Experimentation here: naming "ui_something" we may be treading into
creating a TUI/GUI set of routines that can then be implemented in terms
of multiple backends.
Also the time it takes for adding things to the "browser" takes, visually
(I guess I should do some profiling here ;-) ), more time than for
processing the events...
That means we probably need to create a custom hist_entry browser, so
that we reuse the structures we have in place instead of duplicating
them in newt.
But progress was made and at least we can see something while long files
are being loaded, that must be one of UI 101 bullet points :-)
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/debug.h')
-rw-r--r-- | tools/perf/util/debug.h | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/tools/perf/util/debug.h b/tools/perf/util/debug.h index 0172edf3f153..5cb0a1b1401a 100644 --- a/tools/perf/util/debug.h +++ b/tools/perf/util/debug.h | |||
@@ -10,13 +10,29 @@ extern int dump_trace; | |||
10 | int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2))); | 10 | int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2))); |
11 | void trace_event(event_t *event); | 11 | void trace_event(event_t *event); |
12 | 12 | ||
13 | struct ui_progress; | ||
14 | |||
13 | #ifdef NO_NEWT_SUPPORT | 15 | #ifdef NO_NEWT_SUPPORT |
14 | static inline int browser__show_help(const char *format __used, va_list ap __used) | 16 | static inline int browser__show_help(const char *format __used, va_list ap __used) |
15 | { | 17 | { |
16 | return 0; | 18 | return 0; |
17 | } | 19 | } |
20 | |||
21 | static inline struct ui_progress *ui_progress__new(const char *title __used, | ||
22 | u64 total __used) | ||
23 | { | ||
24 | return (struct ui_progress *)1; | ||
25 | } | ||
26 | |||
27 | static inline void ui_progress__update(struct ui_progress *self __used, | ||
28 | u64 curr __used) {} | ||
29 | |||
30 | static inline void ui_progress__delete(struct ui_progress *self __used) {} | ||
18 | #else | 31 | #else |
19 | int browser__show_help(const char *format, va_list ap); | 32 | int browser__show_help(const char *format, va_list ap); |
33 | struct ui_progress *ui_progress__new(const char *title, u64 total); | ||
34 | void ui_progress__update(struct ui_progress *self, u64 curr); | ||
35 | void ui_progress__delete(struct ui_progress *self); | ||
20 | #endif | 36 | #endif |
21 | 37 | ||
22 | #endif /* __PERF_DEBUG_H */ | 38 | #endif /* __PERF_DEBUG_H */ |