perf_counter tools: Add more warnings and fix/annotate them

Enable -Wextra. This found a few real bugs plus a number
of signed/unsigned type mismatches/uncleanlinesses. It
also required a few annotations

All things considered it was still worth it so lets try with
this enabled for now.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

1 files changed, 5 insertions, 5 deletions

diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index c942daa712e6..251d99ecd225 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -10,15 +10,15 @@
 struct callchain_node {
         struct callchain_node   *parent;
         struct list_head        brothers;
-        struct list_head        children;
-        struct list_head        val;
+        struct list_head        children;
+        struct list_head        val;
         struct rb_node          rb_node;
-        int                     val_nr;
-        int                     hit;
+        unsigned int            val_nr;
+        u64                     hit;
 };
 
 struct callchain_list {
-        unsigned long           ip;
+        u64                     ip;
         struct symbol           *sym;
         struct list_head        list;
 };