diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2012-09-28 05:32:02 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-02 17:36:22 -0400 |
commit | 1254b51e32649f2d34ec6b070ed36717c5a6b825 (patch) | |
tree | fd582d9f1b25e73ebc1e81da46af462451b27f0f /tools/perf/util/cache.h | |
parent | f315e16850d00ae5b19f11810bc00bf68cf3c24a (diff) |
perf tools: Convert to NEWT_SUPPORT
For building perf without libnewt, we can set NO_NEWT=1 as a argument of
make. It then defines NO_NEWT_SUPPORT macro for C code to do the proper
handling. However it usually used in a negative semantics - e.g. #ifndef -
so we saw double negations which can be misleading. Convert it to a
positive form to make it more readable.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1348824728-14025-7-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/cache.h')
-rw-r--r-- | tools/perf/util/cache.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h index ab1769426541..70f318dc1d9a 100644 --- a/tools/perf/util/cache.h +++ b/tools/perf/util/cache.h | |||
@@ -33,7 +33,7 @@ extern int pager_use_color; | |||
33 | 33 | ||
34 | extern int use_browser; | 34 | extern int use_browser; |
35 | 35 | ||
36 | #if defined(NO_NEWT_SUPPORT) && defined(NO_GTK2_SUPPORT) | 36 | #if !defined(NEWT_SUPPORT) && defined(NO_GTK2_SUPPORT) |
37 | static inline void setup_browser(bool fallback_to_pager) | 37 | static inline void setup_browser(bool fallback_to_pager) |
38 | { | 38 | { |
39 | if (fallback_to_pager) | 39 | if (fallback_to_pager) |
@@ -44,15 +44,15 @@ static inline void exit_browser(bool wait_for_ok __maybe_unused) {} | |||
44 | void setup_browser(bool fallback_to_pager); | 44 | void setup_browser(bool fallback_to_pager); |
45 | void exit_browser(bool wait_for_ok); | 45 | void exit_browser(bool wait_for_ok); |
46 | 46 | ||
47 | #ifdef NO_NEWT_SUPPORT | 47 | #ifdef NEWT_SUPPORT |
48 | int ui__init(void); | ||
49 | void ui__exit(bool wait_for_ok); | ||
50 | #else | ||
48 | static inline int ui__init(void) | 51 | static inline int ui__init(void) |
49 | { | 52 | { |
50 | return -1; | 53 | return -1; |
51 | } | 54 | } |
52 | static inline void ui__exit(bool wait_for_ok __maybe_unused) {} | 55 | static inline void ui__exit(bool wait_for_ok __maybe_unused) {} |
53 | #else | ||
54 | int ui__init(void); | ||
55 | void ui__exit(bool wait_for_ok); | ||
56 | #endif | 56 | #endif |
57 | 57 | ||
58 | #ifdef NO_GTK2_SUPPORT | 58 | #ifdef NO_GTK2_SUPPORT |
@@ -65,7 +65,7 @@ static inline void perf_gtk__exit(bool wait_for_ok __maybe_unused) {} | |||
65 | int perf_gtk__init(void); | 65 | int perf_gtk__init(void); |
66 | void perf_gtk__exit(bool wait_for_ok); | 66 | void perf_gtk__exit(bool wait_for_ok); |
67 | #endif | 67 | #endif |
68 | #endif /* NO_NEWT_SUPPORT && NO_GTK2_SUPPORT */ | 68 | #endif /* !NEWT_SUPPORT && NO_GTK2_SUPPORT */ |
69 | 69 | ||
70 | char *alias_lookup(const char *alias); | 70 | char *alias_lookup(const char *alias); |
71 | int split_cmdline(char *cmdline, const char ***argv); | 71 | int split_cmdline(char *cmdline, const char ***argv); |