diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-05-20 11:15:33 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-05-20 11:15:33 -0400 |
commit | b36f19d572151abb987ce308a3e066b977a2146f (patch) | |
tree | 07f520f8b3da969d288e34a121cc31a0209eb519 /tools/perf/util/build-id.c | |
parent | 17930b405e0ecdc8ecc4d336377a92950e2de76a (diff) |
perf annotate: Use build-ids to find the right DSO
We were still using the pathname found on the MMAP event, that could not
be the one we used when recording, so use the build-id cache for that,
only falling back to use the pathname in the MMAP event if no build-ids
are available.
With this we now also are able to do secure, seamless offline annotation.
Example:
[root@doppio linux-2.6-tip]# perf report -g none -v 2> /dev/null | head -10
8.12% Xorg /usr/lib64/libpixman-1.so.0.14.0 0x0000000000026d02 B [.] pixman_rasterize_edges
4.68% firefox /usr/lib64/xulrunner-1.9.1/libxul.so 0x00000000005dbdba B [.] 0x000000005dbdba
3.70% swapper /lib/modules/2.6.34-rc6/build/vmlinux 0xffffffff81022cea ! [k] read_hpet
2.96% init /lib/modules/2.6.34-rc6/build/vmlinux 0xffffffff81022cea ! [k] read_hpet
2.73% swapper /lib/modules/2.6.34-rc6/build/vmlinux 0xffffffff8100a738 ! [k] mwait_idle_with_hints
[root@doppio linux-2.6-tip]# perf annotate -v pixman_rasterize_edges 2>&1 | grep Executing
Executing: objdump --start-address=0x000000371ce26670 --stop-address=0x000000371ce2709f -dS /root/.debug/.build-id/bd/6ac5199137aaeb279f864717d8d061477466c1|grep -v /root/.debug/.build-id/bd/6ac5199137aaeb279f864717d8d061477466c1|expand
[root@doppio linux-2.6-tip]# perf buildid-list | grep libpixman-1.so.0.14.0
bd6ac5199137aaeb279f864717d8d061477466c1 /usr/lib64/libpixman-1.so.0.14.0
[root@doppio linux-2.6-tip]#
Reported-by: Stephane Eranian <eranian@google.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/build-id.c')
-rw-r--r-- | tools/perf/util/build-id.c | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index 0f60a3906808..70c5cf87d020 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c | |||
@@ -6,6 +6,8 @@ | |||
6 | * Copyright (C) 2009, 2010 Red Hat Inc. | 6 | * Copyright (C) 2009, 2010 Red Hat Inc. |
7 | * Copyright (C) 2009, 2010 Arnaldo Carvalho de Melo <acme@redhat.com> | 7 | * Copyright (C) 2009, 2010 Arnaldo Carvalho de Melo <acme@redhat.com> |
8 | */ | 8 | */ |
9 | #include "util.h" | ||
10 | #include <stdio.h> | ||
9 | #include "build-id.h" | 11 | #include "build-id.h" |
10 | #include "event.h" | 12 | #include "event.h" |
11 | #include "symbol.h" | 13 | #include "symbol.h" |
@@ -37,3 +39,23 @@ struct perf_event_ops build_id__mark_dso_hit_ops = { | |||
37 | .mmap = event__process_mmap, | 39 | .mmap = event__process_mmap, |
38 | .fork = event__process_task, | 40 | .fork = event__process_task, |
39 | }; | 41 | }; |
42 | |||
43 | char *dso__build_id_filename(struct dso *self, char *bf, size_t size) | ||
44 | { | ||
45 | char build_id_hex[BUILD_ID_SIZE * 2 + 1]; | ||
46 | const char *home; | ||
47 | |||
48 | if (!self->has_build_id) | ||
49 | return NULL; | ||
50 | |||
51 | build_id__sprintf(self->build_id, sizeof(self->build_id), build_id_hex); | ||
52 | home = getenv("HOME"); | ||
53 | if (bf == NULL) { | ||
54 | if (asprintf(&bf, "%s/%s/.build-id/%.2s/%s", home, | ||
55 | DEBUG_CACHE_DIR, build_id_hex, build_id_hex + 2) < 0) | ||
56 | return NULL; | ||
57 | } else | ||
58 | snprintf(bf, size, "%s/%s/.build-id/%.2s/%s", home, | ||
59 | DEBUG_CACHE_DIR, build_id_hex, build_id_hex + 2); | ||
60 | return bf; | ||
61 | } | ||