diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-04-19 09:16:27 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-04-19 09:16:27 -0400 |
commit | 28548d78ad521310f0ae58f791aa796d3d685151 (patch) | |
tree | 381d507e987faec4e1628fecf588c85987adaa35 /tools/perf/ui/browsers/annotate.c | |
parent | d86b0597c4bd41ea3edc6446a855306eed34f93b (diff) |
perf annotate: Introduce scnprintf ins_ops method
And implement the jump one, where if the operands string is not passed,
a compact form that uses just the target address is used.
Right now this is toggled via the 'o' option in the annotate browser,
switching from:
0.00 : ffffffff811661e8: je ffffffff81166204 <mem_cgroup_count_vm_event+0x44>
0.00 : ffffffff811661ea: cmp $0xb,%esi
0.00 : ffffffff811661ed: je ffffffff811661f8 <mem_cgroup_count_vm_event+0x38>
To:
0.00 : 28: je 44
0.00 : 2a: cmp $0xb,%esi
0.00 : 2d: je 38
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-o88q46yh4kxgpd1chk5gvjl5@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/ui/browsers/annotate.c')
-rw-r--r-- | tools/perf/ui/browsers/annotate.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 46ef966ccc5b..f7d2db3e8464 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c | |||
@@ -83,7 +83,7 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro | |||
83 | else if (dl->offset == -1) | 83 | else if (dl->offset == -1) |
84 | slsmg_write_nstring(dl->line, width - 18); | 84 | slsmg_write_nstring(dl->line, width - 18); |
85 | else { | 85 | else { |
86 | char bf[64]; | 86 | char bf[256], *line = dl->line; |
87 | u64 addr = dl->offset; | 87 | u64 addr = dl->offset; |
88 | int printed, color = -1; | 88 | int printed, color = -1; |
89 | 89 | ||
@@ -96,7 +96,16 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro | |||
96 | slsmg_write_nstring(bf, printed); | 96 | slsmg_write_nstring(bf, printed); |
97 | if (change_color) | 97 | if (change_color) |
98 | ui_browser__set_color(self, color); | 98 | ui_browser__set_color(self, color); |
99 | slsmg_write_nstring(dl->line, width - 18 - printed); | 99 | if (dl->ins && dl->ins->ops->scnprintf) { |
100 | dl->ins->ops->scnprintf(dl->ins, bf, sizeof(bf), | ||
101 | !ab->use_offset ? dl->operands : NULL, | ||
102 | dl->target); | ||
103 | line = bf; | ||
104 | slsmg_write_nstring(" ", 7); | ||
105 | printed += 7; | ||
106 | } | ||
107 | |||
108 | slsmg_write_nstring(line, width - 18 - printed); | ||
100 | } | 109 | } |
101 | 110 | ||
102 | if (current_entry) | 111 | if (current_entry) |