perf annotate browser: More clearly separate columns

The first column (columns in the near future) are for the per line event
overhead(s), that only appear when they are not zero.

To clearly separate it, add back a solid vertical line, with just one
colour, not influenced by the per line overheads.

Then have the addr/offset column, then optionally the dynamic
(static in the future) jump->target arrows, if 'j' enables it.

Then the instructions.

Requested-by: Peter Zijlstra <peterz@infradead.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-r415t4sps0oyr9y8kd9j7clz@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

1 files changed, 7 insertions, 7 deletions

diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index b075e09bfb54..cde4d0f0ddb9 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -611,7 +611,7 @@ void ui_browser__write_graph(struct ui_browser *browser __used, int graph)
 
 static void __ui_browser__line_arrow_up(struct ui_browser *browser,
                                         unsigned int column,
-                                        u64 start, u64 end, int start_width)
+                                        u64 start, u64 end)
 {
         unsigned int row, end_row;
 
@@ -622,7 +622,7 @@ static void __ui_browser__line_arrow_up(struct ui_browser *browser,
                 ui_browser__gotorc(browser, row, column);
                 SLsmg_write_char(SLSMG_LLCORN_CHAR);
                 ui_browser__gotorc(browser, row, column + 1);
-                SLsmg_draw_hline(start_width);
+                SLsmg_draw_hline(2);
 
                 if (row-- == 0)
                         goto out;
@@ -651,7 +651,7 @@ out:
 
 static void __ui_browser__line_arrow_down(struct ui_browser *browser,
                                           unsigned int column,
-                                          u64 start, u64 end, int start_width)
+                                          u64 start, u64 end)
 {
         unsigned int row, end_row;
 
@@ -662,7 +662,7 @@ static void __ui_browser__line_arrow_down(struct ui_browser *browser,
                 ui_browser__gotorc(browser, row, column);
                 SLsmg_write_char(SLSMG_ULCORN_CHAR);
                 ui_browser__gotorc(browser, row, column + 1);
-                SLsmg_draw_hline(start_width);
+                SLsmg_draw_hline(2);
 
                 if (row++ == 0)
                         goto out;
@@ -690,12 +690,12 @@ out:
 }
 
 void __ui_browser__line_arrow(struct ui_browser *browser, unsigned int column,
-                              u64 start, u64 end, int start_width)
+                              u64 start, u64 end)
 {
         if (start > end)
-                __ui_browser__line_arrow_up(browser, column, start, end, start_width);
+                __ui_browser__line_arrow_up(browser, column, start, end);
         else
-                __ui_browser__line_arrow_down(browser, column, start, end, start_width);
+                __ui_browser__line_arrow_down(browser, column, start, end);
 }
 
 void ui_browser__init(void)