diff options
| author | Ingo Molnar <mingo@kernel.org> | 2013-10-10 03:06:21 -0400 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-10-14 09:29:15 -0400 |
| commit | 046fa7ae20d2390c65be8eb406efecff15e8b71d (patch) | |
| tree | ef18ecaa3abd5d547bbd6a9e7440e9884a2fec3e /tools/perf/config/feature-checks | |
| parent | 01287e2cb7ad17b3d77751888d458a6b6a2bba15 (diff) | |
tools/perf/build: Improve the 'stackprotector' feature test
Namhyung Kim noticed that the stackprotector testcase was incomplete:
> The flag being checked should be -"W"stack-protector instead of
> -"f"stack-protector. And the gcc manpage says that -Wstack-protector is
> only active when -fstack-protector is active. So the end result should
> look like
>
> $(BUILD) -Werror -fstack-protector -Wstack-protector
Add -Wstack-protector.
Reported-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/config/feature-checks')
| -rw-r--r-- | tools/perf/config/feature-checks/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile index 2eb83467cca2..c70d23ecb64e 100644 --- a/tools/perf/config/feature-checks/Makefile +++ b/tools/perf/config/feature-checks/Makefile | |||
| @@ -45,7 +45,7 @@ test-stackprotector-all: | |||
| 45 | $(BUILD) -Werror -fstack-protector-all | 45 | $(BUILD) -Werror -fstack-protector-all |
| 46 | 46 | ||
| 47 | test-stackprotector: | 47 | test-stackprotector: |
| 48 | $(BUILD) -Werror -fstack-protector | 48 | $(BUILD) -Werror -fstack-protector -Wstack-protector |
| 49 | 49 | ||
| 50 | test-fortify-source: | 50 | test-fortify-source: |
| 51 | $(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2 | 51 | $(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2 |