diff options
author | Ingo Molnar <mingo@kernel.org> | 2013-10-10 02:58:57 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-10-14 09:29:13 -0400 |
commit | 01287e2cb7ad17b3d77751888d458a6b6a2bba15 (patch) | |
tree | 92193d8627b7504c2f7aee7c0b59d26fb9d49a35 /tools/perf/config/feature-checks | |
parent | 5f36978ca5b12b1e35535dedb8c999694fc0dfcf (diff) |
tools/perf/build: Remove the volatile-register-var feature check
Namhyung Kim noticed that the volatile-register-var feature check
is superfluous:
> The gcc manpage says this warning is enabled by -Wall, and we add -Wall
> to CFLAGS before doing feature checks. So all gcc versions that support
> -Wvolatile-register-var enables it by default without this check and
> older gcc versions will always fail the feature check.
Remove it - this will further speed up feature checks.
Reported-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/config/feature-checks')
-rw-r--r-- | tools/perf/config/feature-checks/Makefile | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile index cf33596c7300..2eb83467cca2 100644 --- a/tools/perf/config/feature-checks/Makefile +++ b/tools/perf/config/feature-checks/Makefile | |||
@@ -25,8 +25,7 @@ FILES= \ | |||
25 | test-libunwind \ | 25 | test-libunwind \ |
26 | test-on-exit \ | 26 | test-on-exit \ |
27 | test-stackprotector-all \ | 27 | test-stackprotector-all \ |
28 | test-stackprotector \ | 28 | test-stackprotector |
29 | test-volatile-register-var | ||
30 | 29 | ||
31 | CC := $(CC) -MD | 30 | CC := $(CC) -MD |
32 | 31 | ||
@@ -37,7 +36,7 @@ BUILD = $(CC) $(LDFLAGS) -o $(OUTPUT)$@ $@.c | |||
37 | ############################### | 36 | ############################### |
38 | 37 | ||
39 | test-all: | 38 | test-all: |
40 | $(BUILD) -Werror -fstack-protector -fstack-protector-all -Wvolatile-register-var -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lunwind -lunwind-x86_64 -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl | 39 | $(BUILD) -Werror -fstack-protector -fstack-protector-all -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lunwind -lunwind-x86_64 -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl |
41 | 40 | ||
42 | test-hello: | 41 | test-hello: |
43 | $(BUILD) | 42 | $(BUILD) |
@@ -48,9 +47,6 @@ test-stackprotector-all: | |||
48 | test-stackprotector: | 47 | test-stackprotector: |
49 | $(BUILD) -Werror -fstack-protector | 48 | $(BUILD) -Werror -fstack-protector |
50 | 49 | ||
51 | test-volatile-register-var: | ||
52 | $(BUILD) -Werror -Wvolatile-register-var | ||
53 | |||
54 | test-fortify-source: | 50 | test-fortify-source: |
55 | $(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2 | 51 | $(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2 |
56 | 52 | ||