diff options
author | Jiri Olsa <jolsa@kernel.org> | 2015-03-01 14:44:18 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-03-18 14:07:18 -0400 |
commit | 07efbf528c9f72bad67cc5a8c3afaa9c937fde43 (patch) | |
tree | d70449ab57729be62dac1a73748d76c3854d96c5 /tools/perf/config/Makefile | |
parent | ee9c80a13ea84bbf469a669685962099e11b9567 (diff) |
perf build: Get rid of VF_FEATURE_TESTS
It only contains (FEATURE_TESTS - FEATURE_DISPLAY) tests to display the
rest of the checks on 'make VF=1'. But we can actually compute this
list, which is less confusing.
Also renaming LIB_FEATURE_TESTS into FEATURE_DISPLAY, so it reflects
what this variable actually does - display its tests status to user.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <david.ahern@oracle.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/n/tip-gs160y03hpmx5ezpcr4gunxc@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/config/Makefile')
-rw-r--r-- | tools/perf/config/Makefile | 32 |
1 files changed, 7 insertions, 25 deletions
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 507350566e7f..198609e1d696 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile | |||
@@ -228,7 +228,7 @@ FEATURE_TESTS = \ | |||
228 | libdw-dwarf-unwind \ | 228 | libdw-dwarf-unwind \ |
229 | zlib | 229 | zlib |
230 | 230 | ||
231 | LIB_FEATURE_TESTS = \ | 231 | FEATURE_DISPLAY = \ |
232 | dwarf \ | 232 | dwarf \ |
233 | glibc \ | 233 | glibc \ |
234 | gtk2 \ | 234 | gtk2 \ |
@@ -243,25 +243,6 @@ LIB_FEATURE_TESTS = \ | |||
243 | libdw-dwarf-unwind \ | 243 | libdw-dwarf-unwind \ |
244 | zlib | 244 | zlib |
245 | 245 | ||
246 | VF_FEATURE_TESTS = \ | ||
247 | backtrace \ | ||
248 | fortify-source \ | ||
249 | sync-compare-and-swap \ | ||
250 | gtk2-infobar \ | ||
251 | libelf-getphdrnum \ | ||
252 | libelf-mmap \ | ||
253 | libpython-version \ | ||
254 | pthread-attr-setaffinity-np \ | ||
255 | stackprotector-all \ | ||
256 | timerfd \ | ||
257 | libunwind-debug-frame \ | ||
258 | bionic \ | ||
259 | liberty \ | ||
260 | liberty-z \ | ||
261 | cplus-demangle \ | ||
262 | compile-32 \ | ||
263 | compile-x32 | ||
264 | |||
265 | # Set FEATURE_CHECK_(C|LD)FLAGS-all for all FEATURE_TESTS features. | 246 | # Set FEATURE_CHECK_(C|LD)FLAGS-all for all FEATURE_TESTS features. |
266 | # If in the future we need per-feature checks/flags for features not | 247 | # If in the future we need per-feature checks/flags for features not |
267 | # mentioned in this list we need to refactor this ;-). | 248 | # mentioned in this list we need to refactor this ;-). |
@@ -805,7 +786,7 @@ define feature_print_text_code | |||
805 | MSG = $(shell printf '...%30s: %s' $(1) $(2)) | 786 | MSG = $(shell printf '...%30s: %s' $(1) $(2)) |
806 | endef | 787 | endef |
807 | 788 | ||
808 | PERF_FEATURES := $(foreach feat,$(LIB_FEATURE_TESTS),feature-$(feat)($(feature-$(feat)))) | 789 | PERF_FEATURES := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)($(feature-$(feat)))) |
809 | PERF_FEATURES_FILE := $(shell touch $(OUTPUT)PERF-FEATURES; cat $(OUTPUT)PERF-FEATURES) | 790 | PERF_FEATURES_FILE := $(shell touch $(OUTPUT)PERF-FEATURES; cat $(OUTPUT)PERF-FEATURES) |
810 | 791 | ||
811 | ifeq ($(dwarf-post-unwind),1) | 792 | ifeq ($(dwarf-post-unwind),1) |
@@ -816,7 +797,7 @@ endif | |||
816 | # output. It's set if: | 797 | # output. It's set if: |
817 | # - detected features differes from stored features from | 798 | # - detected features differes from stored features from |
818 | # last build (in PERF-FEATURES file) | 799 | # last build (in PERF-FEATURES file) |
819 | # - one of the $(LIB_FEATURE_TESTS) is not detected | 800 | # - one of the $(FEATURE_DISPLAY) is not detected |
820 | # - VF is enabled | 801 | # - VF is enabled |
821 | 802 | ||
822 | ifneq ("$(PERF_FEATURES)","$(PERF_FEATURES_FILE)") | 803 | ifneq ("$(PERF_FEATURES)","$(PERF_FEATURES_FILE)") |
@@ -831,7 +812,7 @@ define feature_check_code | |||
831 | endif | 812 | endif |
832 | endef | 813 | endef |
833 | 814 | ||
834 | $(foreach feat,$(LIB_FEATURE_TESTS),$(call feature_check,$(feat))) | 815 | $(foreach feat,$(FEATURE_DISPLAY),$(call feature_check,$(feat))) |
835 | 816 | ||
836 | ifeq ($(VF),1) | 817 | ifeq ($(VF),1) |
837 | display_lib := 1 | 818 | display_lib := 1 |
@@ -841,7 +822,7 @@ endif | |||
841 | ifeq ($(display_lib),1) | 822 | ifeq ($(display_lib),1) |
842 | $(info ) | 823 | $(info ) |
843 | $(info Auto-detecting system features:) | 824 | $(info Auto-detecting system features:) |
844 | $(foreach feat,$(LIB_FEATURE_TESTS),$(call feature_print_status,$(feat),)) | 825 | $(foreach feat,$(FEATURE_DISPLAY),$(call feature_print_status,$(feat),)) |
845 | 826 | ||
846 | ifeq ($(dwarf-post-unwind),1) | 827 | ifeq ($(dwarf-post-unwind),1) |
847 | $(call feature_print_text,"DWARF post unwind library", $(dwarf-post-unwind-text)) | 828 | $(call feature_print_text,"DWARF post unwind library", $(dwarf-post-unwind-text)) |
@@ -849,7 +830,8 @@ ifeq ($(display_lib),1) | |||
849 | endif | 830 | endif |
850 | 831 | ||
851 | ifeq ($(display_vf),1) | 832 | ifeq ($(display_vf),1) |
852 | $(foreach feat,$(VF_FEATURE_TESTS),$(call feature_print_status,$(feat),)) | 833 | TMP := $(filter-out $(FEATURE_DISPLAY),$(FEATURE_TESTS)) |
834 | $(foreach feat,$(TMP),$(call feature_print_status,$(feat),)) | ||
853 | $(info ) | 835 | $(info ) |
854 | $(call feature_print_var,prefix) | 836 | $(call feature_print_var,prefix) |
855 | $(call feature_print_var,bindir) | 837 | $(call feature_print_var,bindir) |