diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-12-13 16:50:29 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-12-14 10:57:17 -0500 |
commit | 4aa65636411ccb12f006a6ad593930655c445ff6 (patch) | |
tree | 0f494705a2a7631070a5372bb53f873684b001c2 /tools/perf/builtin-top.c | |
parent | b3165f414416a717f72a376720564012af5a2e01 (diff) |
perf session: Move kmaps to perf_session
There is still some more work to do to disentangle map creation
from DSO loading, but this happens only for the kernel, and for
the early adopters of perf diff, where this disentanglement
matters most, we'll be testing different kernels, so no problem
here.
Further clarification: right now we create the kernel maps for
the various modules and discontiguous kernel text maps when
loading the DSO, we should do it as a two step process, first
creating the maps, for multiple mappings with the same DSO
store, then doing the dso load just once, for the first hit on
one of the maps sharing this DSO backing store.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1260741029-4430-6-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-top.c')
-rw-r--r-- | tools/perf/builtin-top.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 0f7a4da2924c..3b212bb2e4df 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
@@ -1162,8 +1162,8 @@ static int __cmd_top(void) | |||
1162 | * FIXME: perf_session__new should allow passing a O_MMAP, so that all this | 1162 | * FIXME: perf_session__new should allow passing a O_MMAP, so that all this |
1163 | * mmap reading, etc is encapsulated in it. Use O_WRONLY for now. | 1163 | * mmap reading, etc is encapsulated in it. Use O_WRONLY for now. |
1164 | */ | 1164 | */ |
1165 | struct perf_session *session = perf_session__new(NULL, O_WRONLY, false); | 1165 | struct perf_session *session = perf_session__new(NULL, O_WRONLY, false, |
1166 | 1166 | &symbol_conf); | |
1167 | if (session == NULL) | 1167 | if (session == NULL) |
1168 | return -ENOMEM; | 1168 | return -ENOMEM; |
1169 | 1169 | ||