diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-03-11 08:11:48 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-03-11 11:28:45 -0500 |
commit | ec52d9765a0f3603c62b4238482bf38897e4d42f (patch) | |
tree | a836047186077efda945d63bdd11aabccfd941b5 /tools/perf/builtin-top.c | |
parent | 137ee20ddd10fdc20600c389fe63edab0c39cb1a (diff) |
perf top: Remove redundant perf_top->sym_counter
We can get that counter index from perf_top->sym_evsel->idx instead.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-top.c')
-rw-r--r-- | tools/perf/builtin-top.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 80c9e062bd5b..4bf6e02c2b2a 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
@@ -515,24 +515,25 @@ static void handle_keypress(struct perf_session *session, int c) | |||
515 | break; | 515 | break; |
516 | case 'E': | 516 | case 'E': |
517 | if (top.evlist->nr_entries > 1) { | 517 | if (top.evlist->nr_entries > 1) { |
518 | int counter; | ||
518 | fprintf(stderr, "\nAvailable events:"); | 519 | fprintf(stderr, "\nAvailable events:"); |
519 | 520 | ||
520 | list_for_each_entry(top.sym_evsel, &top.evlist->entries, node) | 521 | list_for_each_entry(top.sym_evsel, &top.evlist->entries, node) |
521 | fprintf(stderr, "\n\t%d %s", top.sym_evsel->idx, event_name(top.sym_evsel)); | 522 | fprintf(stderr, "\n\t%d %s", top.sym_evsel->idx, event_name(top.sym_evsel)); |
522 | 523 | ||
523 | prompt_integer(&top.sym_counter, "Enter details event counter"); | 524 | prompt_integer(&counter, "Enter details event counter"); |
524 | 525 | ||
525 | if (top.sym_counter >= top.evlist->nr_entries) { | 526 | if (counter >= top.evlist->nr_entries) { |
526 | top.sym_evsel = list_entry(top.evlist->entries.next, struct perf_evsel, node); | 527 | top.sym_evsel = list_entry(top.evlist->entries.next, struct perf_evsel, node); |
527 | top.sym_counter = 0; | ||
528 | fprintf(stderr, "Sorry, no such event, using %s.\n", event_name(top.sym_evsel)); | 528 | fprintf(stderr, "Sorry, no such event, using %s.\n", event_name(top.sym_evsel)); |
529 | sleep(1); | 529 | sleep(1); |
530 | break; | 530 | break; |
531 | } | 531 | } |
532 | list_for_each_entry(top.sym_evsel, &top.evlist->entries, node) | 532 | list_for_each_entry(top.sym_evsel, &top.evlist->entries, node) |
533 | if (top.sym_evsel->idx == top.sym_counter) | 533 | if (top.sym_evsel->idx == counter) |
534 | break; | 534 | break; |
535 | } else top.sym_counter = 0; | 535 | } else |
536 | top.sym_evsel = list_entry(top.evlist->entries.next, struct perf_evsel, node); | ||
536 | break; | 537 | break; |
537 | case 'f': | 538 | case 'f': |
538 | prompt_integer(&top.count_filter, "Enter display event count filter"); | 539 | prompt_integer(&top.count_filter, "Enter display event count filter"); |