diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2012-11-02 01:50:06 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-11-05 12:03:58 -0500 |
commit | 68d807586ba83d9cb77f12c8fb7c97ea438d34ad (patch) | |
tree | 15794b3d68f8770312c4e089ff50ece2b78318bc /tools/perf/builtin-top.c | |
parent | 9783adf777a445a1e9d0db4857a3a896a9f42d4a (diff) |
perf report: Postpone objdump check until annotation requested
David reported that current perf report refused to run on a data file
captured from a different machine because of objdump.
Since the objdump tools won't be used unless annotation was requested,
checking its presence at init time doesn't make sense.
Reported-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: David Ahern <dsahern@gmail.com>
Tested-by: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Irina Tirdea <irina.tirdea@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1351835406-15208-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-top.c')
-rw-r--r-- | tools/perf/builtin-top.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 102b43c9905d..c9ff3950cd4b 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
@@ -598,7 +598,8 @@ static void *display_thread_tui(void *arg) | |||
598 | list_for_each_entry(pos, &top->evlist->entries, node) | 598 | list_for_each_entry(pos, &top->evlist->entries, node) |
599 | pos->hists.uid_filter_str = top->target.uid_str; | 599 | pos->hists.uid_filter_str = top->target.uid_str; |
600 | 600 | ||
601 | perf_evlist__tui_browse_hists(top->evlist, help, &hbt); | 601 | perf_evlist__tui_browse_hists(top->evlist, help, &hbt, |
602 | &top->session->header.env); | ||
602 | 603 | ||
603 | exit_browser(0); | 604 | exit_browser(0); |
604 | exit(0); | 605 | exit(0); |