aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-top.c
diff options
context:
space:
mode:
authorDavid Ahern <daahern@cisco.com>2011-03-25 15:11:11 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2011-03-29 12:40:27 -0400
commitca6a42586fae639ff9e5285d9bdc550fcb1b8d41 (patch)
tree0eeb89ae0aaf2654ca3dbdc8d8057b97fef69545 /tools/perf/builtin-top.c
parentc286c419c784c238cd699be37fec7a9acc30d89f (diff)
perf tools: Emit clearer message for sys_perf_event_open ENOENT return
Resend of patch sent back in January 2011 in light of recent confusion around unsupported events for a given platform. Improve sys_perf_event_open ENOENT return handling in top and record, just like 5a3446b does for stat. Retry of Arnaldo's patch using ui_warning instead of die which allows the fallback from hardware cycles to software clock. Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-kernel@vger.kernel.org LKML-Reference: <1301080271-20945-1-git-send-email-daahern@cisco.com> Signed-off-by: David Ahern <daahern@cisco.com> [ committer note: Some adjustments to make it apply to newer codebase ] Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-top.c')
-rw-r--r--tools/perf/builtin-top.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 935fc4fd878e..fc1273e976c5 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -870,6 +870,12 @@ try_again:
870 goto try_again; 870 goto try_again;
871 } 871 }
872 872
873 if (err == ENOENT) {
874 ui__warning("The %s event is not supported.\n",
875 event_name(counter));
876 goto out_err;
877 }
878
873 ui__warning("The sys_perf_event_open() syscall " 879 ui__warning("The sys_perf_event_open() syscall "
874 "returned with %d (%s). /bin/dmesg " 880 "returned with %d (%s). /bin/dmesg "
875 "may provide additional information.\n" 881 "may provide additional information.\n"