diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-10-28 19:51:21 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-10-29 03:23:40 -0400 |
commit | 66bd8424cc05e800db384053bf7ab967e4658468 (patch) | |
tree | 2d58312238c78b1fe8482032e019c9437b3564ed /tools/perf/builtin-top.c | |
parent | 689d30187828afe1faedf050b2f7593515b90c76 (diff) |
perf tools: Delay loading symtabs till we hit a map with it
So that we can have a quicker start on perf top and even
speedups in the other tools, as we can have maps with no hits,
so no need to load its symtabs.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256773881-4191-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-top.c')
-rw-r--r-- | tools/perf/builtin-top.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index a02fc4146017..ee87640b3359 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
@@ -834,7 +834,7 @@ static void event__process_sample(const event_t *self, int counter) | |||
834 | map = thread__find_map(thread, ip); | 834 | map = thread__find_map(thread, ip); |
835 | if (map != NULL) { | 835 | if (map != NULL) { |
836 | ip = map->map_ip(map, ip); | 836 | ip = map->map_ip(map, ip); |
837 | sym = map->dso->find_symbol(map->dso, ip); | 837 | sym = map__find_symbol(map, ip, symbol_filter); |
838 | if (sym == NULL) | 838 | if (sym == NULL) |
839 | return; | 839 | return; |
840 | userspace_samples++; | 840 | userspace_samples++; |
@@ -879,8 +879,7 @@ static void event__process_mmap(event_t *self) | |||
879 | 879 | ||
880 | if (thread != NULL) { | 880 | if (thread != NULL) { |
881 | struct map *map = map__new(&self->mmap, NULL, 0, | 881 | struct map *map = map__new(&self->mmap, NULL, 0, |
882 | sizeof(struct sym_entry), | 882 | sizeof(struct sym_entry)); |
883 | symbol_filter); | ||
884 | if (map != NULL) | 883 | if (map != NULL) |
885 | thread__insert_map(thread, map); | 884 | thread__insert_map(thread, map); |
886 | } | 885 | } |