diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-11-27 13:29:22 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-11-27 14:22:01 -0500 |
commit | 62daacb51a2bf8480e6f6b3696b03f102fc15eb0 (patch) | |
tree | 5b9ed87005a5e59bcc95dd9a42e3d09d6481362d /tools/perf/builtin-top.c | |
parent | 1de8e24520ffdcf2a90c842eed937f59079a2abd (diff) |
perf tools: Reorganize event processing routines, lotsa dups killed
While implementing event__preprocess_sample, that will do all of
the symbol lookup in one convenient function, I noticed that
util/process_event.[ch] were not being used at all, then started
looking if there were other functions that could be shared
and...
All those functions really don't need to receive offset + head,
the only thing they did was common to all of them, so do it at
one place instead.
Stats about number of each type of event processed now is done
in a central place.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1259346563-12568-11-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-top.c')
-rw-r--r-- | tools/perf/builtin-top.c | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index bf6730c76033..7a3c0c7aad3d 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
@@ -991,25 +991,6 @@ static void event__process_sample(const event_t *self, int counter) | |||
991 | } | 991 | } |
992 | } | 992 | } |
993 | 993 | ||
994 | static void event__process_mmap(event_t *self) | ||
995 | { | ||
996 | struct thread *thread = threads__findnew(self->mmap.pid); | ||
997 | |||
998 | if (thread != NULL) { | ||
999 | struct map *map = map__new(&self->mmap, MAP__FUNCTION, NULL, 0); | ||
1000 | if (map != NULL) | ||
1001 | thread__insert_map(thread, map); | ||
1002 | } | ||
1003 | } | ||
1004 | |||
1005 | static void event__process_comm(event_t *self) | ||
1006 | { | ||
1007 | struct thread *thread = threads__findnew(self->comm.pid); | ||
1008 | |||
1009 | if (thread != NULL) | ||
1010 | thread__set_comm(thread, self->comm.comm); | ||
1011 | } | ||
1012 | |||
1013 | static int event__process(event_t *event) | 994 | static int event__process(event_t *event) |
1014 | { | 995 | { |
1015 | switch (event->header.type) { | 996 | switch (event->header.type) { |