diff options
author | Adrian Hunter <adrian.hunter@intel.com> | 2014-07-31 02:00:59 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-08-13 18:21:53 -0400 |
commit | 98526ee7229be8537373aebe037b74cac112d84b (patch) | |
tree | a68949723c6c66d00f9ddce7b9e6d3490c0ca55a /tools/perf/builtin-script.c | |
parent | 5a52f33adf02a3e5eafdc1e597a3fe172e620bec (diff) |
perf script: Allow callchains if any event samples them
perf script was not displaying callchains if any selected event did not
have PERF_SAMPLE_CALLCHAIN.
Change this to disable callchains only if all selected events do not
have PERF_SAMPLE_CALLCHAIN.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1406786474-9306-17-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-script.c')
-rw-r--r-- | tools/perf/builtin-script.c | 17 |
1 files changed, 13 insertions, 4 deletions
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 37d2b608d388..c1b7029884b1 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c | |||
@@ -184,10 +184,6 @@ static int perf_evsel__check_attr(struct perf_evsel *evsel, | |||
184 | if (perf_evsel__check_stype(evsel, PERF_SAMPLE_IP, "IP", | 184 | if (perf_evsel__check_stype(evsel, PERF_SAMPLE_IP, "IP", |
185 | PERF_OUTPUT_IP)) | 185 | PERF_OUTPUT_IP)) |
186 | return -EINVAL; | 186 | return -EINVAL; |
187 | |||
188 | if (!no_callchain && | ||
189 | !(attr->sample_type & PERF_SAMPLE_CALLCHAIN)) | ||
190 | symbol_conf.use_callchain = false; | ||
191 | } | 187 | } |
192 | 188 | ||
193 | if (PRINT_FIELD(ADDR) && | 189 | if (PRINT_FIELD(ADDR) && |
@@ -290,6 +286,19 @@ static int perf_session__check_output_opt(struct perf_session *session) | |||
290 | set_print_ip_opts(&evsel->attr); | 286 | set_print_ip_opts(&evsel->attr); |
291 | } | 287 | } |
292 | 288 | ||
289 | if (!no_callchain) { | ||
290 | bool use_callchain = false; | ||
291 | |||
292 | evlist__for_each(session->evlist, evsel) { | ||
293 | if (evsel->attr.sample_type & PERF_SAMPLE_CALLCHAIN) { | ||
294 | use_callchain = true; | ||
295 | break; | ||
296 | } | ||
297 | } | ||
298 | if (!use_callchain) | ||
299 | symbol_conf.use_callchain = false; | ||
300 | } | ||
301 | |||
293 | /* | 302 | /* |
294 | * set default for tracepoints to print symbols only | 303 | * set default for tracepoints to print symbols only |
295 | * if callchains are present | 304 | * if callchains are present |