diff options
author | Kyle McMartin <kyle@mcmartin.ca> | 2011-01-24 11:13:04 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-02-07 09:41:41 -0500 |
commit | fb7d0b3cefb80a105f7fd26bbc62e0cbf9192822 (patch) | |
tree | 1d5ce57f5fa73c593e10a321edb02498bea834b3 /tools/perf/builtin-sched.c | |
parent | 1ff511e35ed87cc2ebade9e678e4a2fe39b6f9c5 (diff) |
perf tool: Fix gcc 4.6.0 issues
GCC 4.6.0 in Fedora rawhide turned up some compile errors in tools/perf
due to the -Werror=unused-but-set-variable flag.
I've gone through and annotated some of the assignments that had side
effects (ie: return value from a function) with the __used annotation,
and in some cases, just removed unused code.
In a few cases, we were assigning something useful, but not using it in
later parts of the function.
kyle@dreadnought:~/src% gcc --version
gcc (GCC) 4.6.0 20110122 (Red Hat 4.6.0-0.3)
Cc: Ingo Molnar <mingo@redhat.com>
LKML-Reference: <20110124161304.GK27353@bombadil.infradead.org>
Signed-off-by: Kyle McMartin <kyle@redhat.com>
[ committer note: Fixed up the annotation fixes, as that code moved recently ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-sched.c')
-rw-r--r-- | tools/perf/builtin-sched.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index ae2621182927..a32f411faeac 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c | |||
@@ -369,11 +369,6 @@ static void | |||
369 | process_sched_event(struct task_desc *this_task __used, struct sched_atom *atom) | 369 | process_sched_event(struct task_desc *this_task __used, struct sched_atom *atom) |
370 | { | 370 | { |
371 | int ret = 0; | 371 | int ret = 0; |
372 | u64 now; | ||
373 | long long delta; | ||
374 | |||
375 | now = get_nsecs(); | ||
376 | delta = start_time + atom->timestamp - now; | ||
377 | 372 | ||
378 | switch (atom->type) { | 373 | switch (atom->type) { |
379 | case SCHED_EVENT_RUN: | 374 | case SCHED_EVENT_RUN: |
@@ -562,7 +557,7 @@ static void wait_for_tasks(void) | |||
562 | 557 | ||
563 | static void run_one_test(void) | 558 | static void run_one_test(void) |
564 | { | 559 | { |
565 | u64 T0, T1, delta, avg_delta, fluct, std_dev; | 560 | u64 T0, T1, delta, avg_delta, fluct; |
566 | 561 | ||
567 | T0 = get_nsecs(); | 562 | T0 = get_nsecs(); |
568 | wait_for_tasks(); | 563 | wait_for_tasks(); |
@@ -578,7 +573,6 @@ static void run_one_test(void) | |||
578 | else | 573 | else |
579 | fluct = delta - avg_delta; | 574 | fluct = delta - avg_delta; |
580 | sum_fluct += fluct; | 575 | sum_fluct += fluct; |
581 | std_dev = sum_fluct / nr_runs / sqrt(nr_runs); | ||
582 | if (!run_avg) | 576 | if (!run_avg) |
583 | run_avg = delta; | 577 | run_avg = delta; |
584 | run_avg = (run_avg*9 + delta)/10; | 578 | run_avg = (run_avg*9 + delta)/10; |
@@ -799,7 +793,7 @@ replay_switch_event(struct trace_switch_event *switch_event, | |||
799 | u64 timestamp, | 793 | u64 timestamp, |
800 | struct thread *thread __used) | 794 | struct thread *thread __used) |
801 | { | 795 | { |
802 | struct task_desc *prev, *next; | 796 | struct task_desc *prev, __used *next; |
803 | u64 timestamp0; | 797 | u64 timestamp0; |
804 | s64 delta; | 798 | s64 delta; |
805 | 799 | ||
@@ -1404,7 +1398,7 @@ map_switch_event(struct trace_switch_event *switch_event, | |||
1404 | u64 timestamp, | 1398 | u64 timestamp, |
1405 | struct thread *thread __used) | 1399 | struct thread *thread __used) |
1406 | { | 1400 | { |
1407 | struct thread *sched_out, *sched_in; | 1401 | struct thread *sched_out __used, *sched_in; |
1408 | int new_shortname; | 1402 | int new_shortname; |
1409 | u64 timestamp0; | 1403 | u64 timestamp0; |
1410 | s64 delta; | 1404 | s64 delta; |