diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-10-21 15:34:06 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-10-23 02:22:47 -0400 |
commit | 6beba7adbe092e63dfe8d09fbd1e3ec140474a13 (patch) | |
tree | d45a3347de224513c6d3d0e1061b78641f9aaf8a /tools/perf/builtin-report.c | |
parent | 802da5f2289bbe363acef084805195c11f453c48 (diff) |
perf tools: Unify debug messages mechanisms
We were using eprintf in some places, that looks at a global
'verbose' level, and at other places passing a 'v' parameter to
specify the verbosity level, unify it by introducing
pr_{err,warning,debug,etc}, just like in the kernel.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256153646-10097-1-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-report.c')
-rw-r--r-- | tools/perf/builtin-report.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 72d58421223d..b3d814b54555 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
@@ -689,7 +689,8 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head) | |||
689 | dump_printf("... chain: nr:%Lu\n", chain->nr); | 689 | dump_printf("... chain: nr:%Lu\n", chain->nr); |
690 | 690 | ||
691 | if (validate_chain(chain, event) < 0) { | 691 | if (validate_chain(chain, event) < 0) { |
692 | eprintf("call-chain problem with event, skipping it.\n"); | 692 | pr_debug("call-chain problem with event, " |
693 | "skipping it.\n"); | ||
693 | return 0; | 694 | return 0; |
694 | } | 695 | } |
695 | 696 | ||
@@ -700,7 +701,7 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head) | |||
700 | } | 701 | } |
701 | 702 | ||
702 | if (thread == NULL) { | 703 | if (thread == NULL) { |
703 | eprintf("problem processing %d event, skipping it.\n", | 704 | pr_debug("problem processing %d event, skipping it.\n", |
704 | event->header.type); | 705 | event->header.type); |
705 | return -1; | 706 | return -1; |
706 | } | 707 | } |
@@ -738,7 +739,7 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head) | |||
738 | 739 | ||
739 | if (hist_entry__add(thread, map, sym, ip, | 740 | if (hist_entry__add(thread, map, sym, ip, |
740 | chain, level, period)) { | 741 | chain, level, period)) { |
741 | eprintf("problem incrementing symbol count, skipping event\n"); | 742 | pr_debug("problem incrementing symbol count, skipping event\n"); |
742 | return -1; | 743 | return -1; |
743 | } | 744 | } |
744 | 745 | ||
@@ -750,7 +751,7 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head) | |||
750 | static int | 751 | static int |
751 | process_mmap_event(event_t *event, unsigned long offset, unsigned long head) | 752 | process_mmap_event(event_t *event, unsigned long offset, unsigned long head) |
752 | { | 753 | { |
753 | struct map *map = map__new(&event->mmap, cwd, cwdlen, 0, NULL, verbose); | 754 | struct map *map = map__new(&event->mmap, cwd, cwdlen, 0, NULL); |
754 | struct thread *thread = threads__findnew(event->mmap.pid); | 755 | struct thread *thread = threads__findnew(event->mmap.pid); |
755 | 756 | ||
756 | dump_printf("%p [%p]: PERF_RECORD_MMAP %d/%d: [%p(%p) @ %p]: %s\n", | 757 | dump_printf("%p [%p]: PERF_RECORD_MMAP %d/%d: [%p(%p) @ %p]: %s\n", |