aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-report.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2010-05-14 12:16:55 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2010-05-14 12:16:55 -0400
commitcee75ac7ecc27084accdb9d9d6fde65a09f047ae (patch)
tree686208e18b1ab5356658980ee92c96486384412e /tools/perf/builtin-report.c
parentc8446b9bdabcb0caa61bb341bd73c58f7104b503 (diff)
perf hist: Clarify events_stats fields usage
The events_stats.total field is too generic, rename it to .total_period, and also add a comment explaining that it is the sum of all the .period fields in samples, that is needed because we use auto-freq to avoid sampling artifacts. Ditto for events_stats.lost, that is the sum of all lost_event.lost fields, i.e. the number of events the kernel dropped. Looking at the users, builtin-sched.c can make use of these fields and stop doing it again. Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Tom Zanussi <tzanussi@gmail.com> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-report.c')
-rw-r--r--tools/perf/builtin-report.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index f13cda1ef059..b8f47ded6287 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -138,14 +138,14 @@ static int add_event_total(struct perf_session *session,
138 if (!hists) 138 if (!hists)
139 return -ENOMEM; 139 return -ENOMEM;
140 140
141 hists->stats.total += data->period; 141 hists->stats.total_period += data->period;
142 /* 142 /*
143 * FIXME: add_event_total should be moved from here to 143 * FIXME: add_event_total should be moved from here to
144 * perf_session__process_event so that the proper hist is passed to 144 * perf_session__process_event so that the proper hist is passed to
145 * the event_op methods. 145 * the event_op methods.
146 */ 146 */
147 hists__inc_nr_events(hists, PERF_RECORD_SAMPLE); 147 hists__inc_nr_events(hists, PERF_RECORD_SAMPLE);
148 session->hists.stats.total += data->period; 148 session->hists.stats.total_period += data->period;
149 return 0; 149 return 0;
150} 150}
151 151
@@ -322,10 +322,10 @@ static int __cmd_report(void)
322 if (rb_first(&session->hists.entries) == 322 if (rb_first(&session->hists.entries) ==
323 rb_last(&session->hists.entries)) 323 rb_last(&session->hists.entries))
324 fprintf(stdout, "# Samples: %Ld\n#\n", 324 fprintf(stdout, "# Samples: %Ld\n#\n",
325 hists->stats.total); 325 hists->stats.total_period);
326 else 326 else
327 fprintf(stdout, "# Samples: %Ld %s\n#\n", 327 fprintf(stdout, "# Samples: %Ld %s\n#\n",
328 hists->stats.total, 328 hists->stats.total_period,
329 __event_name(hists->type, hists->config)); 329 __event_name(hists->type, hists->config));
330 330
331 hists__fprintf(hists, NULL, false, stdout); 331 hists__fprintf(hists, NULL, false, stdout);