diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-05-18 12:13:33 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-05-18 12:13:33 -0400 |
commit | 16ee6576e25b83806d26eb771138249fcfb5eddc (patch) | |
tree | 7c717b80f28b5c59ba673dc00f2ca9bd0fc068d4 /tools/perf/builtin-report.c | |
parent | 16fa7e8200fb9066b77a3f27cbed8e4a9fc71998 (diff) | |
parent | 9b63776fa3ca96c4ecda76f6fa947b7b0add66ac (diff) |
Merge remote-tracking branch 'tip/perf/urgent' into perf/core
Merge reason: We are going to queue up a dependent patch:
"perf tools: Move parse event automated tests to separated object"
That depends on:
commit e7c72d8
perf tools: Add 'G' and 'H' modifiers to event parsing
Conflicts:
tools/perf/builtin-stat.c
Conflicted with the recent 'perf_target' patches when checking the
result of perf_evsel open routines to see if a retry is needed to cope
with older kernels where the exclude guest/host perf_event_attr bits
were not used.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-report.c')
-rw-r--r-- | tools/perf/builtin-report.c | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 74776558ddfb..d58e41445d0d 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
@@ -377,16 +377,23 @@ static int __cmd_report(struct perf_report *rep) | |||
377 | (kernel_map->dso->hit && | 377 | (kernel_map->dso->hit && |
378 | (kernel_kmap->ref_reloc_sym == NULL || | 378 | (kernel_kmap->ref_reloc_sym == NULL || |
379 | kernel_kmap->ref_reloc_sym->addr == 0))) { | 379 | kernel_kmap->ref_reloc_sym->addr == 0))) { |
380 | const struct dso *kdso = kernel_map->dso; | 380 | const char *desc = |
381 | "As no suitable kallsyms nor vmlinux was found, kernel samples\n" | ||
382 | "can't be resolved."; | ||
383 | |||
384 | if (kernel_map) { | ||
385 | const struct dso *kdso = kernel_map->dso; | ||
386 | if (!RB_EMPTY_ROOT(&kdso->symbols[MAP__FUNCTION])) { | ||
387 | desc = "If some relocation was applied (e.g. " | ||
388 | "kexec) symbols may be misresolved."; | ||
389 | } | ||
390 | } | ||
381 | 391 | ||
382 | ui__warning( | 392 | ui__warning( |
383 | "Kernel address maps (/proc/{kallsyms,modules}) were restricted.\n\n" | 393 | "Kernel address maps (/proc/{kallsyms,modules}) were restricted.\n\n" |
384 | "Check /proc/sys/kernel/kptr_restrict before running 'perf record'.\n\n%s\n\n" | 394 | "Check /proc/sys/kernel/kptr_restrict before running 'perf record'.\n\n%s\n\n" |
385 | "Samples in kernel modules can't be resolved as well.\n\n", | 395 | "Samples in kernel modules can't be resolved as well.\n\n", |
386 | RB_EMPTY_ROOT(&kdso->symbols[MAP__FUNCTION]) ? | 396 | desc); |
387 | "As no suitable kallsyms nor vmlinux was found, kernel samples\n" | ||
388 | "can't be resolved." : | ||
389 | "If some relocation was applied (e.g. kexec) symbols may be misresolved."); | ||
390 | } | 397 | } |
391 | 398 | ||
392 | if (dump_trace) { | 399 | if (dump_trace) { |