diff options
author | Jiri Olsa <jolsa@redhat.com> | 2013-11-05 09:14:47 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-11-05 13:15:08 -0500 |
commit | 714647bdc516330e4405b39677d7f763e016c685 (patch) | |
tree | 13aaae6374601031ff2393d11ee8a28d37072a6d /tools/perf/builtin-record.c | |
parent | a9862418547e818aa5842840aecfa81d733b97e9 (diff) |
perf tools: Check maximum frequency rate for record/top
Adding the check for maximum allowed frequency rate defined in following
file:
/proc/sys/kernel/perf_event_max_sample_rate
When we cross the maximum value we fail and display detailed error
message with advise.
$ perf record -F 3000 ls
Maximum frequency rate (2000) reached.
Please use -F freq option with lower value or consider
tweaking /proc/sys/kernel/perf_event_max_sample_rate.
In case user does not specify the frequency and the default value cross
the maximum, we display warning and set the frequency value to the
current maximum.
$ perf record ls
Lowering default frequency rate to 2000.
Please consider tweaking /proc/sys/kernel/perf_event_max_sample_rate.
Same messages are used for 'perf top'.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1383660887-1734-4-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-record.c')
-rw-r--r-- | tools/perf/builtin-record.c | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 8b45fcead5f6..ea4c04f7437e 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c | |||
@@ -958,20 +958,7 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused) | |||
958 | if (perf_evlist__create_maps(evsel_list, &rec->opts.target) < 0) | 958 | if (perf_evlist__create_maps(evsel_list, &rec->opts.target) < 0) |
959 | usage_with_options(record_usage, record_options); | 959 | usage_with_options(record_usage, record_options); |
960 | 960 | ||
961 | if (rec->opts.user_interval != ULLONG_MAX) | 961 | if (perf_record_opts__config(&rec->opts)) { |
962 | rec->opts.default_interval = rec->opts.user_interval; | ||
963 | if (rec->opts.user_freq != UINT_MAX) | ||
964 | rec->opts.freq = rec->opts.user_freq; | ||
965 | |||
966 | /* | ||
967 | * User specified count overrides default frequency. | ||
968 | */ | ||
969 | if (rec->opts.default_interval) | ||
970 | rec->opts.freq = 0; | ||
971 | else if (rec->opts.freq) { | ||
972 | rec->opts.default_interval = rec->opts.freq; | ||
973 | } else { | ||
974 | ui__error("frequency and count are zero, aborting\n"); | ||
975 | err = -EINVAL; | 962 | err = -EINVAL; |
976 | goto out_free_fd; | 963 | goto out_free_fd; |
977 | } | 964 | } |