diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-06-11 08:16:15 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-06-11 10:48:38 -0400 |
commit | 729ff5e2aaf181f5d3ab849337fce406cd19b1d9 (patch) | |
tree | 49591d8103f05bd157c083b9392ed7f4a8b3ae17 /tools/perf/builtin-record.c | |
parent | df58ab24bf26b166874bfb18b3b5a2e0a8e63179 (diff) |
perf_counter tools: Clean up u64 usage
A build error slipped in:
builtin-report.c: In function ‘hist_entry__fprintf’:
builtin-report.c:711: error: format ‘%12d’ expects type ‘int’, but argument 3 has type ‘uint64_t’
Because we got a bit sloppy with those types. uint64_t really sucks,
because there's no printf format for it. So standardize on __u64
instead - for all types that go to or come from the ABI (which is __u64),
or for values that need to be large enough even on 32-bit.
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-record.c')
-rw-r--r-- | tools/perf/builtin-record.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 919f23ca4199..84cd336ae79b 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c | |||
@@ -223,7 +223,7 @@ static void pid_synthesize_comm_event(pid_t pid, int full) | |||
223 | 223 | ||
224 | comm_ev.pid = pid; | 224 | comm_ev.pid = pid; |
225 | comm_ev.header.type = PERF_EVENT_COMM; | 225 | comm_ev.header.type = PERF_EVENT_COMM; |
226 | size = ALIGN(size, sizeof(uint64_t)); | 226 | size = ALIGN(size, sizeof(__u64)); |
227 | comm_ev.header.size = sizeof(comm_ev) - (sizeof(comm_ev.comm) - size); | 227 | comm_ev.header.size = sizeof(comm_ev) - (sizeof(comm_ev.comm) - size); |
228 | 228 | ||
229 | if (!full) { | 229 | if (!full) { |
@@ -304,7 +304,7 @@ static void pid_synthesize_mmap_samples(pid_t pid) | |||
304 | size = strlen(execname); | 304 | size = strlen(execname); |
305 | execname[size - 1] = '\0'; /* Remove \n */ | 305 | execname[size - 1] = '\0'; /* Remove \n */ |
306 | memcpy(mmap_ev.filename, execname, size); | 306 | memcpy(mmap_ev.filename, execname, size); |
307 | size = ALIGN(size, sizeof(uint64_t)); | 307 | size = ALIGN(size, sizeof(__u64)); |
308 | mmap_ev.len -= mmap_ev.start; | 308 | mmap_ev.len -= mmap_ev.start; |
309 | mmap_ev.header.size = (sizeof(mmap_ev) - | 309 | mmap_ev.header.size = (sizeof(mmap_ev) - |
310 | (sizeof(mmap_ev.filename) - size)); | 310 | (sizeof(mmap_ev.filename) - size)); |