aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-probe.c
diff options
context:
space:
mode:
authorMasami Hiramatsu <mhiramat@redhat.com>2009-12-15 10:32:47 -0500
committerIngo Molnar <mingo@elte.hu>2009-12-15 14:22:05 -0500
commit7ef17aafc98406d01ebbf7fe98ef1332b70d20bb (patch)
tree83211db3bb008b7d5a1224cf499f33591ced4708 /tools/perf/builtin-probe.c
parent62bdc1b38e2abf3f500229c3bf4c82d33575d1ae (diff)
perf probe: Fix to show which probe point is not found
Fix perf probe to show which probe point is not found. With out this patch, it shows just "No probe point found." This doesn't help users if they specify several probes. e.g. # perf probe -f --add schedule --add test Fatal: No probe point found. This patch makes error message more helpful as below. # perf probe --add schedule --add test Fatal: Probe point 'test' not found. - probe not added. Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Jim Keniston <jkenisto@us.ibm.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Frank Ch. Eigler <fche@redhat.com> Cc: Jason Baron <jbaron@redhat.com> Cc: K.Prasad <prasad@linux.vnet.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: systemtap <systemtap@sources.redhat.com> Cc: DLE <dle-develop@lists.sourceforge.net> Cc: Frederic Weisbecker <fweisbec@gmail.com> LKML-Reference: <20091215153247.17436.49068.stgit@dhcp-100-2-132.bos.redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-probe.c')
-rw-r--r--tools/perf/builtin-probe.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 6b0e4cf322d8..520b064b46d8 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -265,8 +265,11 @@ int cmd_probe(int argc, const char **argv, const char *prefix __used)
265 ret = find_probepoint(fd, pp); 265 ret = find_probepoint(fd, pp);
266 if (ret > 0) 266 if (ret > 0)
267 continue; 267 continue;
268 if (ret == 0) /* No error but failed to find probe point. */ 268 if (ret == 0) { /* No error but failed to find probe point. */
269 die("No probe point found."); 269 synthesize_perf_probe_point(pp);
270 die("Probe point '%s' not found. - probe not added.",
271 pp->probes[0]);
272 }
270 /* Error path */ 273 /* Error path */
271 if (session.need_dwarf) { 274 if (session.need_dwarf) {
272 if (ret == -ENOENT) 275 if (ret == -ENOENT)