diff options
author | Marcin Slusarz <marcin.slusarz@gmail.com> | 2011-02-22 12:47:15 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-03-16 08:05:58 -0400 |
commit | 9df03abeda3d928ecdedc0f427336931eac0a477 (patch) | |
tree | 4cb694e1f315b5d78ffd446a0407dcf7d172578f /tools/perf/builtin-lock.c | |
parent | 58d406ed6a5f1ca4bc1dba5390b718c67847fa5f (diff) |
perf lock: Fix sorting by wait_min
If lock was uncontended, wait_time_min == ULLONG_MAX, so we need to
handle this case differently to show high wait times first
Acked-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20110222174715.GC9687@joi.lan>
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-lock.c')
-rw-r--r-- | tools/perf/builtin-lock.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c index 2e93f99b1480..7a2a79d2cf2c 100644 --- a/tools/perf/builtin-lock.c +++ b/tools/perf/builtin-lock.c | |||
@@ -202,9 +202,20 @@ static struct thread_stat *thread_stat_findnew_first(u32 tid) | |||
202 | SINGLE_KEY(nr_acquired) | 202 | SINGLE_KEY(nr_acquired) |
203 | SINGLE_KEY(nr_contended) | 203 | SINGLE_KEY(nr_contended) |
204 | SINGLE_KEY(wait_time_total) | 204 | SINGLE_KEY(wait_time_total) |
205 | SINGLE_KEY(wait_time_min) | ||
206 | SINGLE_KEY(wait_time_max) | 205 | SINGLE_KEY(wait_time_max) |
207 | 206 | ||
207 | static int lock_stat_key_wait_time_min(struct lock_stat *one, | ||
208 | struct lock_stat *two) | ||
209 | { | ||
210 | u64 s1 = one->wait_time_min; | ||
211 | u64 s2 = two->wait_time_min; | ||
212 | if (s1 == ULLONG_MAX) | ||
213 | s1 = 0; | ||
214 | if (s2 == ULLONG_MAX) | ||
215 | s2 = 0; | ||
216 | return s1 > s2; | ||
217 | } | ||
218 | |||
208 | struct lock_key { | 219 | struct lock_key { |
209 | /* | 220 | /* |
210 | * name: the value for specify by user | 221 | * name: the value for specify by user |