aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-diff.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2009-12-15 17:04:41 -0500
committerIngo Molnar <mingo@elte.hu>2009-12-16 02:53:49 -0500
commitc410a33887c17cac95ed8b0d860cdfb5c087a7d8 (patch)
tree54fe6ed5ac64ff77763ff686af58bd36b04e73d6 /tools/perf/builtin-diff.c
parent655000e7c75a559681ee7f15f6fa870c80ae3194 (diff)
perf symbols: Move symbol filtering to event__preprocess_sample()
So that --dsos, --comm, --symbols can bem used in more tools, like in perf diff: $ perf record -f find / > /dev/null $ perf record -f find / > /dev/null $ perf diff --dsos /lib64/libc-2.10.1.so | head -5 1 +22392124 /lib64/libc-2.10.1.so _IO_vfprintf_internal 2 +6410655 /lib64/libc-2.10.1.so __GI_memmove 3 +1 +9192692 /lib64/libc-2.10.1.so _int_malloc 4 -1 -15158605 /lib64/libc-2.10.1.so _int_free 5 +45669 /lib64/libc-2.10.1.so _IO_new_file_xsputn $ Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> LKML-Reference: <1260914682-29652-3-git-send-email-acme@infradead.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-diff.c')
-rw-r--r--tools/perf/builtin-diff.c19
1 files changed, 16 insertions, 3 deletions
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 4fde60655341..ff91e9c291bb 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -50,6 +50,9 @@ static int diff__process_sample_event(event_t *event, struct perf_session *sessi
50 return -1; 50 return -1;
51 } 51 }
52 52
53 if (al.filtered)
54 return 0;
55
53 event__parse_sample(event, session->sample_type, &data); 56 event__parse_sample(event, session->sample_type, &data);
54 57
55 if (al.sym && perf_session__add_hist_entry(session, &al, data.period)) { 58 if (al.sym && perf_session__add_hist_entry(session, &al, data.period)) {
@@ -182,10 +185,14 @@ blank: memset(displacement, ' ', sizeof(displacement));
182 printed = fprintf(fp, "%4lu %5.5s ", pos, displacement); 185 printed = fprintf(fp, "%4lu %5.5s ", pos, displacement);
183 186
184 if (show_percent) { 187 if (show_percent) {
185 double old_percent = (old_count * 100) / pair_session->events_stats.total, 188 double old_percent = 0, new_percent = 0, diff;
186 new_percent = (self->count * 100) / session->events_stats.total; 189
187 double diff = old_percent - new_percent; 190 if (pair_session->events_stats.total > 0)
191 old_percent = (old_count * 100) / pair_session->events_stats.total;
192 if (session->events_stats.total > 0)
193 new_percent = (self->count * 100) / session->events_stats.total;
188 194
195 diff = old_percent - new_percent;
189 if (verbose) 196 if (verbose)
190 printed += fprintf(fp, " %3.2f%% %3.2f%%", old_percent, new_percent); 197 printed += fprintf(fp, " %3.2f%% %3.2f%%", old_percent, new_percent);
191 198
@@ -260,6 +267,12 @@ static const struct option options[] = {
260 "Don't shorten the pathnames taking into account the cwd"), 267 "Don't shorten the pathnames taking into account the cwd"),
261 OPT_BOOLEAN('P', "full-paths", &event_ops.full_paths, 268 OPT_BOOLEAN('P', "full-paths", &event_ops.full_paths,
262 "Don't shorten the pathnames taking into account the cwd"), 269 "Don't shorten the pathnames taking into account the cwd"),
270 OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
271 "only consider symbols in these dsos"),
272 OPT_STRING('C', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
273 "only consider symbols in these comms"),
274 OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
275 "only consider these symbols"),
263 OPT_END() 276 OPT_END()
264}; 277};
265 278