diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-12-16 11:09:53 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-12-16 12:13:40 -0500 |
| commit | 604c5c92972dcb4b98be34775452d09a5d4ec248 (patch) | |
| tree | 3f4ef659340f70780d41d3850fc5f9de13fc8719 /tools/perf/builtin-diff.c | |
| parent | c351c2816177eb7d2979ec874b9b895abe9d6e5c (diff) | |
perf diff: Change the default sort order to "dso,symbol"
This is a more intuitive / more meaningful default:
$ perf diff | head -8
9.02% +1.00% libc-2.10.1.so [.] _IO_vfprintf_internal
2.91% -1.00% [kernel] [k] __kmalloc
2.85% -1.00% [kernel] [k] ext4_htree_store_dirent
1.99% -1.00% [kernel] [k] _atomic_dec_and_lock
2.44% [kernel]
$
Suggested-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1260979793-1981-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-diff.c')
| -rw-r--r-- | tools/perf/builtin-diff.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index 66f100d249a8..4d33b55d5584 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | 18 | ||
| 19 | static char const *input_old = "perf.data.old", | 19 | static char const *input_old = "perf.data.old", |
| 20 | *input_new = "perf.data"; | 20 | *input_new = "perf.data"; |
| 21 | static char diff__default_sort_order[] = "dso,symbol"; | ||
| 21 | static int force; | 22 | static int force; |
| 22 | static bool show_displacement; | 23 | static bool show_displacement; |
| 23 | 24 | ||
| @@ -220,6 +221,7 @@ static const struct option options[] = { | |||
| 220 | 221 | ||
| 221 | int cmd_diff(int argc, const char **argv, const char *prefix __used) | 222 | int cmd_diff(int argc, const char **argv, const char *prefix __used) |
| 222 | { | 223 | { |
| 224 | sort_order = diff__default_sort_order; | ||
| 223 | argc = parse_options(argc, argv, options, diff_usage, 0); | 225 | argc = parse_options(argc, argv, options, diff_usage, 0); |
| 224 | if (argc) { | 226 | if (argc) { |
| 225 | if (argc > 2) | 227 | if (argc > 2) |
