aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-buildid-list.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2010-02-03 13:52:04 -0500
committerIngo Molnar <mingo@elte.hu>2010-02-04 03:33:26 -0500
commit7b2567c1f57c059de29d3f2ca03aca84473865c8 (patch)
tree9cd0a424d666c921c1d46dcdb648313cb36ec1da /tools/perf/builtin-buildid-list.c
parent8ad94c6052649a8e32120b464eefa0ffd8f2f04f (diff)
perf build-id: Move the routine to find DSOs with hits to the lib
Because 'perf record' will have to find the build-ids in after we stop recording, so as to reduce even more the impact in the workload while we do the measurement. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> LKML-Reference: <1265223128-11786-5-git-send-email-acme@infradead.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-buildid-list.c')
-rw-r--r--tools/perf/builtin-buildid-list.c31
1 files changed, 2 insertions, 29 deletions
diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c
index 431f204bde64..d0675c02f81e 100644
--- a/tools/perf/builtin-buildid-list.c
+++ b/tools/perf/builtin-buildid-list.c
@@ -8,6 +8,7 @@
8 */ 8 */
9#include "builtin.h" 9#include "builtin.h"
10#include "perf.h" 10#include "perf.h"
11#include "util/build-id.h"
11#include "util/cache.h" 12#include "util/cache.h"
12#include "util/debug.h" 13#include "util/debug.h"
13#include "util/parse-options.h" 14#include "util/parse-options.h"
@@ -33,34 +34,6 @@ static const struct option options[] = {
33 OPT_END() 34 OPT_END()
34}; 35};
35 36
36static int build_id_list__process_event(event_t *event,
37 struct perf_session *session)
38{
39 struct addr_location al;
40 u8 cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
41 struct thread *thread = perf_session__findnew(session, event->ip.pid);
42
43 if (thread == NULL) {
44 pr_err("problem processing %d event, skipping it.\n",
45 event->header.type);
46 return -1;
47 }
48
49 thread__find_addr_map(thread, session, cpumode, MAP__FUNCTION,
50 event->ip.ip, &al);
51
52 if (al.map != NULL)
53 al.map->dso->hit = 1;
54
55 return 0;
56}
57
58static struct perf_event_ops build_id_list__event_ops = {
59 .sample = build_id_list__process_event,
60 .mmap = event__process_mmap,
61 .fork = event__process_task,
62};
63
64static int __cmd_buildid_list(void) 37static int __cmd_buildid_list(void)
65{ 38{
66 int err = -1; 39 int err = -1;
@@ -71,7 +44,7 @@ static int __cmd_buildid_list(void)
71 return -1; 44 return -1;
72 45
73 if (with_hits) 46 if (with_hits)
74 perf_session__process_events(session, &build_id_list__event_ops); 47 perf_session__process_events(session, &build_id__mark_dso_hit_ops);
75 48
76 dsos__fprintf_buildid(stdout, with_hits); 49 dsos__fprintf_buildid(stdout, with_hits);
77 50