diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-08-19 08:50:35 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-08-24 03:24:01 -0400 |
commit | 96d6e48bc6b38342a59ccd23e25907d12caaeaf8 (patch) | |
tree | b770d9e94545e198e120fac31f650600a855f689 /tools/perf/builtin-annotate.c | |
parent | 6e086437f35ad9fda448711732c4ce0f82aad569 (diff) | |
parent | 4464fcaa9cbfc9c551956b48af203e2f775ca892 (diff) |
Merge branch 'perfcounters/urgent' into perfcounters/core
Conflicts:
tools/perf/builtin-annotate.c
tools/perf/builtin-report.c
Merge reason: resolve these conflicts.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
-rw-r--r-- | tools/perf/builtin-annotate.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index 96d421f7161d..4ac618b34254 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c | |||
@@ -28,6 +28,7 @@ static char const *input_name = "perf.data"; | |||
28 | static char default_sort_order[] = "comm,symbol"; | 28 | static char default_sort_order[] = "comm,symbol"; |
29 | static char *sort_order = default_sort_order; | 29 | static char *sort_order = default_sort_order; |
30 | 30 | ||
31 | static int force; | ||
31 | static int input; | 32 | static int input; |
32 | static int show_mask = SHOW_KERNEL | SHOW_USER | SHOW_HV; | 33 | static int show_mask = SHOW_KERNEL | SHOW_USER | SHOW_HV; |
33 | 34 | ||
@@ -629,6 +630,13 @@ process_fork_event(event_t *event, unsigned long offset, unsigned long head) | |||
629 | (void *)(long)(event->header.size), | 630 | (void *)(long)(event->header.size), |
630 | event->fork.pid, event->fork.ppid); | 631 | event->fork.pid, event->fork.ppid); |
631 | 632 | ||
633 | /* | ||
634 | * A thread clone will have the same PID for both | ||
635 | * parent and child. | ||
636 | */ | ||
637 | if (thread == parent) | ||
638 | return 0; | ||
639 | |||
632 | if (!thread || !parent || thread__fork(thread, parent)) { | 640 | if (!thread || !parent || thread__fork(thread, parent)) { |
633 | dump_printf("problem processing PERF_EVENT_FORK, skipping event.\n"); | 641 | dump_printf("problem processing PERF_EVENT_FORK, skipping event.\n"); |
634 | return -1; | 642 | return -1; |
@@ -976,6 +984,11 @@ static int __cmd_annotate(void) | |||
976 | exit(-1); | 984 | exit(-1); |
977 | } | 985 | } |
978 | 986 | ||
987 | if (!force && (input_stat.st_uid != geteuid())) { | ||
988 | fprintf(stderr, "file: %s not owned by current user\n", input_name); | ||
989 | exit(-1); | ||
990 | } | ||
991 | |||
979 | if (!input_stat.st_size) { | 992 | if (!input_stat.st_size) { |
980 | fprintf(stderr, "zero-sized file, nothing to do!\n"); | 993 | fprintf(stderr, "zero-sized file, nothing to do!\n"); |
981 | exit(0); | 994 | exit(0); |
@@ -1081,6 +1094,7 @@ static const struct option options[] = { | |||
1081 | "input file name"), | 1094 | "input file name"), |
1082 | OPT_STRING('s', "symbol", &sym_hist_filter, "symbol", | 1095 | OPT_STRING('s', "symbol", &sym_hist_filter, "symbol", |
1083 | "symbol to annotate"), | 1096 | "symbol to annotate"), |
1097 | OPT_BOOLEAN('f', "force", &force, "don't complain, do it"), | ||
1084 | OPT_BOOLEAN('v', "verbose", &verbose, | 1098 | OPT_BOOLEAN('v', "verbose", &verbose, |
1085 | "be more verbose (show symbol address, etc)"), | 1099 | "be more verbose (show symbol address, etc)"), |
1086 | OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, | 1100 | OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, |