aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-annotate.c
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2009-06-11 08:16:15 -0400
committerIngo Molnar <mingo@elte.hu>2009-06-11 10:48:38 -0400
commit729ff5e2aaf181f5d3ab849337fce406cd19b1d9 (patch)
tree49591d8103f05bd157c083b9392ed7f4a8b3ae17 /tools/perf/builtin-annotate.c
parentdf58ab24bf26b166874bfb18b3b5a2e0a8e63179 (diff)
perf_counter tools: Clean up u64 usage
A build error slipped in: builtin-report.c: In function ‘hist_entry__fprintf’: builtin-report.c:711: error: format ‘%12d’ expects type ‘int’, but argument 3 has type ‘uint64_t’ Because we got a bit sloppy with those types. uint64_t really sucks, because there's no printf format for it. So standardize on __u64 instead - for all types that go to or come from the ABI (which is __u64), or for values that need to be large enough even on 32-bit. Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> LKML-Reference: <new-submission> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
-rw-r--r--tools/perf/builtin-annotate.c32
1 files changed, 16 insertions, 16 deletions
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 3334a8bb1d51..b1ed5f766cb3 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -145,7 +145,7 @@ static void dsos__fprintf(FILE *fp)
145 dso__fprintf(pos, fp); 145 dso__fprintf(pos, fp);
146} 146}
147 147
148static struct symbol *vdso__find_symbol(struct dso *dso, uint64_t ip) 148static struct symbol *vdso__find_symbol(struct dso *dso, __u64 ip)
149{ 149{
150 return dso__find_symbol(kernel_dso, ip); 150 return dso__find_symbol(kernel_dso, ip);
151} 151}
@@ -178,19 +178,19 @@ static int load_kernel(void)
178 178
179struct map { 179struct map {
180 struct list_head node; 180 struct list_head node;
181 uint64_t start; 181 __u64 start;
182 uint64_t end; 182 __u64 end;
183 uint64_t pgoff; 183 __u64 pgoff;
184 uint64_t (*map_ip)(struct map *, uint64_t); 184 __u64 (*map_ip)(struct map *, __u64);
185 struct dso *dso; 185 struct dso *dso;
186}; 186};
187 187
188static uint64_t map__map_ip(struct map *map, uint64_t ip) 188static __u64 map__map_ip(struct map *map, __u64 ip)
189{ 189{
190 return ip - map->start + map->pgoff; 190 return ip - map->start + map->pgoff;
191} 191}
192 192
193static uint64_t vdso__map_ip(struct map *map, uint64_t ip) 193static __u64 vdso__map_ip(struct map *map, __u64 ip)
194{ 194{
195 return ip; 195 return ip;
196} 196}
@@ -249,7 +249,7 @@ static int map__overlap(struct map *l, struct map *r)
249 249
250static size_t map__fprintf(struct map *self, FILE *fp) 250static size_t map__fprintf(struct map *self, FILE *fp)
251{ 251{
252 return fprintf(fp, " %"PRIx64"-%"PRIx64" %"PRIx64" %s\n", 252 return fprintf(fp, " %Lx-%Lx %Lx %s\n",
253 self->start, self->end, self->pgoff, self->dso->name); 253 self->start, self->end, self->pgoff, self->dso->name);
254} 254}
255 255
@@ -373,7 +373,7 @@ static int thread__fork(struct thread *self, struct thread *parent)
373 return 0; 373 return 0;
374} 374}
375 375
376static struct map *thread__find_map(struct thread *self, uint64_t ip) 376static struct map *thread__find_map(struct thread *self, __u64 ip)
377{ 377{
378 struct map *pos; 378 struct map *pos;
379 379
@@ -414,7 +414,7 @@ struct hist_entry {
414 struct map *map; 414 struct map *map;
415 struct dso *dso; 415 struct dso *dso;
416 struct symbol *sym; 416 struct symbol *sym;
417 uint64_t ip; 417 __u64 ip;
418 char level; 418 char level;
419 419
420 uint32_t count; 420 uint32_t count;
@@ -533,7 +533,7 @@ static struct sort_entry sort_dso = {
533static int64_t 533static int64_t
534sort__sym_cmp(struct hist_entry *left, struct hist_entry *right) 534sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
535{ 535{
536 uint64_t ip_l, ip_r; 536 __u64 ip_l, ip_r;
537 537
538 if (left->sym == right->sym) 538 if (left->sym == right->sym)
539 return 0; 539 return 0;
@@ -647,7 +647,7 @@ hist_entry__collapse(struct hist_entry *left, struct hist_entry *right)
647/* 647/*
648 * collect histogram counts 648 * collect histogram counts
649 */ 649 */
650static void hist_hit(struct hist_entry *he, uint64_t ip) 650static void hist_hit(struct hist_entry *he, __u64 ip)
651{ 651{
652 unsigned int sym_size, offset; 652 unsigned int sym_size, offset;
653 struct symbol *sym = he->sym; 653 struct symbol *sym = he->sym;
@@ -676,7 +676,7 @@ static void hist_hit(struct hist_entry *he, uint64_t ip)
676 676
677static int 677static int
678hist_entry__add(struct thread *thread, struct map *map, struct dso *dso, 678hist_entry__add(struct thread *thread, struct map *map, struct dso *dso,
679 struct symbol *sym, uint64_t ip, char level) 679 struct symbol *sym, __u64 ip, char level)
680{ 680{
681 struct rb_node **p = &hist.rb_node; 681 struct rb_node **p = &hist.rb_node;
682 struct rb_node *parent = NULL; 682 struct rb_node *parent = NULL;
@@ -848,7 +848,7 @@ process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
848 int show = 0; 848 int show = 0;
849 struct dso *dso = NULL; 849 struct dso *dso = NULL;
850 struct thread *thread = threads__findnew(event->ip.pid); 850 struct thread *thread = threads__findnew(event->ip.pid);
851 uint64_t ip = event->ip.ip; 851 __u64 ip = event->ip.ip;
852 struct map *map = NULL; 852 struct map *map = NULL;
853 853
854 dprintf("%p [%p]: PERF_EVENT (IP, %d): %d: %p\n", 854 dprintf("%p [%p]: PERF_EVENT (IP, %d): %d: %p\n",
@@ -1031,7 +1031,7 @@ process_event(event_t *event, unsigned long offset, unsigned long head)
1031} 1031}
1032 1032
1033static int 1033static int
1034parse_line(FILE *file, struct symbol *sym, uint64_t start, uint64_t len) 1034parse_line(FILE *file, struct symbol *sym, __u64 start, __u64 len)
1035{ 1035{
1036 char *line = NULL, *tmp, *tmp2; 1036 char *line = NULL, *tmp, *tmp2;
1037 unsigned int offset; 1037 unsigned int offset;
@@ -1112,7 +1112,7 @@ parse_line(FILE *file, struct symbol *sym, uint64_t start, uint64_t len)
1112static void annotate_sym(struct dso *dso, struct symbol *sym) 1112static void annotate_sym(struct dso *dso, struct symbol *sym)
1113{ 1113{
1114 char *filename = dso->name; 1114 char *filename = dso->name;
1115 uint64_t start, end, len; 1115 __u64 start, end, len;
1116 char command[PATH_MAX*2]; 1116 char command[PATH_MAX*2];
1117 FILE *file; 1117 FILE *file;
1118 1118