perf tools: Consolidate symbol resolving across all tools

Now we have a very high level routine for simple tools to
process IP sample events:

	int event__preprocess_sample(const event_t *self,
				     struct addr_location *al,
				     symbol_filter_t filter)

It receives the event itself and will insert new threads in the
global threads list and resolve the map and symbol, filling all
this info into the new addr_location struct, so that tools like
annotate and report can further process the event by creating
hist_entries in their specific way (with or without callgraphs,
etc).

It in turn uses the new next layer function:

	void thread__find_addr_location(struct thread *self, u8 cpumode,
					enum map_type type, u64 addr,
					struct addr_location *al,
					symbol_filter_t filter)

This one will, given a thread (userspace or the kernel kthread
one), will find the given type (MAP__FUNCTION now, MAP__VARIABLE
too in the near future) at the given cpumode, taking vdsos into
account (userspace hit, but kernel symbol) and will fill all
these details in the addr_location given.

Tools that need a more compact API for plain function
resolution, like 'kmem', can use this other one:

	struct symbol *thread__find_function(struct thread *self, u64 addr,
					     symbol_filter_t filter)

So, to resolve a kernel symbol, that is all the 'kmem' tool
needs, its just a matter of calling:

	sym = thread__find_function(kthread, addr, NULL);

The 'filter' parameter is needed because we do lazy
parsing/loading of ELF symtabs or /proc/kallsyms.

With this we remove more code duplication all around, which is
always good, huh? :-)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1259346563-12568-12-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

1 files changed, 7 insertions, 48 deletions

diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 7d39bd2b19b8..7f85c6e159a4 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -124,71 +124,30 @@ static void hist_hit(struct hist_entry *he, u64 ip)
                         h->ip[offset]);
 }
 
-static int hist_entry__add(struct thread *thread, struct map *map,
-                           struct symbol *sym, u64 ip, u64 count, char level)
+static int hist_entry__add(struct addr_location *al, u64 count)
 {
         bool hit;
-        struct hist_entry *he = __hist_entry__add(thread, map, sym, NULL, ip,
-                                                  count, level, &hit);
+        struct hist_entry *he = __hist_entry__add(al, NULL, count, &hit);
         if (he == NULL)
                 return -ENOMEM;
-        hist_hit(he, ip);
+        hist_hit(he, al->addr);
         return 0;
 }
 
 static int process_sample_event(event_t *event)
 {
-        char level;
-        u64 ip = event->ip.ip;
-        struct map *map = NULL;
-        struct symbol *sym = NULL;
-        struct thread *thread = threads__findnew(event->ip.pid);
+        struct addr_location al;
 
         dump_printf("(IP, %d): %d: %p\n", event->header.misc,
-                    event->ip.pid, (void *)(long)ip);
+                    event->ip.pid, (void *)(long)event->ip.ip);
 
-        if (thread == NULL) {
+        if (event__preprocess_sample(event, &al, symbol_filter) < 0) {
                 fprintf(stderr, "problem processing %d event, skipping it.\n",
                         event->header.type);
                 return -1;
         }
 
-        dump_printf(" ... thread: %s:%d\n", thread->comm, thread->pid);
-
-        if (event->header.misc & PERF_RECORD_MISC_KERNEL) {
-                level = 'k';
-                sym = kernel_maps__find_function(ip, &map, symbol_filter);
-                dump_printf(" ...... dso: %s\n",
-                            map ? map->dso->long_name : "<not found>");
-        } else if (event->header.misc & PERF_RECORD_MISC_USER) {
-                level = '.';
-                map = thread__find_map(thread, MAP__FUNCTION, ip);
-                if (map != NULL) {
-                        ip = map->map_ip(map, ip);
-                        sym = map__find_symbol(map, ip, symbol_filter);
-                } else {
-                        /*
-                         * If this is outside of all known maps,
-                         * and is a negative address, try to look it
-                         * up in the kernel dso, as it might be a
-                         * vsyscall or vdso (which executes in user-mode).
-                         *
-                         * XXX This is nasty, we should have a symbol list in
-                         * the "[vdso]" dso, but for now lets use the old
-                         * trick of looking in the whole kernel symbol list.
-                         */
-                        if ((long long)ip < 0)
-                                sym = kernel_maps__find_function(ip, &map,
-                                                                 symbol_filter);
-                }
-                dump_printf(" ...... dso: %s\n",
-                            map ? map->dso->long_name : "<not found>");
-        } else {
-                level = 'H';
-                dump_printf(" ...... dso: [hypervisor]\n");
-        }
-
-        if (hist_entry__add(thread, map, sym, ip, 1, level)) {
+        if (hist_entry__add(&al, 1)) {
                 fprintf(stderr, "problem incrementing symbol count, "
                                 "skipping event\n");
                 return -1;