diff options
author | Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> | 2009-11-08 22:31:05 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-11-09 02:14:30 -0500 |
commit | 5ff0cfc67f00fe0feaa1da0b2359232ea4aa0ee7 (patch) | |
tree | f432370dfa63a7a3b63354d670128764eff534a1 /tools/perf/bench | |
parent | bfde82ef51e3ea6ab8634d0fdbf5adcdd1b429cb (diff) |
perf bench: Fix bench/sched-pipe.c to wait for child process
Ingo reported this small 'perf bench sched pipe' output problem:
| $ ./perf bench sched pipe
| (executing 1000000 pipe operations between two tasks)
|
| Total time:4.898 sec
| $ 4.898586 usecs/op
| 204140 ops/sec
|
| the shell prompt came back before the usecs/op and ops/sec line
| was printed. Process teardown race, lack of wait() or so?
This caused by lack of calling waitpid() by parent process,
so I added it.
Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>
LKML-Reference: <1257737465-7546-1-git-send-email-mitake@dcl.info.waseda.ac.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/bench')
-rw-r--r-- | tools/perf/bench/sched-pipe.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/tools/perf/bench/sched-pipe.c b/tools/perf/bench/sched-pipe.c index 3214ed20b1aa..6a29100e9282 100644 --- a/tools/perf/bench/sched-pipe.c +++ b/tools/perf/bench/sched-pipe.c | |||
@@ -26,6 +26,7 @@ | |||
26 | #include <errno.h> | 26 | #include <errno.h> |
27 | #include <assert.h> | 27 | #include <assert.h> |
28 | #include <sys/time.h> | 28 | #include <sys/time.h> |
29 | #include <sys/types.h> | ||
29 | 30 | ||
30 | #define LOOPS_DEFAULT 1000000 | 31 | #define LOOPS_DEFAULT 1000000 |
31 | static int loops = LOOPS_DEFAULT; | 32 | static int loops = LOOPS_DEFAULT; |
@@ -58,8 +59,8 @@ int bench_sched_pipe(int argc, const char **argv, | |||
58 | * discarding returned value of read(), write() | 59 | * discarding returned value of read(), write() |
59 | * causes error in building environment for perf | 60 | * causes error in building environment for perf |
60 | */ | 61 | */ |
61 | int ret; | 62 | int ret, wait_stat; |
62 | pid_t pid; | 63 | pid_t pid, retpid; |
63 | 64 | ||
64 | argc = parse_options(argc, argv, options, | 65 | argc = parse_options(argc, argv, options, |
65 | bench_sched_pipe_usage, 0); | 66 | bench_sched_pipe_usage, 0); |
@@ -87,8 +88,11 @@ int bench_sched_pipe(int argc, const char **argv, | |||
87 | gettimeofday(&stop, NULL); | 88 | gettimeofday(&stop, NULL); |
88 | timersub(&stop, &start, &diff); | 89 | timersub(&stop, &start, &diff); |
89 | 90 | ||
90 | if (pid) | 91 | if (pid) { |
92 | retpid = waitpid(pid, &wait_stat, 0); | ||
93 | assert((retpid == pid) && WIFEXITED(wait_stat)); | ||
91 | return 0; | 94 | return 0; |
95 | } | ||
92 | 96 | ||
93 | if (simple) | 97 | if (simple) |
94 | printf("%lu.%03lu\n", | 98 | printf("%lu.%03lu\n", |